[PRME-185] Fix nav links on go virus page and complete page (#744)

Author: adamwhitingnhs

app/src/components/blocks/_documentUpload/documentUploadInfectedStage/DocumentUploadInfectedStage.test.tsx

@@ -19,7 +19,7 @@ describe('DocumentUploadInfectedStage', () => {
                 'One or more of your files has a virus.',
                 "To keep patient information safe and our systems secure, we've stopped the upload.",
                 'Contact your local IT support desk for help.',
-                'Go back to choose Lloyd George files to upload',
+                'Go to home',
             ];
 
             render(
@@ -35,7 +35,7 @@ describe('DocumentUploadInfectedStage', () => {
 
             expect(
                 screen.getByRole('button', {
-                    name: 'Go back to choose Lloyd George files to upload',
+                    name: 'Go to home',
                 }),
             ).toBeInTheDocument();
         });
@@ -54,21 +54,21 @@ describe('DocumentUploadInfectedStage', () => {
     });
 
     describe('Navigation', () => {
-        it('navigates to Lloyd George upload page when button is clicked', async () => {
+        it('navigates to home page when button is clicked', async () => {
             render(
                 <MemoryRouter>
                     <DocumentUploadInfectedStage />
                 </MemoryRouter>,
             );
 
-            const backButton = screen.getByRole('button', {
-                name: 'Go back to choose Lloyd George files to upload',
+            const homeButton = screen.getByRole('button', {
+                name: 'Go to home',
             });
-            expect(backButton).toBeInTheDocument();
+            expect(homeButton).toBeInTheDocument();
 
-            await userEvent.click(backButton);
+            await userEvent.click(homeButton);
 
-            expect(mockedUseNavigate).toHaveBeenCalledWith(routes.DOCUMENT_UPLOAD, {
+            expect(mockedUseNavigate).toHaveBeenCalledWith(routes.HOME, {
                 replace: true,
             });
         });

app/src/components/blocks/_documentUpload/documentUploadInfectedStage/DocumentUploadInfectedStage.tsx

@@ -24,10 +24,10 @@ function DocumentUploadInfectedStage() {
                     className="govuk-link"
                     onClick={(e) => {
                         e.preventDefault();
-                        navigate(routes.DOCUMENT_UPLOAD, { replace: true });
+                        navigate(routes.HOME, { replace: true });
                     }}
                 >
-                    Go back to choose Lloyd George files to upload
+                    Go to home
                 </button>
             </p>
         </>

app/src/pages/documentUploadPage/DocumentUploadPage.tsx

@@ -47,6 +47,7 @@ function DocumentUploadPage() {
     const baseHeaders = useBaseAPIHeaders();
     const [documents, setDocuments] = useState<Array<UploadDocument>>([]);
     const [uploadSession, setUploadSession] = useState<UploadSession | null>(null);
+    const completeRef = useRef(false);
     const virusReference = useRef(false);
     const navigate = useNavigate();
     const [intervalTimer, setIntervalTimer] = useState(0);
@@ -71,12 +72,14 @@ function DocumentUploadPage() {
             documents.every((d) => d.state === DOCUMENT_UPLOAD_STATE.SUCCEEDED);
 
         if (hasVirus && !virusReference.current) {
+            virusReference.current = true;
             window.clearInterval(intervalTimer);
             navigate(routeChildren.DOCUMENT_UPLOAD_INFECTED);
         } else if (docWithError) {
             const errorParams = docWithError.error ? errorCodeToParams(docWithError.error) : '';
             navigate(routes.SERVER_ERROR + errorParams);
-        } else if (allFinished) {
+        } else if (allFinished && !completeRef.current) {
+            completeRef.current = true;
             window.clearInterval(intervalTimer);
             navigate(routeChildren.DOCUMENT_UPLOAD_COMPLETED);
         }