[PRMP-434] Bulk upload not reporting patient not found errors (#797)

Author: MohammadIqbalAD-NHS

lambdas/services/bulk_upload_service.py

@@ -23,6 +23,7 @@
     DocumentInfectedException,
     InvalidMessageException,
     InvalidNhsNumberException,
+    PatientNotFoundException,
     PatientRecordAlreadyExistException,
     PdsErrorException,
     PdsTooManyRequestsException,
@@ -180,6 +181,7 @@ def handle_sqs_message(self, message: dict):
         except (
             InvalidNhsNumberException,
             LGInvalidFilesException,
+            PatientNotFoundException,
             PatientRecordAlreadyExistException,
         ) as error:
             logger.info(

lambdas/tests/unit/services/test_bulk_upload_service.py

@@ -46,6 +46,7 @@
     BulkUploadException,
     DocumentInfectedException,
     InvalidMessageException,
+    PatientNotFoundException,
     PatientRecordAlreadyExistException,
     PdsTooManyRequestsException,
     S3FileNotFoundException,
@@ -1069,3 +1070,25 @@ def test_concatenate_acceptance_reason(repo_under_test):
         actual_reason, another_test_reason
     )
     assert another_actual_reason == test_reason + ", " + another_test_reason
+
+
+def test_patient_not_found_is_caught_and_written_to_dynamo(
+    repo_under_test, mock_validate_files, mocker
+):
+    expected_error_message = "Could not find the given patient on PDS"
+    mocker.patch(
+        "services.bulk_upload_service.getting_patient_info_from_pds",
+        side_effect=PatientNotFoundException(expected_error_message),
+    )
+
+    repo_under_test.handle_sqs_message(message=TEST_SQS_MESSAGE)
+
+    repo_under_test.dynamo_repository.write_report_upload_to_dynamo.assert_called_once()
+
+    call_metadata, call_status, call_reason, call_ods_code = (
+        repo_under_test.dynamo_repository.write_report_upload_to_dynamo.call_args[0]
+    )
+
+    assert call_status == UploadStatus.FAILED
+    assert call_reason == expected_error_message
+    assert call_metadata == TEST_STAGING_METADATA