Skip to content

Commit bc66a60

Browse files
authored
[PRMP-1401] add condition to not build mns lambda on sandbox (#498)
1 parent ad25b30 commit bc66a60

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

.github/workflows/base-lambdas-reusable-deploy-all.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,14 @@ on:
1414
required: true
1515
type: 'string'
1616
sandbox:
17-
description: 'Which Sandbox to push to'
17+
description: 'Which Sandbox to push to?'
1818
required: true
1919
type: 'string'
20+
is_sandbox:
21+
description: 'Is this deploying to a sandbox?'
22+
required: false
23+
default: false
24+
type: boolean
2025
secrets:
2126
AWS_ASSUME_ROLE:
2227
required: true
@@ -403,6 +408,7 @@ jobs:
403408
AWS_ASSUME_ROLE: ${{ secrets.AWS_ASSUME_ROLE }}
404409

405410
deploy_mns_notification_lambda:
411+
if: ${{ ! inputs.is_sandbox }}
406412
name: Deploy mns notification lambda
407413
uses: ./.github/workflows/base-lambdas-reusable-deploy.yml
408414
with:

.github/workflows/full-deploy-to-sandbox.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ jobs:
8585
sandbox: ${{ inputs.sandbox }}
8686
environment: ${{ inputs.environment }}
8787
python_version: "3.11"
88+
is_sandbox: true
8889
secrets:
8990
AWS_ASSUME_ROLE: ${{ secrets.AWS_ASSUME_ROLE }}
9091

.github/workflows/lambdas-deploy-feature-to-sandbox.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ jobs:
7272
python_version: "3.11"
7373
build_branch: ${{ inputs.build_branch }}
7474
sandbox: ${{ inputs.sandbox }}
75+
is_sandbox: true
7576
secrets:
7677
AWS_ASSUME_ROLE: ${{ secrets.AWS_ASSUME_ROLE }}
7778

lambdas/tests/unit/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ def set_env(monkeypatch):
176176
monkeypatch.setenv("NRL_SQS_QUEUE_URL", NRL_SQS_URL)
177177

178178

179-
180179
EXPECTED_PARSED_PATIENT_BASE_CASE = PatientDetails(
181180
givenName=["Jane"],
182181
familyName="Smith",

0 commit comments

Comments
 (0)