remove role permissions around admin button

Author: adamwhitingnhs

app/src/pages/homePage/HomePage.test.tsx

@@ -1,7 +1,5 @@
 import { render, screen } from '@testing-library/react';
 import HomePage from './HomePage';
-import useRole from '../../helpers/hooks/useRole';
-import { REPOSITORY_ROLE } from '../../types/generic/authRole';
 import { buildConfig } from '../../helpers/test/testBuilders';
 import useConfig from '../../helpers/hooks/useConfig';
 import { routes } from '../../types/generic/routes';
@@ -16,9 +14,7 @@ vi.mock('react-router-dom', async () => {
     };
 });
 
-vi.mock('../../helpers/hooks/useRole');
 vi.mock('../../helpers/hooks/useConfig');
-const mockUseRole = useRole as Mock;
 const mockUseConfig = useConfig as Mock;
 
 describe('HomePage', () => {
@@ -28,39 +24,20 @@ describe('HomePage', () => {
     afterEach(() => {
         vi.clearAllMocks();
     });
-    const gpRoles = [REPOSITORY_ROLE.GP_ADMIN, REPOSITORY_ROLE.GP_CLINICAL];
 
-    const validateHomePageRendered = () => {
-        render(<HomePage />);
-
-        const searchPatientButton = screen.getByTestId('search-patient-btn') as HTMLAnchorElement;
-        const downloadReportButton = screen.getByTestId('download-report-btn') as HTMLAnchorElement;
-        expect(searchPatientButton).toBeInTheDocument();
-        expect(downloadReportButton).toBeInTheDocument();
-    };
-
-    describe('Rendering for GP roles', () => {
-        it.each(gpRoles)(
-            '[%s] render home page with patient search and download report',
-            async (role) => {
-                mockUseRole.mockReturnValue(role);
-
-                validateHomePageRendered();
-            },
-        );
-    });
-
-    describe('PCSE Rendering', () => {
+    describe('Rendering', () => {
         it('should render home page with patient search and download report', async () => {
-            mockUseRole.mockReturnValue(REPOSITORY_ROLE.PCSE);
+            render(<HomePage />);
 
-            validateHomePageRendered();
+            const searchPatientButton = screen.getByTestId('search-patient-btn') as HTMLAnchorElement;
+            const downloadReportButton = screen.getByTestId('download-report-btn') as HTMLAnchorElement;
+            expect(searchPatientButton).toBeInTheDocument();
+            expect(downloadReportButton).toBeInTheDocument();
         });
     });
 
     describe('Admin Console button', () => {
-        it('renders admin console button when feature flag is enabled and user is GP_ADMIN', () => {
-            mockUseRole.mockReturnValue(REPOSITORY_ROLE.GP_ADMIN);
+        it('renders admin console button when feature flag is enabled', () => {
             mockUseConfig.mockReturnValue(
                 buildConfig(undefined, { uploadDocumentIteration3Enabled: true }),
             );
@@ -74,7 +51,6 @@ describe('HomePage', () => {
         });
 
         it('does not render admin console button when feature flag is disabled', () => {
-            mockUseRole.mockReturnValue(REPOSITORY_ROLE.GP_ADMIN);
             mockUseConfig.mockReturnValue(
                 buildConfig(undefined, { uploadDocumentIteration3Enabled: false }),
             );
@@ -83,27 +59,5 @@ describe('HomePage', () => {
 
             expect(screen.queryByTestId('admin-console-btn')).not.toBeInTheDocument();
         });
-
-        it('does not render admin console button when user is GP_CLINICAL', () => {
-            mockUseRole.mockReturnValue(REPOSITORY_ROLE.GP_CLINICAL);
-            mockUseConfig.mockReturnValue(
-                buildConfig(undefined, { uploadDocumentIteration3Enabled: true }),
-            );
-
-            render(<HomePage />);
-
-            expect(screen.queryByTestId('admin-console-btn')).not.toBeInTheDocument();
-        });
-
-        it('does not render admin console button when user is PCSE', () => {
-            mockUseRole.mockReturnValue(REPOSITORY_ROLE.PCSE);
-            mockUseConfig.mockReturnValue(
-                buildConfig(undefined, { uploadDocumentIteration3Enabled: true }),
-            );
-
-            render(<HomePage />);
-
-            expect(screen.queryByTestId('admin-console-btn')).not.toBeInTheDocument();
-        });
     });
 });

app/src/pages/homePage/HomePage.tsx

@@ -4,13 +4,10 @@ import useTitle from '../../helpers/hooks/useTitle';
 import { REPORT_TYPE } from '../../types/generic/reports';
 import { ReactComponent as RightCircleIcon } from '../../styles/right-chevron-circle.svg';
 import useConfig from '../../helpers/hooks/useConfig';
-import useRole from '../../helpers/hooks/useRole';
-import { REPOSITORY_ROLE } from '../../types/generic/authRole';
 
 const HomePage = (): React.JSX.Element => {
     useTitle({ pageTitle: 'Access and store digital patient documents' });
     const config = useConfig();
-    const role = useRole();
     const uploadEnabled =
         config.featureFlags.uploadLambdaEnabled &&
         config.featureFlags.uploadLloydGeorgeWorkflowEnabled;
@@ -78,26 +75,25 @@ const HomePage = (): React.JSX.Element => {
                     </Card>
                 </Card.GroupItem>
                 {config.featureFlags.uploadDocumentIteration3Enabled &&
-                    role === REPOSITORY_ROLE.GP_ADMIN && (
-                        <Card.GroupItem width="one-half">
-                            <Card clickable cardType="primary">
-                                <Card.Content>
-                                    <Card.Heading className="nhsuk-heading-m">
-                                        <Card.Link
-                                            data-testid="admin-console-btn"
-                                            href={routes.ADMIN_ROUTE}
-                                        >
-                                            Admin console
-                                        </Card.Link>
-                                    </Card.Heading>
-                                    <Card.Description>
-                                        Review records and actions for incoming patients
-                                    </Card.Description>
-                                    <RightCircleIcon />
-                                </Card.Content>
-                            </Card>
-                        </Card.GroupItem>
-                    )}
+                    <Card.GroupItem width="one-half">
+                        <Card clickable cardType="primary">
+                            <Card.Content>
+                                <Card.Heading className="nhsuk-heading-m">
+                                    <Card.Link
+                                        data-testid="admin-console-btn"
+                                        href={routes.ADMIN_ROUTE}
+                                    >
+                                        Admin console
+                                    </Card.Link>
+                                </Card.Heading>
+                                <Card.Description>
+                                    Review records and actions for incoming patients
+                                </Card.Description>
+                                <RightCircleIcon />
+                            </Card.Content>
+                        </Card>
+                    </Card.GroupItem>
+                }
             </Card.Group>
         </>
     );