Skip to content

Commit d0b6ad3

Browse files
authored
PRM-54: WCAG 2.4.3 focus order: view full screen button is out of order (#605)
* [PRM-54] Moved header component above view in fullscreen for view record * [PRM-54] Adds inline display for header and fullscreen button to match old styling
1 parent 4c524b7 commit d0b6ad3

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

app/src/components/generic/recordCard/RecordCard.tsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,16 @@ function RecordCard({
6262
data-testid="pdf-card"
6363
className="lloydgeorge_record-stage_pdf-content"
6464
>
65+
<Card.Heading
66+
className="lloydgeorge_record-stage_pdf-content-label"
67+
headingLevel="h2"
68+
tabIndex={0}
69+
>
70+
{heading}
71+
</Card.Heading>
6572
{cloudFrontUrl && (
6673
<button
67-
className="lloydgeorge_record-stage_pdf-content-button link-button clickable"
74+
className="lloydgeorge_record-stage_pdf-content-button link-button clickable full-screen"
6875
data-testid="full-screen-btn"
6976
onClick={() => {
7077
fullScreenHandler(true);
@@ -74,12 +81,7 @@ function RecordCard({
7481
View in full screen
7582
</button>
7683
)}
77-
<Card.Heading
78-
className="lloydgeorge_record-stage_pdf-content-label"
79-
headingLevel="h2"
80-
>
81-
{heading}
82-
</Card.Heading>
84+
8385
{detailsElement}
8486

8587
<RecordMenuCard

app/src/styles/App.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ $hunit: '%';
303303
max-width: calc(100% - 130px);
304304
word-wrap: break-word;
305305
overflow-wrap: break-word;
306+
display: inline;
306307
}
307308

308309
p {
@@ -828,6 +829,10 @@ $hunit: '%';
828829
cursor: pointer;
829830
}
830831

832+
.full-screen {
833+
display: inline;
834+
}
835+
831836
.table-column-header {
832837
font-size: 1.5rem;
833838
}

0 commit comments

Comments
 (0)