[PRMP-122] Add missing function return types (#784)

Author: adamwhitingnhs

app/src/App.tsx

@@ -7,6 +7,7 @@ import { AwsRum, AwsRumConfig } from 'aws-rum-web';
 import { NdrTokenData } from './types/generic/ndrTokenData';
 import { decodeJwtToken } from './helpers/utils/jwtDecoder';
 import PatientAccessAuditProvider from './providers/patientAccessAuditProvider/PatientAccessAuditProvider';
+import { JSX } from 'react';
 
 const cypress =
     import.meta.env.VITE_MONITOR_ACCOUNT_ID === 'not provided yet' &&
@@ -58,7 +59,7 @@ if (import.meta.env.VITE_ENVIRONMENT === 'development' && !cypress) {
     }
 }
 
-function App() {
+const App = (): JSX.Element => {
     return (
         <ConfigProvider>
             <SessionProvider>
@@ -70,5 +71,5 @@ function App() {
             </SessionProvider>
         </ConfigProvider>
     );
-}
+};
 export default App;

app/src/components/blocks/_arf/completeStage/CompleteStage.tsx

@@ -7,7 +7,7 @@ interface Props {
     documents: Array<UploadDocument>;
 }
 
-function CompleteStage({ documents }: Props) {
+const CompleteStage = ({ documents }: Props): React.JSX.Element => {
     const navigate = useNavigate();
 
     return (
@@ -18,14 +18,14 @@ function CompleteStage({ documents }: Props) {
             </p>
             <Button
                 id="start-again-button"
-                onClick={() => {
+                onClick={(): void => {
                     navigate('/');
                 }}
             >
                 Start Again
             </Button>
         </>
     );
-}
+};
 
 export default CompleteStage;

app/src/components/blocks/_arf/documentInputForm/DocumentInputForm.tsx

@@ -26,7 +26,7 @@ const DocumentInputForm = ({
     inputRef,
     formType,
     showHelp = false,
-}: Props) => {
+}: Props): React.JSX.Element => {
     const hasDuplicateFiles = documents.some((doc: UploadDocument) => {
         return documents.some(
             (compare: UploadDocument) =>
@@ -45,10 +45,10 @@ const DocumentInputForm = ({
                 multiple={true}
                 name={formController.field.name}
                 error={formController.fieldState.error?.message}
-                onChange={(e: FileInputEvent) => onDocumentInput(e, formType)}
+                onChange={(e: FileInputEvent): void => onDocumentInput(e, formType)}
                 onBlur={formController.field.onBlur}
                 // @ts-ignore  The NHS Component library is outdated and does not allow for any reference other than a blank MutableRefObject
-                inputRef={(e: HTMLInputElement) => {
+                inputRef={(e: HTMLInputElement): void => {
                     formController.field.ref(e);
                     inputRef.current = e;
                 }}
@@ -111,7 +111,7 @@ const DocumentInputForm = ({
                                             type="button"
                                             aria-label={`Remove ${document.file.name} from selection`}
                                             className="link-button"
-                                            onClick={() => {
+                                            onClick={(): void => {
                                                 onDocumentRemove(index, formType);
                                             }}
                                         >

app/src/components/blocks/_arf/documentSearchResults/DocumentSearchResults.tsx

@@ -6,14 +6,15 @@ type Props = {
     searchResults: Array<SearchResult>;
 };
 
-const DocumentSearchResults = (props: Props) => {
-    const sortMethod = (a: SearchResult, b: SearchResult) =>
+const DocumentSearchResults = (props: Props): React.JSX.Element => {
+    const sortMethod = (a: SearchResult, b: SearchResult): number =>
         new Date(a.created) < new Date(b.created) ? 1 : -1;
 
     const orderedResults = [...props.searchResults].sort(sortMethod);
     const tableCaption = (
         <h2 className="document-search-table-caption">List of documents available</h2>
     );
+
     return (
         <Table id="available-files-table-title" caption={tableCaption}>
             <Table.Head>

app/src/components/blocks/_arf/documentSearchResultsOptions/DocumentSearchResultsOptions.tsx

@@ -22,7 +22,7 @@ interface DownloadLinkAttributes {
     filename: string;
 }
 
-const DocumentSearchResultsOptions = (props: Props) => {
+const DocumentSearchResultsOptions = (props: Props): React.JSX.Element => {
     const navigate = useNavigate();
     const baseUrl = useBaseAPIUrl();
     const baseHeaders = useBaseAPIHeaders();
@@ -54,7 +54,7 @@ const DocumentSearchResultsOptions = (props: Props) => {
         }
     }, [linkAttributes]);
 
-    const downloadAll = async () => {
+    const downloadAll = async (): Promise<void> => {
         props.updateDownloadState(SUBMISSION_STATE.PENDING);
         try {
             const preSignedUrl = await getPresignedUrlForZip({
@@ -80,7 +80,7 @@ const DocumentSearchResultsOptions = (props: Props) => {
         }
     };
 
-    const deleteAllDocuments = () => {
+    const deleteAllDocuments = (): void => {
         navigate(routeChildren.ARF_DELETE_CONFIRMATION);
     };
 

app/src/components/blocks/_arf/selectStage/SelectStage.tsx

@@ -21,15 +21,19 @@ interface Props {
     startUpload: () => Promise<void>;
 }
 
-function SelectStage({ setDocuments, documents, startUpload }: Readonly<Props>) {
+const SelectStage = ({
+    setDocuments,
+    documents,
+    startUpload,
+}: Readonly<Props>): React.JSX.Element => {
     const arfInputRef = useRef<HTMLInputElement | null>(null);
 
     const hasFileInput = documents.length > 0;
 
     const { handleSubmit, control, formState, setError } = useForm();
     const arfController = useController(ARFFormConfig(control));
 
-    const submitDocuments = async () => {
+    const submitDocuments = async (): Promise<void> => {
         if (!hasFileInput) {
             setError('arf-documents', { type: 'custom', message: 'Select a file to upload' });
             return;
@@ -38,7 +42,7 @@ function SelectStage({ setDocuments, documents, startUpload }: Readonly<Props>)
         await startUpload();
     };
 
-    const onInput = (e: FileInputEvent, docType: DOCUMENT_TYPE) => {
+    const onInput = (e: FileInputEvent, docType: DOCUMENT_TYPE): void => {
         const fileArray = Array.from(e.target.files ?? new FileList());
         const newlyAddedDocuments: Array<UploadDocument> = fileArray.map((file) => ({
             id: uuidv4(),
@@ -53,7 +57,7 @@ function SelectStage({ setDocuments, documents, startUpload }: Readonly<Props>)
         setDocuments(updatedDocList);
     };
 
-    const onRemove = (index: number, _docType: DOCUMENT_TYPE) => {
+    const onRemove = (index: number, _docType: DOCUMENT_TYPE): void => {
         const updatedDocList: UploadDocument[] = [
             ...documents.slice(0, index),
             ...documents.slice(index + 1),
@@ -107,6 +111,6 @@ function SelectStage({ setDocuments, documents, startUpload }: Readonly<Props>)
             </form>
         </>
     );
-}
+};
 
 export default SelectStage;

app/src/components/blocks/_arf/uploadConfirmationFailed/uploadConfirmationFailed.tsx

@@ -1,7 +1,7 @@
 import React from 'react';
 import useTitle from '../../../../helpers/hooks/useTitle';
 
-const UploadConfirmationFailed = () => {
+const UploadConfirmationFailed = (): React.JSX.Element => {
     const pageHeader = "We couldn't confirm the upload";
     useTitle({ pageTitle: pageHeader });
 

app/src/components/blocks/_arf/uploadFailedStage/uploadFailedStage.tsx

@@ -1,7 +1,7 @@
 import React from 'react';
 import useTitle from '../../../../helpers/hooks/useTitle';
 
-const UploadFailedStage = () => {
+const UploadFailedStage = (): React.JSX.Element => {
     const pageHeader = 'All files failed to upload';
     useTitle({ pageTitle: pageHeader });
 

app/src/components/blocks/_arf/uploadSummary/UploadSummary.tsx

@@ -13,7 +13,7 @@ import PatientSummary from '../../../generic/patientSummary/PatientSummary';
 export interface Props {
     documents: Array<UploadDocument>;
 }
-const UploadSummary = ({ documents }: Props) => {
+const UploadSummary = ({ documents }: Props): React.JSX.Element => {
     const successfulUploads = documents.filter((document) => {
         return document.state === DOCUMENT_UPLOAD_STATE.SUCCEEDED;
     });

app/src/components/blocks/_arf/uploadingStage/UploadingStage.tsx

@@ -12,7 +12,7 @@ interface Props {
     documents: Array<UploadDocument>;
 }
 
-function UploadingStage({ documents }: Props) {
+const UploadingStage = ({ documents }: Props): React.JSX.Element => {
     const pageHeader = 'Your documents are uploading';
     useTitle({ pageTitle: 'Uploading documents' });
 
@@ -63,6 +63,6 @@ function UploadingStage({ documents }: Props) {
             </Table>
         </>
     );
-}
+};
 
 export default UploadingStage;