Add feature flag for document review iteration 3 and update related services

Author: NogaNHS

lambdas/enums/feature_flags.py

@@ -10,3 +10,4 @@ class FeatureFlags(StrEnum):
         "lloydGeorgeValidationStrictModeEnabled"
     )
     UPLOAD_DOCUMENT_ITERATION_2_ENABLED = "uploadDocumentIteration2Enabled"
+    UPLOAD_DOCUMENT_ITERATION_3_ENABLED = "uploadDocumentIteration3Enabled"

lambdas/services/document_upload_review_service.py

@@ -26,7 +26,7 @@ def update_document_review_custodian(
         self,
         patient_documents: list[DocumentUploadReviewReference],
         updated_ods_code: str,
-    ) -> None:
+    ):
         review_update_field = {"custodian"}
         if not patient_documents:
             return

lambdas/services/process_mns_message_service.py

@@ -2,6 +2,7 @@
 
 from botocore.exceptions import ClientError
 from enums.death_notification_status import DeathNotificationStatus
+from enums.feature_flags import FeatureFlags
 from enums.mns_notification_types import MNSNotificationTypes
 from enums.patient_ods_inactive_status import PatientOdsInactiveStatus
 from models.document_reference import DocumentReference
@@ -10,6 +11,7 @@
 from services.base.sqs_service import SQSService
 from services.document_reference_service import DocumentReferenceService
 from services.document_upload_review_service import DocumentUploadReviewService
+from services.feature_flags_service import FeatureFlagService
 from utils.audit_logging_setup import LoggingService
 from utils.exceptions import PdsErrorException
 from utils.utilities import get_pds_service
@@ -24,6 +26,8 @@ def __init__(self):
         self.pds_service = get_pds_service()
         self.sqs_service = SQSService()
         self.queue = os.getenv("MNS_NOTIFICATION_QUEUE_URL")
+        self.feature_flag_service = FeatureFlagService()
+        self.is_review_feature_enabled = self.check_if_review_feature_enabled()
 
     def handle_mns_notification(self, message: MNSSQSMessage):
         try:
@@ -114,11 +118,14 @@ def get_all_patient_documents(
                 nhs_number
             )
         )
-        review_documents = (
-            self.document_review_service.fetch_documents_from_table_with_nhs_number(
-                nhs_number
+        if self.is_review_feature_enabled:
+            review_documents = (
+                self.document_review_service.fetch_documents_from_table_with_nhs_number(
+                    nhs_number
+                )
             )
-        )
+        else:
+            review_documents = []
         return lg_documents, review_documents
 
     def update_all_patient_documents(
@@ -132,7 +139,18 @@ def update_all_patient_documents(
             self.lg_document_service.update_patient_ods_code(
                 lg_documents, updated_ods_code
             )
-        if review_documents:
+        if review_documents and self.is_review_feature_enabled:
             self.document_review_service.update_document_review_custodian(
                 review_documents, updated_ods_code
             )
+
+    def check_if_review_feature_enabled(self) -> bool:
+        upload_lambda_enabled_flag_object = (
+            self.feature_flag_service.get_feature_flags_by_flag(
+                FeatureFlags.UPLOAD_DOCUMENT_ITERATION_3_ENABLED
+            )
+        )
+
+        return upload_lambda_enabled_flag_object[
+            FeatureFlags.UPLOAD_DOCUMENT_ITERATION_3_ENABLED
+        ]

lambdas/tests/unit/services/test_process_mns_message_service.py

@@ -2,10 +2,12 @@
 
 import pytest
 from botocore.exceptions import ClientError
+from enums.feature_flags import FeatureFlags
 from enums.patient_ods_inactive_status import PatientOdsInactiveStatus
 from models.document_reference import DocumentReference
 from models.document_review import DocumentUploadReviewReference
 from models.sqs.mns_sqs_message import MNSSQSMessage
+from services.feature_flags_service import FeatureFlagService
 from services.process_mns_message_service import MNSNotificationService
 from tests.unit.conftest import TEST_CURRENT_GP_ODS, TEST_NHS_NUMBER
 from tests.unit.handlers.test_mns_notification_handler import (
@@ -18,7 +20,20 @@
 
 
 @pytest.fixture
-def mns_service(mocker, set_env, monkeypatch):
+def mns_service(mocker, set_env, monkeypatch, mock_upload_document_iteration_3_enabled):
+    monkeypatch.setenv("PDS_FHIR_IS_STUBBED", "False")
+    service = MNSNotificationService()
+    mocker.patch.object(service, "pds_service")
+    mocker.patch.object(service, "document_review_service")
+    mocker.patch.object(service, "lg_document_service")
+    mocker.patch.object(service, "sqs_service")
+    yield service
+
+
+@pytest.fixture
+def mns_service_feature_disabled(
+    mocker, set_env, monkeypatch, mock_upload_document_iteration_3_disabled
+):
     monkeypatch.setenv("PDS_FHIR_IS_STUBBED", "False")
     service = MNSNotificationService()
     mocker.patch.object(service, "pds_service")
@@ -69,6 +84,24 @@ def mock_document_review_references(mocker):
     return reviews
 
 
+@pytest.fixture
+def mock_upload_document_iteration_3_enabled(mocker):
+    mock_function = mocker.patch.object(FeatureFlagService, "get_feature_flags_by_flag")
+    mock_feature_flag = mock_function.return_value = {
+        FeatureFlags.UPLOAD_DOCUMENT_ITERATION_3_ENABLED: True
+    }
+    yield mock_feature_flag
+
+
+@pytest.fixture
+def mock_upload_document_iteration_3_disabled(mocker):
+    mock_function = mocker.patch.object(FeatureFlagService, "get_feature_flags_by_flag")
+    mock_feature_flag = mock_function.return_value = {
+        FeatureFlags.UPLOAD_DOCUMENT_ITERATION_3_ENABLED: False
+    }
+    yield mock_feature_flag
+
+
 MOCK_UPDATE_TIME = "2024-01-01 12:00:00"
 NEW_ODS_CODE = "NEW123"
 
@@ -249,7 +282,6 @@ def test_handle_death_notification_formal_no_documents(mns_service, mocker):
     mns_service.update_all_patient_documents.assert_not_called()
 
 
-
 def test_get_updated_gp_ods(mns_service):
     expected_ods = NEW_ODS_CODE
     patient_details_mock = MagicMock()
@@ -343,7 +375,6 @@ def test_update_all_patient_documents_with_only_review_documents(
     )
 
 
-
 def test_handle_gp_change_notification_with_only_lg_documents(
     mns_service, mock_document_references, mocker
 ):
@@ -496,3 +527,93 @@ def test_handle_death_notification_removed_with_only_review_documents(
     mns_service.update_all_patient_documents.assert_called_once_with(
         [], mock_document_review_references, NEW_ODS_CODE
     )
+
+
+def test_get_all_patient_documents_when_feature_disabled(
+    mns_service_feature_disabled, mocker
+):
+    """Test that review documents are not fetched when feature flag is disabled"""
+    expected_lg_docs = [MagicMock(spec=DocumentReference)]
+
+    mns_service_feature_disabled.lg_document_service.fetch_documents_from_table_with_nhs_number.return_value = (
+        expected_lg_docs
+    )
+
+    lg_docs, review_docs = mns_service_feature_disabled.get_all_patient_documents(
+        TEST_NHS_NUMBER
+    )
+
+    assert lg_docs == expected_lg_docs
+    assert review_docs == []
+    mns_service_feature_disabled.lg_document_service.fetch_documents_from_table_with_nhs_number.assert_called_once_with(
+        TEST_NHS_NUMBER
+    )
+    mns_service_feature_disabled.document_review_service.fetch_documents_from_table_with_nhs_number.assert_not_called()
+
+
+def test_update_all_patient_documents_when_feature_disabled(
+    mns_service_feature_disabled,
+    mock_document_references,
+    mock_document_review_references,
+    mocker,
+):
+    """Test that review documents are not updated when feature flag is disabled"""
+    mns_service_feature_disabled.update_all_patient_documents(
+        mock_document_references, mock_document_review_references, NEW_ODS_CODE
+    )
+
+    mns_service_feature_disabled.lg_document_service.update_patient_ods_code.assert_called_once_with(
+        mock_document_references, NEW_ODS_CODE
+    )
+    mns_service_feature_disabled.document_review_service.update_document_review_custodian.assert_not_called()
+
+
+def test_handle_gp_change_notification_when_feature_disabled(
+    mns_service_feature_disabled, mock_document_references, mocker
+):
+    """Test GP change notification handling when feature flag is disabled"""
+    mocker.patch.object(mns_service_feature_disabled, "get_all_patient_documents")
+    mns_service_feature_disabled.get_all_patient_documents.return_value = (
+        mock_document_references,
+        [],
+    )
+    mocker.patch.object(mns_service_feature_disabled, "get_updated_gp_ods")
+    mns_service_feature_disabled.get_updated_gp_ods.return_value = NEW_ODS_CODE
+    mocker.patch.object(mns_service_feature_disabled, "update_all_patient_documents")
+
+    mns_service_feature_disabled.handle_gp_change_notification(gp_change_message)
+
+    mns_service_feature_disabled.get_all_patient_documents.assert_called_once_with(
+        gp_change_message.subject.nhs_number
+    )
+    mns_service_feature_disabled.get_updated_gp_ods.assert_called_once_with(
+        gp_change_message.subject.nhs_number
+    )
+    mns_service_feature_disabled.update_all_patient_documents.assert_called_once_with(
+        mock_document_references, [], NEW_ODS_CODE
+    )
+
+
+def test_handle_death_notification_formal_when_feature_disabled(
+    mns_service_feature_disabled, mock_document_references, mocker
+):
+    """Test formal death notification when feature flag is disabled"""
+    mocker.patch.object(mns_service_feature_disabled, "get_all_patient_documents")
+    mocker.patch.object(mns_service_feature_disabled, "get_updated_gp_ods")
+    mocker.patch.object(mns_service_feature_disabled, "update_all_patient_documents")
+    mns_service_feature_disabled.get_all_patient_documents.return_value = (
+        mock_document_references,
+        [],
+    )
+
+    mns_service_feature_disabled.handle_death_notification(death_notification_message)
+
+    mns_service_feature_disabled.get_all_patient_documents.assert_called_once_with(
+        death_notification_message.subject.nhs_number
+    )
+    mns_service_feature_disabled.update_all_patient_documents.assert_called_once_with(
+        mock_document_references,
+        [],
+        PatientOdsInactiveStatus.DECEASED,
+    )
+    mns_service_feature_disabled.get_updated_gp_ods.assert_not_called()