Skip to content

Commit 102f82a

Browse files
separate into 3.
1 parent 7fd95af commit 102f82a

File tree

7 files changed

+65
-44
lines changed

7 files changed

+65
-44
lines changed

.github/workflows/cicd.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ jobs:
6868
image: nhsdigital/nhs-notify-devcontainer-base
6969
title: NHS Notifiy Devcontainer Base Image
7070
description: Base development container for NHS Notify projects
71+
- container_name: default
72+
image: nhsdigital/nhs-notify-devcontainer-default
73+
title: NHS Notifiy Devcontainer Default Image
74+
description: Default development container for NHS Notify projects
7175
- container_name: loaded
7276
image: nhsdigital/nhs-notify-devcontainer-loaded
7377
title: NHS Notifiy Devcontainer Loaded Image
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
{
2+
"image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-base:latest",
3+
"features": {
4+
"ghcr.io/devcontainers/features/python:1.7.1": {
5+
"version": "3.13.8",
6+
"installTools": true
7+
},
8+
"ghcr.io/devcontainers/features/aws-cli:1.1.2": {
9+
"version": "2.31.18"
10+
},
11+
"ghcr.io/devcontainers/features/common-utils:2.5.4": {
12+
"configureZshAsDefaultShell": true,
13+
"installOhMyZsh": true,
14+
"installOhMyZshConfig": true,
15+
"installZsh": true,
16+
"upgradePackages": true,
17+
"userGid": "automatic",
18+
"userUid": "automatic",
19+
"username": "automatic"
20+
},
21+
"ghcr.io/devcontainers/features/docker-in-docker:2.12.4": {
22+
"azureDnsAutoDetection": true,
23+
"dockerDashComposeVersion": "2.40.1",
24+
"installDockerBuildx": true,
25+
"installDockerComposeSwitch": true,
26+
"moby": true,
27+
"version": "28.5.1"
28+
},
29+
"ghcr.io/devcontainers/features/github-cli:1.0.15": {
30+
"installDirectlyFromGitHubRelease": true,
31+
"version": "2.82.0"
32+
},
33+
"ghcr.io/devcontainers/features/node:1.6.3": {
34+
"nodeGypDependencies": true,
35+
"nvmVersion": "0.40.3",
36+
"version": "22.21.0"
37+
},
38+
"ghcr.io/devcontainers/features/ruby:1.3.2": {
39+
"version": "3.4.7"
40+
},
41+
"ghcr.io/devcontainers/features/go:1.3.2": {
42+
"version": "1.25.3"
43+
}
44+
},
45+
"name": "NHS Notify Default Developer Container"
46+
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
nodejs 22.11.0

src/devcontainers/default/Makefile

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
IMAGE_NAME = ghcr.io/nhsdigital/nhs-notify-devcontainer-default
2+
WORKSPACE_FOLDER = .
3+
4+
build:
5+
npm install -g @devcontainers/cli && \
6+
BUILDKIT_PROGRESS=plain \
7+
devcontainer build \
8+
--push false \
9+
--workspace-folder $(WORKSPACE_FOLDER) \
10+
--image-name "$(IMAGE_NAME)" \
11+
--label "devcontainer.metadata=[{\"containerEnv\": { \"CUSTOM_VARIABLE\": \"Testing a variable\" }}]"
12+

src/devcontainers/default/README.md

Whitespace-only changes.

src/devcontainers/loaded/.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-base:latest",
2+
"image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-default:latest",
33
"features": {
44
"ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0": {
55
"updateFromTemplate": true,

src/features/nhsnotify/devcontainer-feature.json

Lines changed: 1 addition & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -3,51 +3,9 @@
33
"UPDATEFROMTEMPLATE": "true",
44
"SHOWWELCOME": "true"
55
},
6-
"dependsOn": {
7-
"ghcr.io/devcontainers/features/python:1.7.1": {
8-
"version": "3.13.8",
9-
"installTools": true
10-
},
11-
"ghcr.io/devcontainers/features/aws-cli:1.1.2": {
12-
"version": "2.31.18"
13-
},
14-
"ghcr.io/devcontainers/features/common-utils:2.5.4": {
15-
"configureZshAsDefaultShell": true,
16-
"installOhMyZsh": true,
17-
"installOhMyZshConfig": true,
18-
"installZsh": true,
19-
"upgradePackages": true,
20-
"userGid": "automatic",
21-
"userUid": "automatic",
22-
"username": "automatic"
23-
},
24-
"ghcr.io/devcontainers/features/docker-in-docker:2.12.4": {
25-
"azureDnsAutoDetection": true,
26-
"dockerDashComposeVersion": "2.40.1",
27-
"installDockerBuildx": true,
28-
"installDockerComposeSwitch": true,
29-
"moby": true,
30-
"version": "28.5.1"
31-
},
32-
"ghcr.io/devcontainers/features/github-cli:1.0.15": {
33-
"installDirectlyFromGitHubRelease": true,
34-
"version": "2.82.0"
35-
},
36-
"ghcr.io/devcontainers/features/node:1.6.3": {
37-
"nodeGypDependencies": true,
38-
"nvmVersion": "0.40.3",
39-
"version": "22.21.0"
40-
},
41-
"ghcr.io/devcontainers/features/ruby:1.3.2": {
42-
"version": "3.4.7"
43-
},
44-
"ghcr.io/devcontainers/features/go:1.3.2": {
45-
"version": "1.25.3"
46-
}
47-
},
486
"id": "nhsnotify",
497
"name": "NHS Notify",
50-
"version": "1.0.8",
8+
"version": "1.0.9",
519
"postCreateCommand": "echo 'NHS Notify FEATURE: Post Create Command'"
5210

5311
}

0 commit comments

Comments
 (0)