always build all devcontainers together. Add in conditional needs.

Author: RossBugginsNHS

.github/workflows/cicd.yaml

@@ -31,6 +31,8 @@ env:
   node_version: 24
   temp_dockerfile: /tmp/Dockerfile.source
   image_prefix: nhsdigital/nhs-notify-devcontainer-
+  workflow_path: .github/workflows/cicd.yaml
+
   # There is a single job in this workflow. It's configured to run on the latest available version of Ubuntu.
 jobs:
   deploy-nhs-notify-feature:
@@ -48,6 +50,8 @@ jobs:
           filters: |
             src:
               - '${{ env.features_dir }}/**'
+              - '${{ env.workflow_path }}'
+
       - if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
         name: "Publish Features"
         uses: devcontainers/action@v1
@@ -58,7 +62,24 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+  check-if-changed:
+      needs: deploy-nhs-notify-feature
+      if: needs.deploy-nhs-notify-feature.result == 'success' || needs.deploy-nhs-notify-feature.result == 'skipped'
+      runs-on: ubuntu-latest
+      outputs:
+        src: ${{ steps.changes.outputs.src }}
+      steps:
+      - uses: dorny/paths-filter@v3
+        id: changes
+        with:
+          filters: |
+            src:
+              - '${{env.base_dir}}/**'
+              - '${{ env.workflow_path }}'
+
   build-and-push-image:
+    if: needs.check-if-changed.outputs.src == 'true' 
+    needs: check-if-changed
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -75,8 +96,6 @@ jobs:
             title: NHS Notifiy Devcontainer Loaded Image
             description: Loaded development container for NHS Notify projects
 
-
-    # Sets the permissions granted to the `GITHUB_TOKEN` for the actions in this job.
     permissions:
       contents: read
       packages: write
@@ -86,29 +105,19 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v5
-      # Uses the `docker/login-action` action to log in to the Container registry registry using the account and password that will publish the packages. Once published, the packages are scoped to the account defined here.
 
-      - uses: dorny/paths-filter@v3
-        id: changes
-        with:
-          filters: |
-            src:
-              - '${{env.base_dir}}/${{ matrix.container_name }}/**'
-
-      - if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
-        name: Log in to the Container registry
+      - name: Log in to the Container registry
         uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
         with:
           registry: ${{ env.registry }}
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
-      - if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
-        uses: actions/setup-node@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: ${{ env.node_version }}
 
-      - if: steps.changes.outputs.src == 'true' && !startsWith(github.ref, 'refs/tags/v')
+      - if: ! startsWith(github.ref, 'refs/tags/v')
         name: Build default
         working-directory: ${{env.base_dir}}/${{ matrix.container_name }}
         run: |
@@ -124,8 +133,7 @@ jobs:
           make build BASE_IMAGE_TAG=$TAG_VERSION IMAGE_NAME=${{ env.registry }}/${{ env.image_prefix }}${{ matrix.container_name }} WORKSPACE_FOLDER=${{ env.workspace_folder }}
         
 
-      - if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
-        name: Extract metadata (tags, labels) for Docker
+      - name: Extract metadata (tags, labels) for Docker
         id: meta
         uses: docker/metadata-action@9ec57ed1fcdbf14dcef7dfbe97b2010124a938b7
         with:
@@ -147,12 +155,10 @@ jobs:
             org.opencontainers.image.url=${{ env.server }}/${{ env.org }}/${{ env.repository }}/blob/main/${{ env.base_dir }}/${{matrix.container_name}}/${{ env.readme }}
             org.opencontainers.image.source=${{ env.server }}/${{ env.org }}/${{ env.repository }}/tree/main/${{ env.base_dir }}/${{matrix.container_name}}/
 
-      - if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
-        name: create temp dockerfile source
+      - name: create temp dockerfile source
         run: echo 'FROM ${{ env.registry }}/${{ env.image_prefix }}${{ matrix.container_name }}' > ${{ env.temp_dockerfile }}
 
-      - if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
-        name: Build and push Docker image
+      - name: Build and push Docker image
         id: push
         uses: docker/build-push-action@f2a1d5e99d037542a71f64918e516c093c6f3fc4
         with:
@@ -162,8 +168,7 @@ jobs:
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
 
-      - if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
-        name: Generate artifact attestation
+      - name: Generate artifact attestation
         uses: actions/attest-build-provenance@v3
         with:
           subject-name: ${{ env.registry }}/${{ env.image_prefix }}${{ matrix.container_name }}

src/devcontainers/loaded/.devcontainer/devcontainer.json

@@ -13,7 +13,7 @@
     "postStartCommand": "echo ${localEnv:CONTAINER_NAME} Started",
 
     "features": {
-        "ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0.20": {}
+        "ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0.21": {}
     },
     "runArgs": [
         "--platform=linux/amd64"

src/features/nhsnotify/devcontainer-feature.json

@@ -7,7 +7,7 @@
     },
     "id": "nhsnotify",
     "name": "NHS Notify",
-    "version": "1.0.20",
+    "version": "1.0.21",
     "dependsOn": {
         "ghcr.io/devcontainers/features/common-utils:2.5.4": {
             "configureZshAsDefaultShell": true,