Skip to content

Commit 713d5b4

Browse files
1 parent 9168b8f commit 713d5b4

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

.github/workflows/cicd.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
- '${{ env.features_dir }}/**'
5353
- '${{ env.workflow_path }}'
5454
55-
- if: steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')
55+
- if: ${{steps.changes.outputs.src == 'true' || startsWith(github.ref, 'refs/tags/v')}}
5656
name: "Publish Features"
5757
uses: devcontainers/action@v1
5858
with:
@@ -64,7 +64,7 @@ jobs:
6464

6565
check-if-changed:
6666
needs: deploy-nhs-notify-feature
67-
if: needs.deploy-nhs-notify-feature.result == 'success' || needs.deploy-nhs-notify-feature.result == 'skipped'
67+
if: ${{!cancelled() && (needs.deploy-nhs-notify-feature.result == 'success' || needs.deploy-nhs-notify-feature.result == 'skipped')}}
6868
permissions:
6969
contents: read
7070
runs-on: ubuntu-latest
@@ -81,7 +81,7 @@ jobs:
8181
- '${{ env.workflow_path }}'
8282
8383
build-and-push-image:
84-
if: needs.check-if-changed.outputs.src == 'true'
84+
if: ${{ needs.check-if-changed.outputs.src == 'true' }}
8585
needs: check-if-changed
8686
runs-on: ubuntu-latest
8787
strategy:
@@ -120,14 +120,14 @@ jobs:
120120
with:
121121
node-version: ${{ env.node_version }}
122122

123-
- if: (!startsWith(github.ref, 'refs/tags/v'))
123+
- if: ${{(!startsWith(github.ref, 'refs/tags/v'))}}
124124
name: Build default
125125
working-directory: ${{env.base_dir}}/${{ matrix.container_name }}
126126
run: |
127127
BRANCH=${{ github.ref_name }}
128128
make build BASE_IMAGE_TAG=$BRANCH IMAGE_NAME=${{ env.registry }}/${{ env.image_prefix }}${{ matrix.container_name }} WORKSPACE_FOLDER=${{ env.workspace_folder }}
129129
130-
- if: startsWith(github.ref, 'refs/tags/v')
130+
- if: ${{startsWith(github.ref, 'refs/tags/v')}}
131131
name: Build lock base image tags to same version
132132
working-directory: ${{env.base_dir}}/${{ matrix.container_name }}
133133
run: |

src/devcontainers/loaded/README.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,14 @@
1-
# Loaded
1+
# Loaded
2+
3+
Environment variables to control post create / post start:
4+
5+
```json
6+
{
7+
"containerEnv": {
8+
"UPDATEFROMTEMPLATE": "true",
9+
"SHOWWELCOME": "true",
10+
"MAKECONFIG": "true",
11+
"GITHUBMONITOR": "true"
12+
}
13+
}
14+
```

0 commit comments

Comments
 (0)