Skip to content

Commit 78bb83a

Browse files
why no post commands.
1 parent fa8712f commit 78bb83a

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

src/devcontainers/loaded/.devcontainer/devcontainer.json

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
{
2+
"name": "NHS Notify Fully Loaded Developer Container",
23
"image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-default:latest",
34
"features": {
4-
"ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0": {
5-
"updateFromTemplate": true,
6-
"showWelcome": true
5+
"ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0.11": {
76
}
87
},
98
"runArgs": [
@@ -12,22 +11,21 @@
1211
"forwardPorts": [
1312
4000
1413
],
15-
"name": "NHS Notify Fully Loaded Developer Container",
14+
1615
"containerEnv": {
1716
"UPDATEFROMTEMPLATE": "true",
1817
"SHOWWELCOME": "true"
1918
},
2019
"initializeCommand": "touch $HOME/.gitconfig && mkdir -p $HOME/.aws || true && mkdir -p $HOME/.gnupg || true && mkdir -p $HOME/.ssh || true",
21-
"postCreateCommand": "zsh /usr/local/share/nhsnotify/scripts/postcreatecommand.sh",
22-
"postStartCommand": "zsh /usr/local/share/nhsnotify/scripts/poststartcommand.sh",
20+
2321
"mounts": [
2422
"source=/usr/local/share/ca-certificates,target=/home/ca-certificates,type=bind,consistency=cached",
2523
"source=${localEnv:HOME}/.aws,target=/home/vscode/.aws,type=bind,consistency=cached",
2624
"source=${localEnv:HOME}/.gitconfig,target=/home/vscode/.gitconfig,type=bind,consistency=cached",
2725
"source=${localEnv:HOME}/.gnupg,target=/home/vscode/.gnupg,type=bind,consistency=cached",
2826
"source=${localEnv:HOME}/.ssh,target=/home/vscode/.ssh,type=bind,consistency=cached"
2927
],
30-
"customizations": {
28+
"customizations": {
3129
"vscode": {
3230
"extensions": [
3331
"alefragnani.bookmarks",

src/features/nhsnotify/devcontainer-feature.json

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,19 @@
55
},
66
"id": "nhsnotify",
77
"name": "NHS Notify",
8-
"version": "1.0.10",
9-
"postCreateCommand": "echo 'NHS Notify FEATURE: Post Create Command'"
10-
8+
"version": "1.0.11",
9+
"dependsOn": {
10+
"ghcr.io/devcontainers/features/common-utils:2.5.4": {
11+
"configureZshAsDefaultShell": true,
12+
"installOhMyZsh": true,
13+
"installOhMyZshConfig": true,
14+
"installZsh": true,
15+
"upgradePackages": true,
16+
"userGid": "automatic",
17+
"userUid": "automatic",
18+
"username": "automatic"
19+
}
20+
},
21+
"postCreateCommand": "zsh /usr/local/share/nhsnotify/scripts/postcreatecommand.sh",
22+
"postStartCommand": "zsh /usr/local/share/nhsnotify/scripts/poststartcommand.sh"
1123
}

0 commit comments

Comments
 (0)