Skip to content

Commit e632248

Browse files
Codespaces version.
1 parent 88d13bd commit e632248

File tree

8 files changed

+16
-68
lines changed

8 files changed

+16
-68
lines changed

.github/workflows/cicd.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,12 @@ jobs:
9797
- container_name: default
9898
title: NHS Notifiy Devcontainer Default Image
9999
description: Default development container for NHS Notify projects
100+
- container_name: loaded-codespaces
101+
title: NHS Notifiy Devcontainer Loaded Image
102+
description: Loaded development container for NHS Notify projects for codespace development
100103
- container_name: loaded
101104
title: NHS Notifiy Devcontainer Loaded Image
102-
description: Loaded development container for NHS Notify projects
103-
105+
description: Loaded development container for NHS Notify projects for local development including useful local bind mounts
104106
permissions:
105107
contents: read
106108
packages: write

src/devcontainers/loaded-local/.devcontainer/Dockerfile renamed to src/devcontainers/loaded-codespaces/.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ RUN test -n ${CONTAINER_NAME}
1616
RUN test -n ${BASE_IMAGE_TAG}
1717
RUN test -n ${BASE_CONTAINER_PREFIX}
1818

19-
ENV LOADED_LOCAL_IMAGE_TAG=${BASE_IMAGE_TAG}
19+
ENV LOADED_CODESPACES_IMAGE_TAG=${BASE_IMAGE_TAG}
2020

2121
COPY scripts ${SCRIPTS_DIR}/${CONTAINER_NAME}
2222
WORKDIR ${SCRIPTS_DIR}/${CONTAINER_NAME}

src/devcontainers/loaded-local/.devcontainer/devcontainer.json renamed to src/devcontainers/loaded-codespaces/.devcontainer/devcontainer.json

Lines changed: 3 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
},
1212
"postCreateCommand": "echo ${localEnv:CONTAINER_NAME} Created",
1313
"postStartCommand": "echo ${localEnv:CONTAINER_NAME} Started",
14+
1415
"features": {
15-
"ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0.24": {}
16+
"ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0.25": {}
1617
},
1718
"runArgs": [
1819
"--platform=linux/amd64"
@@ -26,33 +27,5 @@
2627
"SHOWWELCOME": "true",
2728
"MAKECONFIG": "true",
2829
"GITHUBMONITOR": "true"
29-
},
30-
"initializeCommand": "touch $HOME/.gitconfig || true && mkdir -p $HOME/.aws || true && mkdir -p $HOME/.gnupg || true && mkdir -p $HOME/.ssh || true",
31-
"mounts": [
32-
{
33-
"source": "/usr/local/share/ca-certificates",
34-
"target": "/home/ca-certificates",
35-
"type": "bind"
36-
},
37-
{
38-
"source": "${localEnv:HOME}/.aws",
39-
"target": "/home/vscode/.aws",
40-
"type": "bind"
41-
},
42-
{
43-
"source": "${localEnv:HOME}/.gitconfig",
44-
"target": "/home/vscode/.gitconfig",
45-
"type": "bind"
46-
},
47-
{
48-
"source": "${localEnv:HOME}/.gnupg",
49-
"target": "/home/vscode/.gnupg",
50-
"type": "bind"
51-
},
52-
{
53-
"source": "${localEnv:HOME}/.ssh",
54-
"target": "/home/vscode/.ssh",
55-
"type": "bind"
56-
}
57-
],
30+
}
5831
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
#!/bin/bash
2+
3+
echo "Starting NHS Notify loaded codespaces container installation script"
4+
5+
echo "Finished NHS Notify loaded codespaces container installation script"

src/devcontainers/loaded-local/Makefile renamed to src/devcontainers/loaded-codespaces/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
CONTAINER_PREFIX=ghcr.io/nhsdigital/nhs-notify-devcontainer-
2-
CONTAINER_NAME=loaded-local
2+
CONTAINER_NAME=loaded-codespaces
33
BASE_CONTAINER_PREFIX=$(CONTAINER_PREFIX)
4-
BASE_CONTAINER_NAME=loaded
4+
BASE_CONTAINER_NAME=default
55
BASE_IMAGE_TAG=latest
66
IMAGE_NAME=${CONTAINER_PREFIX}$(CONTAINER_NAME)
77
WORKSPACE_FOLDER=.
File renamed without changes.

src/devcontainers/loaded-local/.devcontainer/scripts/install.sh

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/features/nhsnotify/devcontainer-feature.json

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
},
88
"id": "nhsnotify",
99
"name": "NHS Notify",
10-
"version": "1.0.24",
10+
"version": "1.0.25",
1111
"dependsOn": {
1212
"ghcr.io/devcontainers/features/common-utils:2.5.4": {
1313
"configureZshAsDefaultShell": true,
@@ -26,33 +26,6 @@
2626
"postStartCommand": [
2727
"/usr/local/share/nhsnotify/scripts/poststartcommand.sh"
2828
],
29-
"mounts": [
30-
{
31-
"source": "/usr/local/share/ca-certificates",
32-
"target": "/home/ca-certificates",
33-
"type": "bind"
34-
},
35-
{
36-
"source": "${localEnv:HOME}/.aws",
37-
"target": "/home/vscode/.aws",
38-
"type": "bind"
39-
},
40-
{
41-
"source": "${localEnv:HOME}/.gitconfig",
42-
"target": "/home/vscode/.gitconfig",
43-
"type": "bind"
44-
},
45-
{
46-
"source": "${localEnv:HOME}/.gnupg",
47-
"target": "/home/vscode/.gnupg",
48-
"type": "bind"
49-
},
50-
{
51-
"source": "${localEnv:HOME}/.ssh",
52-
"target": "/home/vscode/.ssh",
53-
"type": "bind"
54-
}
55-
],
5629
"customizations": {
5730
"vscode": {
5831
"extensions": [

0 commit comments

Comments
 (0)