Skip to content

Commit 53d8a3d

Browse files
CCM-12858: WIP fixes
1 parent 096d6cd commit 53d8a3d

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

lambdas/core-notifier-lambda/src/__tests__/constants.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,19 +60,20 @@ export const mockResponse: SingleMessageResponse = {
6060

6161
export const validPdmEvent: PDMResourceAvailable = {
6262
id: 'event-id-123',
63-
source: 'urn:nhs:names:services:notify:pdm',
63+
source:
64+
'/nhs/england/notify/development/dev-12345/data-plane/digitalletters/pdm',
6465
specversion: '1.0',
6566
type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
6667
time: '2025-12-15T10:00:00Z',
6768
datacontenttype: 'application/json',
6869
subject: 'message-subject-123',
69-
traceparent: '00-trace-parent',
70+
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
7071
recordedtime: '2025-12-15T10:00:00Z',
7172
severitynumber: 2,
7273
data: {
7374
senderId: 'sender-123',
7475
messageReference: 'msg-ref-123',
75-
resourceId: 'ResourceId-123',
76+
resourceId: 'f5524783-e5d7-473e-b2a0-29582ff231da',
7677
nhsNumber: '9991234566',
7778
odsCode: 'A12345',
7879
},

lambdas/core-notifier-lambda/src/app/parse-sqs-message.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ import { SQSRecord } from 'aws-lambda';
22
import { Logger } from 'utils';
33
import { PDMResourceAvailable } from 'digital-letters-events';
44
import { InvalidPdmResourceAvailableEvent } from 'domain/invalid-pdm-resource-available-event';
5-
import { messagePDMResourceAvailableValidator } from 'digital-letters-events/PDMResourceAvailable.js';
6-
7-
const eventValidator = messagePDMResourceAvailableValidator as (
8-
d: unknown,
9-
) => d is PDMResourceAvailable;
5+
import messagePDMResourceAvailableValidator from 'digital-letters-events/PDMResourceAvailable.js';
106

117
export const parseSqsRecord = (
128
sqsRecord: SQSRecord,
@@ -20,10 +16,9 @@ export const parseSqsRecord = (
2016

2117
console.log('########## DELETE');
2218
console.log(messagePDMResourceAvailableValidator);
23-
console.log(eventValidator);
2419
console.log('########## END DELETE');
2520

26-
if (!eventValidator(sqsEventDetail)) {
21+
if (!messagePDMResourceAvailableValidator(sqsEventDetail)) {
2722
logger.error({
2823
err: messagePDMResourceAvailableValidator.errors,
2924
description:

0 commit comments

Comments
 (0)