CCM-12875: remove unused header

Author: Ian-Hodges

lambdas/pdm-uploader-lambda/src/__tests__/infra/pdm-api-client.test.ts

@@ -72,7 +72,6 @@ describe('PdmClient', () => {
       const result = await pdmClient.createDocumentReference(
         mockFhirRequest,
         mockRequestId,
-        mockCorrelationId,
       );
 
       expect(mockAccessTokenRepository.getAccessToken).toHaveBeenCalled();
@@ -83,7 +82,6 @@ describe('PdmClient', () => {
           headers: {
             'Content-Type': 'application/json',
             'X-Request-ID': mockRequestId,
-            'X-Correlation-ID': mockCorrelationId,
             Authorization: 'Bearer mock-access-token',
           },
         },
@@ -97,27 +95,6 @@ describe('PdmClient', () => {
       });
     });
 
-    it('should handle request without correlation ID', async () => {
-      const mockResponse = { data: { id: 'doc-123' } };
-      conditionalRetry.mockImplementation(async (fn: any) => fn(1));
-      mockAxiosInstance.post.mockResolvedValue(mockResponse);
-
-      await pdmClient.createDocumentReference(mockFhirRequest, mockRequestId);
-
-      expect(mockAxiosInstance.post).toHaveBeenCalledWith(
-        '/patient-data-manager/FHIR/R4/DocumentReference',
-        mockFhirRequest,
-        {
-          headers: {
-            'Content-Type': 'application/json',
-            'X-Request-ID': mockRequestId,
-            'X-Correlation-ID': undefined,
-            Authorization: 'Bearer mock-access-token',
-          },
-        },
-      );
-    });
-
     it('should handle empty access token', async () => {
       mockAccessTokenRepository.getAccessToken.mockResolvedValue('');
       const mockResponse = { data: { id: 'doc-123' } };
@@ -133,7 +110,6 @@ describe('PdmClient', () => {
           headers: {
             'Content-Type': 'application/json',
             'X-Request-ID': mockRequestId,
-            'X-Correlation-ID': undefined,
           },
         },
       );
@@ -157,7 +133,6 @@ describe('PdmClient', () => {
       const result = await pdmClient.createDocumentReference(
         mockFhirRequest,
         mockRequestId,
-        mockCorrelationId,
       );
 
       expect(result).toEqual(mockResponse.data);
@@ -185,7 +160,6 @@ describe('PdmClient', () => {
         pdmClient.createDocumentReference(
           mockFhirRequest,
           mockRequestId,
-          mockCorrelationId,
         ),
       ).rejects.toThrow('Network error');
 

lambdas/pdm-uploader-lambda/src/infra/pdm-api-client.ts

@@ -1,11 +1,6 @@
 import axios, { AxiosInstance, isAxiosError } from 'axios';
 import { constants as HTTP2_CONSTANTS } from 'node:http2';
-import {
-  Logger,
-  PdmResponse,
-  RetryConfig,
-  conditionalRetry,
-} from 'utils';
+import { Logger, PdmResponse, RetryConfig, conditionalRetry } from 'utils';
 
 export interface IAccessTokenRepository {
   getAccessToken(): Promise<string>;
@@ -15,7 +10,6 @@ export interface IPdmClient {
   createDocumentReference(
     fhirRequest: string,
     requestId: string,
-    correlationId?: string,
   ): Promise<PdmResponse>;
 }
 
@@ -41,7 +35,6 @@ export class PdmClient implements IPdmClient {
   public async createDocumentReference(
     fhirRequest: string,
     requestId: string,
-    correlationId?: string,
   ): Promise<PdmResponse> {
     try {
       return await conditionalRetry(
@@ -50,15 +43,13 @@ export class PdmClient implements IPdmClient {
 
           this.logger.debug({
             requestId,
-            correlationId,
             description: 'Sending request',
             attempt,
           });
 
           const headers = {
             'Content-Type': 'application/json',
             'X-Request-ID': requestId,
-            'X-Correlation-ID': correlationId,
             ...(accessToken === ''
               ? {}
               : {
@@ -85,7 +76,6 @@ export class PdmClient implements IPdmClient {
       this.logger.error({
         description: 'Failed sending PDM request',
         requestId,
-        correlationId,
         err: error,
       });