Skip to content

Commit 5a3ed70

Browse files
committed
Merge branch 'main' into feature/CCM-12896_ts_event_type_generation
2 parents 0bb868b + a5609d7 commit 5a3ed70

File tree

54 files changed

+1927
-44
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+1927
-44
lines changed

.coverage

0 Bytes
Binary file not shown.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Clone the repository
3333
```shell
3434
git clone https://github.com/NHSDigital/nhs-notify-digital-letters.git
3535
cd nhs-notify-digital-letters
36-
code protject.code-workspace
36+
code project.code-workspace
3737
```
3838

3939
Reopen with container

docs/architecture/c4/notifhir/reporting/recorder/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ is_not_draft: false
88
last_modified_date: 2025-10-24
99
owner: Tom D'Roza
1010
author: Tom D'Roza
11-
diagrams: [c4code-tracker-listener, c4component-nhsapp-callback, sequence-nhsapp-callback]
11+
diagrams: [c4code-mesh-statusreporter-recorder, sequence-nhsapp-callback]
1212
events-raised: []
1313
events-consumed: [
1414
mesh-inbox-message-downloaded,

docs/architecture/c4/notifhir/reporting/reportgenerator/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ is_not_draft: false
88
last_modified_date: 2025-10-28
99
owner: Ross Buggins
1010
author: Tom D'Roza
11-
diagrams: [c c4code-mesh-statusreporter-generator]
12-
events-raised: [reporting-daily-report-generated]
13-
events-consumed: [reporting-daily-report-timer-expired]
11+
diagrams: [c4code-mesh-statusreporter-generator]
12+
events-raised: [reporting-report-generated]
13+
events-consumed: [reporting-generate-report]
1414
c4type: code
1515
---

docs/architecture/c4/notifhir/reporting/reportscheduler/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ last_modified_date: 2025-10-28
99
owner: Ross Buggins
1010
author: Tom D'Roza
1111
diagrams: [c4code-mesh-statusreporter-scheduler]
12-
events-raised: [reporting-daily-report-timer-expired]
12+
events-raised: [reporting-generate-report]
1313
events-consumed: []
1414
c4type: code
1515
---
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
---
2+
3+
title: Report Sender
4+
parent: Reporting
5+
nav_order: 4
6+
has_children: true
7+
is_not_draft: false
8+
last_modified_date: 2025-11-26
9+
owner: Ross Buggins
10+
author: Tom D'Roza
11+
diagrams: [c4code-mesh-statusreporter-sender]
12+
events-raised: [reporting-report-sent]
13+
events-consumed: [reporting-report-generated]
14+
c4type: code
15+
---

docs/assets/aws-icons-mermaid.json

Lines changed: 5 additions & 5 deletions
Large diffs are not rendered by default.

docs/collections/_diagrams/c4code-mesh-statusreporter-generator.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ title: c4code-mesh-statusreporter-generator
66

77
## Decisions
88

9-
1. ReportScheulder lambda publishes a `GenerateReport` event for each trust that has new report data in the previous 24 hours.
10-
2. The event metadata contains the trust ID so the ReportGenerator lambda knows which trust to generate a report for.
9+
1. ReportSchedulder lambda publishes a `GenerateReport` event for every known client
10+
2. The event data payload contains the `senderId` so the ReportGenerator lambda knows which trust to generate a report for.
1111

1212
```mermaid
1313
architecture-beta
@@ -16,7 +16,7 @@ architecture-beta
1616
service sqs(logos:aws-sqs)[ReportGenerator Queue] in reportGenerator
1717
service reportGeneratorLambda(logos:aws-lambda)[Report Generator] in reportGenerator
1818
service s3(logos:aws-s3)[Reports] in reportGenerator
19-
service reportsdb(aws:arch-amazon-dynamodb)[Reports] in reportGenerator
19+
service reportsdb(aws:arch-amazon-athena)[Reports] in reportGenerator
2020
service reportGeneratedEvent(aws:res-amazon-eventbridge-event)[ReportGenerated Event]
2121
2222
generateReportEvent:R --> L:sqs

docs/collections/_diagrams/c4code-tracker-listener.md renamed to docs/collections/_diagrams/c4code-mesh-statusreporter-recorder.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22

3-
title: c4code-tracker-listener
3+
title: c4code-mesh-statusreporter-recorder
44

55
---
66

@@ -12,7 +12,7 @@ architecture-beta
1212
service report3Event(aws:res-amazon-eventbridge-event)[NHSAppMessageRequested Event]
1313
service sqs(logos:aws-sqs)[StatusRecorder Queue] in statusRecorder
1414
service reportGeneratorLambda(logos:aws-lambda)[StatusRecorder] in statusRecorder
15-
service ddb(aws:arch-amazon-dynamodb)[Reports] in statusRecorder
15+
service ddb(aws:arch-amazon-athena)[Reports] in statusRecorder
1616
junction j1
1717
junction j2
1818

infrastructure/terraform/bin/terraform.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,6 @@ readonly backend_config="terraform {
599599
region = \"${region}\"
600600
bucket = \"${bucket}\"
601601
key = \"${backend_key}\"
602-
dynamodb_table = \"${bucket}\"
603602
use_lockfile = true
604603
}
605604
}";

0 commit comments

Comments
 (0)