CCM-12875: Added more tests and updated jest config

Author: ScottFullerton-NHSE

lambdas/pdm-mock-api/jest.config.ts

@@ -1,47 +1,24 @@
-import type { Config } from 'jest';
+import { baseJestConfig } from '../../jest.config.base';
 
-const config: Config = {
-  preset: 'ts-jest',
-  testEnvironment: 'node',
+const config = baseJestConfig;
 
-  roots: ['<rootDir>/src'],
+config.coveragePathIgnorePatterns = ['/__tests__/'];
 
-  testMatch: ['**/__tests__/**/*.test.ts'],
-
-  collectCoverageFrom: [
-    'src/**/*.ts',
-    '!src/**/__tests__/**',
-    '!src/**/*.test.ts',
-  ],
-
-  reporters: [
-    'default',
-    [
-      'jest-html-reporter',
-      {
-        pageTitle: 'Test Report',
-        outputPath: './.reports/unit/test-report.html',
-        includeFailureMsg: true,
-      },
-    ],
-  ],
-
-  coverageThreshold: {
-    global: {
-      branches: 80,
-      functions: 80,
-      lines: 80,
-      statements: 80,
-    },
+config.coverageThreshold = {
+  global: {
+    branches: 100,
+    functions: 100,
+    lines: 90,
+    statements: -10,
   },
+};
 
-  moduleNameMapper: {
-    '^utils$': '<rootDir>/../../utils/utils',
-    '^handlers$': '<rootDir>/src/handlers',
-    '^container$': '<rootDir>/src/container',
-    '^config$': '<rootDir>/src/config',
-    '^authenticator$': '<rootDir>/src/authenticator',
-  },
+config.moduleNameMapper = {
+  '^utils$': '<rootDir>/../../utils/utils',
+  '^handlers$': '<rootDir>/src/handlers',
+  '^container$': '<rootDir>/src/container',
+  '^config$': '<rootDir>/src/config',
+  '^authenticator$': '<rootDir>/src/authenticator',
 };
 
 export default config;

lambdas/pdm-mock-api/src/__tests__/config.test.ts

@@ -1,4 +1,4 @@
-import { ParameterStoreService, loadConfig } from 'config';
+import { ParameterStoreService, getEnv, loadConfig } from 'config';
 
 describe('Config', () => {
   const originalEnv = process.env;
@@ -12,6 +12,31 @@ describe('Config', () => {
     process.env = originalEnv;
   });
 
+  describe('getEnv', () => {
+    it('should throw error when required env var is not set and no default provided', () => {
+      delete process.env.SOME_REQUIRED_VAR;
+
+      expect(() => getEnv('SOME_REQUIRED_VAR')).toThrow(
+        'Environment variable SOME_REQUIRED_VAR is required but not set',
+      );
+    });
+
+    it('should return environment variable value when set', () => {
+      process.env.TEST_VAR = 'test-value';
+      expect(getEnv('TEST_VAR')).toBe('test-value');
+    });
+
+    it('should return default value when env var not set', () => {
+      delete process.env.TEST_VAR;
+      expect(getEnv('TEST_VAR', 'default-value')).toBe('default-value');
+    });
+
+    it('should return env var value over default when both present', () => {
+      process.env.TEST_VAR = 'actual-value';
+      expect(getEnv('TEST_VAR', 'default-value')).toBe('actual-value');
+    });
+  });
+
   describe('loadConfig', () => {
     it('should load config with default values', () => {
       delete process.env.MOCK_ACCESS_TOKEN;
@@ -53,9 +78,17 @@ describe('Config', () => {
       process.env.USE_NON_MOCK_TOKEN = 'FALSE';
       config = loadConfig();
       expect(config.useNonMockToken).toBe(false);
+
+      process.env.USE_NON_MOCK_TOKEN = 'yes';
+      config = loadConfig();
+      expect(config.useNonMockToken).toBe(false);
+
+      process.env.USE_NON_MOCK_TOKEN = '';
+      config = loadConfig();
+      expect(config.useNonMockToken).toBe(false);
     });
 
-    it('should throw error for missing required env var without default', () => {
+    it('should not throw when all required env vars have default values', () => {
       const config = loadConfig();
       expect(config).toBeDefined();
     });

lambdas/pdm-mock-api/src/__tests__/container.test.ts

@@ -1,3 +1,4 @@
+import { SSMClient } from '@aws-sdk/client-ssm';
 import { createContainer } from 'container';
 
 jest.mock('utils', () => ({
@@ -10,6 +11,8 @@ jest.mock('utils', () => ({
   },
 }));
 
+jest.mock('@aws-sdk/client-ssm');
+
 describe('Container', () => {
   let container: ReturnType<typeof createContainer>;
 
@@ -71,4 +74,39 @@ describe('Container', () => {
     expect(result).toBeDefined();
     expect(result.isValid).toBeDefined();
   });
+
+  it('should handle USE_NON_MOCK_TOKEN configuration', () => {
+    process.env.USE_NON_MOCK_TOKEN = 'true';
+    const containerWithSSM = createContainer();
+
+    expect(containerWithSSM).toBeDefined();
+    expect(containerWithSSM.authenticator).toBeDefined();
+    expect(typeof containerWithSSM.authenticator).toBe('function');
+  });
+
+  it('should wire getAccessToken to authenticator when using SSM token', async () => {
+    const mockSend = jest.fn().mockResolvedValue({
+      Parameter: { Value: 'ssm-stored-token' },
+    });
+
+    process.env.USE_NON_MOCK_TOKEN = 'true';
+    process.env.ACCESS_TOKEN_SSM_PATH = '/test/token/path';
+    process.env.MOCK_ACCESS_TOKEN = 'unused-mock-token';
+
+    (SSMClient as jest.MockedClass<typeof SSMClient>).mockImplementation(
+      () =>
+        ({
+          send: mockSend,
+        }) as any,
+    );
+
+    const testContainer = createContainer();
+
+    const result = await testContainer.authenticator({
+      headers: { Authorization: 'Bearer ssm-stored-token' },
+    });
+
+    expect(result.isValid).toBe(true);
+    expect(mockSend).toHaveBeenCalled();
+  });
 });

lambdas/pdm-mock-api/src/config.ts

@@ -7,7 +7,7 @@ export interface Config {
   logLevel: string;
 }
 
-const getEnv = (key: string, defaultValue?: string): string => {
+export const getEnv = (key: string, defaultValue?: string): string => {
   // eslint-disable-next-line security/detect-object-injection
   const value = process.env[key];
   if (value === undefined && defaultValue === undefined) {

scripts/config/sonar-scanner.properties

@@ -11,5 +11,5 @@ sonar.cpd.exclusions=**.test.*
 sonar.coverage.exclusions=tests/**, src/**/tests/**, src/**/__tests__/**, **/*.dev.*, lambdas/**/src/__tests__/**, **/jest.config.ts, **/jest.config.cjs, scripts/**/*.*, docs/**/*.*, utils/utils/src/__tests__/**, src/asyncapigenerator/example_usage.py, src/asyncapigenerator/test_generator.py, src/eventcatalogasyncapiimporter/examples.py
 
 sonar.python.coverage.reportPaths=src/asyncapigenerator/coverage.xml,src/cloudeventjekylldocs/coverage.xml,src/eventcatalogasyncapiimporter/coverage.xml
-sonar.javascript.lcov.reportPaths=lcov.info,src/cloudevents/coverage/lcov.info,coverage/lcov.info
+sonar.javascript.lcov.reportPaths=lcov.info,src/cloudevents/coverage/lcov.info
 sonar.typescript.lcov.reportPaths=lcov.info,src/cloudevents/coverage/lcov.info