CCM-13135: fix build failures

Author: nhsd-angel-pastor

utils/client-management/package.json

@@ -13,7 +13,7 @@
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^29.7.0",
     "jest-mock-extended": "^3.0.7",
-    "typescript": "^5.8.2"
+    "typescript": "^5.9.3"
   },
   "main": "src/index.ts",
   "name": "client-management",

utils/client-management/src/__test__/app/delete-client.test.ts

@@ -1,45 +1,22 @@
 import { mockDeep } from 'jest-mock-extended';
-import { ClientMetadata } from 'utils';
 import { AppDependencies, createApp } from '../../app';
 import { DeleteClientCommandParameters } from '../../app/delete-client';
 
 function setup() {
-  const clientId = 'input_id';
-
-  const metadata: ClientMetadata[] = [
-    {
-      clientId,
-      provider: 'govuknotify',
-      scope: 'client-metadata',
-      type: 'api_key',
-      value: 'test_secret',
-    },
-    {
-      clientId,
-      provider: 'govuknotify',
-      scope: 'client-metadata',
-      type: 'polling_index',
-      value: 'notifyid',
-    },
-  ];
-
   const mocks = mockDeep<AppDependencies>({
     infra: {
       clientRepository: {
         deleteClient: jest.fn(),
       },
-      metadataRepository: {
-        listMetadata: jest.fn().mockResolvedValueOnce(metadata),
-      },
     },
   });
 
-  return { mocks, data: { metadata } };
+  return mocks;
 }
 
 describe('deleteClient', () => {
   it('deletes the client from the client repository by id', async () => {
-    const { mocks } = setup();
+    const mocks = setup();
 
     const app = createApp(mocks);
 
@@ -53,7 +30,7 @@ describe('deleteClient', () => {
   });
 
   it('optionally also deletes associated client metadata', async () => {
-    const { data, mocks } = setup();
+    const mocks = setup();
 
     const app = createApp(mocks);
 
@@ -67,21 +44,5 @@ describe('deleteClient', () => {
     expect(mocks.infra.clientRepository.deleteClient).toHaveBeenCalledWith(
       input.clientId,
     );
-
-    expect(mocks.infra.metadataRepository.listMetadata).toHaveBeenCalledWith(
-      input.clientId,
-    );
-
-    expect(mocks.infra.metadataRepository.deleteMetadata).toHaveBeenCalledTimes(
-      2,
-    );
-
-    expect(mocks.infra.metadataRepository.deleteMetadata).toHaveBeenCalledWith(
-      data.metadata[0],
-    );
-
-    expect(mocks.infra.metadataRepository.deleteMetadata).toHaveBeenCalledWith(
-      data.metadata[1],
-    );
   });
 });

utils/client-management/src/app/delete-client.ts

@@ -9,18 +9,6 @@ export function createDeleteClientCommand({ infra }: AppDependencies) {
   return async function deleteClientCommand(
     params: DeleteClientCommandParameters,
   ): Promise<void> {
-    if (params.deleteMetadata) {
-      const metadataItems = await infra.metadataRepository.listMetadata(
-        params.clientId,
-      );
-
-      await Promise.all(
-        metadataItems.map(async (item) =>
-          infra.metadataRepository.deleteMetadata(item),
-        ),
-      );
-    }
-
     await infra.clientRepository.deleteClient(params.clientId);
   };
 }

utils/client-management/src/app/index.ts

@@ -14,3 +14,4 @@ export function createApp(dependencies: AppDependencies) {
 }
 
 export type App = ReturnType<typeof createApp>;
+export * from './types';

utils/client-management/src/infra/client-repository/repository.ts

@@ -7,7 +7,7 @@ import { IClientRepository } from '../interfaces';
 export type Dependencies = {
   config: Config;
   parameterStore: IParameterStore;
-  logger?: Logger;
+  logger: Logger;
 };
 
 export class ClientRepository implements IClientRepository {

utils/client-management/src/infra/index.ts

@@ -13,12 +13,8 @@ export type Infrastructure = {
   clientRepository: IClientRepository;
 };
 
-export function createInfra({
-  config,
-  logger: _logger,
-  parameterStore,
-}: Dependencies): Infrastructure {
-  const clientRepository = new ClientRepository({ config, parameterStore });
+export function createInfra(dependencies: Dependencies): Infrastructure {
+  const clientRepository = new ClientRepository(dependencies);
 
   return {
     clientRepository,