Skip to content

Commit af64e7a

Browse files
lapenna-bjsslapenna-bjss
authored
CCM-12397: resolve sonar issues (#51)
1 parent bada5cb commit af64e7a

File tree

4 files changed

+90
-122
lines changed

4 files changed

+90
-122
lines changed

‎docs/_sass/color_schemes/ce.scss‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,10 @@ section > h2 {
3232
.site-fork-warning {
3333
width: 100%;
3434
padding-left: 30px;
35+
display: none;
3536
@include mq(lg) {
3637
width: $nav-width;
3738
}
38-
}
39-
40-
.site-fork-warning {
41-
display: none;
4239
@include mq(md) {
4340
display: block;
4441
}
@@ -78,8 +75,6 @@ $base-button-color: $grey-nhs-pale-grey;
7875
$nav-child-link-color: $grey-nhs-mid-grey;
7976
$body-heading-color: $blue-nhs-dark-blue;
8077

81-
//$body-font-family: Frutiger, Arial;
82-
8378

8479
.text-nhs-mid-grey {
8580
color: $grey-nhs-mid-grey !important;
@@ -92,7 +87,6 @@ code svg{
9287
svg[id^="mermaid-"]
9388
{
9489
min-width: 100%;
95-
//min-height: 700px;
9690
}
9791
.reveal .slide-menu-button
9892
{

‎docs/_sass/swagger-ui.scss‎

Lines changed: 20 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
overflow: visible;
4444
}
4545
.swagger-ui pre {
46-
font-family: monospace, monospace;
46+
font-family: monospace;
4747
font-size: 1em;
4848
}
4949
.swagger-ui a {
@@ -52,7 +52,6 @@
5252
}
5353
.swagger-ui abbr[title] {
5454
border-bottom: none;
55-
text-decoration: underline;
5655
-webkit-text-decoration: underline dotted;
5756
text-decoration: underline dotted;
5857
}
@@ -64,7 +63,7 @@
6463
.swagger-ui code,
6564
.swagger-ui kbd,
6665
.swagger-ui samp {
67-
font-family: monospace, monospace;
66+
font-family: monospace;
6867
font-size: 1em;
6968
}
7069
.swagger-ui dfn {
@@ -100,6 +99,7 @@
10099
}
101100
.swagger-ui img {
102101
border-style: none;
102+
max-width: 100%;
103103
}
104104
.swagger-ui svg:not(:root) {
105105
overflow: hidden;
@@ -108,12 +108,6 @@
108108
.swagger-ui input,
109109
.swagger-ui optgroup,
110110
.swagger-ui select,
111-
.swagger-ui textarea {
112-
font-family: sans-serif;
113-
font-size: 100%;
114-
line-height: 1.15;
115-
margin: 0;
116-
}
117111
.swagger-ui button,
118112
.swagger-ui input {
119113
overflow: visible;
@@ -156,9 +150,6 @@
156150
display: inline-block;
157151
vertical-align: baseline;
158152
}
159-
.swagger-ui textarea {
160-
overflow: auto;
161-
}
162153
.swagger-ui [type="checkbox"],
163154
.swagger-ui [type="radio"] {
164155
box-sizing: border-box;
@@ -458,9 +449,6 @@
458449
z-index: 100;
459450
}
460451
}
461-
.swagger-ui img {
462-
max-width: 100%;
463-
}
464452
.swagger-ui .cover {
465453
background-size: cover !important;
466454
}
@@ -1308,9 +1296,10 @@
13081296
}
13091297
}
13101298
.swagger-ui .pre {
1299+
overflow: scroll;
13111300
overflow-x: auto;
13121301
overflow-y: hidden;
1313-
overflow: scroll;
1302+
white-space: pre;
13141303
}
13151304
.swagger-ui .top-0 {
13161305
top: 0;
@@ -6857,9 +6846,6 @@
68576846
.swagger-ui .nowrap {
68586847
white-space: nowrap;
68596848
}
6860-
.swagger-ui .pre {
6861-
white-space: pre;
6862-
}
68636849
@media screen and (min-width: 30em) {
68646850
.swagger-ui .ws-normal-ns {
68656851
white-space: normal;
@@ -7143,16 +7129,14 @@
71437129
display: flex;
71447130
padding: 10px 20px 10px 10px;
71457131
transition: all 0.2s;
7146-
}
7147-
.swagger-ui .opblock-tag:hover {
7148-
background: rgba(0, 0, 0, 0.02);
7149-
}
7150-
.swagger-ui .opblock-tag {
71517132
color: #3b4151;
71527133
font-family: sans-serif;
71537134
font-size: 24px;
71547135
margin: 0 0 5px;
71557136
}
7137+
.swagger-ui .opblock-tag:hover {
7138+
background: rgba(0, 0, 0, 0.02);
7139+
}
71567140
.swagger-ui .opblock-tag.no-desc span {
71577141
flex: 1;
71587142
}
@@ -7610,6 +7594,7 @@
76107594
font-size: 14px;
76117595
max-width: 40em;
76127596
padding-left: 2em;
7597+
min-width: 6em;
76137598
}
76147599
.swagger-ui .response-col_links .response-undocumented {
76157600
color: #909090;
@@ -8061,12 +8046,21 @@
80618046
.swagger-ui input[type="search"],
80628047
.swagger-ui input[type="text"],
80638048
.swagger-ui textarea {
8049+
overflow: auto;
8050+
font-family: monospace;
8051+
font-size: 12px;
8052+
font-weight: 600;
8053+
line-height: 1.15;
80648054
background: #fff;
80658055
border: 1px solid #d9d9d9;
80668056
border-radius: 4px;
8067-
margin: 5px 0;
8057+
color: #3b4151;
8058+
min-height: 280px;
80688059
min-width: 100px;
8060+
outline: none;
80698061
padding: 8px 10px;
8062+
width: 100%;
8063+
margin: 5px 0;
80708064
}
80718065
.swagger-ui input[type="email"].invalid,
80728066
.swagger-ui input[type="file"].invalid,
@@ -8131,19 +8125,6 @@
81318125
transform: translate3d(4px, 0, 0);
81328126
}
81338127
}
8134-
.swagger-ui textarea {
8135-
background: hsla(0, 0%, 100%, 0.8);
8136-
border: none;
8137-
border-radius: 4px;
8138-
color: #3b4151;
8139-
font-family: monospace;
8140-
font-size: 12px;
8141-
font-weight: 600;
8142-
min-height: 280px;
8143-
outline: none;
8144-
padding: 10px;
8145-
width: 100%;
8146-
}
81478128
.swagger-ui textarea:focus {
81488129
border: 2px solid #61affe;
81498130
}
@@ -8318,9 +8299,6 @@
83188299
position: absolute;
83198300
top: -0.4em;
83208301
}
8321-
.swagger-ui .model-title {
8322-
position: relative;
8323-
}
83248302
.swagger-ui .model-title:hover .model-hint {
83258303
visibility: visible;
83268304
}
@@ -8454,6 +8432,7 @@
84548432
color: #505050;
84558433
font-family: sans-serif;
84568434
font-size: 16px;
8435+
position: relative;
84578436
}
84588437
.swagger-ui .model-title img {
84598438
bottom: 0;
@@ -8637,9 +8616,6 @@
86378616
.swagger-ui .response-col_description {
86388617
width: 99%;
86398618
}
8640-
.swagger-ui .response-col_links {
8641-
min-width: 6em;
8642-
}
86438619
.swagger-ui .response__extension {
86448620
color: gray;
86458621
font-family: monospace;

‎docs/assets/js/nhs-notify.js‎

Lines changed: 23 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
// Quick poc for view full screen
22

33
window.addEventListener("load", (event) => {
4-
var fullScreenParamName = "fullscreen";
5-
var urlParams = new URLSearchParams(document.location.search);
6-
var param = urlParams.get(fullScreenParamName);
4+
let fullScreenParamName = "fullscreen";
5+
let urlParams = new URLSearchParams(document.location.search);
6+
let param = urlParams.get(fullScreenParamName);
77
if (param) {
88
tempViewFullScreen();
99
} else {
@@ -14,7 +14,7 @@ window.addEventListener("load", (event) => {
1414
let nhsNotify = nhsNotifyDefaults();
1515

1616
function nhsNotifyDefaults() {
17-
var defaults = {};
17+
let defaults = {};
1818
defaults.storageName = "cb-checked";
1919
defaults.buttonName = "fullScreenButton";
2020
defaults.standard = "Standard";
@@ -24,16 +24,16 @@ function nhsNotifyDefaults() {
2424

2525
function tempViewFullScreen() {
2626
viewFullScreen();
27-
var buttons = document.getElementsByName(nhsNotify.buttonName);
27+
let buttons = document.getElementsByName(nhsNotify.buttonName);
2828
buttons.forEach((item) => {
2929
item.style.display = "none";
3030
});
3131
}
3232

3333
function viewFullScreen() {
34-
var sideBar = document.getElementsByClassName("side-bar")[0];
35-
var main = document.getElementsByClassName("main")[0];
36-
var pageInfo = document.getElementsByClassName("page-info")[0];
34+
let sideBar = document.getElementsByClassName("side-bar")[0];
35+
let main = document.getElementsByClassName("main")[0];
36+
let pageInfo = document.getElementsByClassName("page-info")[0];
3737
sideBar.style.display = "none";
3838
main.style.maxWidth = "100%";
3939
main.style.marginLeft = "0px";
@@ -45,9 +45,9 @@ function setFullScreen() {
4545
}
4646

4747
function setStandard() {
48-
var sideBar = document.getElementsByClassName("side-bar")[0];
49-
var main = document.getElementsByClassName("main")[0];
50-
var pageInfo = document.getElementsByClassName("page-info")[0];
48+
let sideBar = document.getElementsByClassName("side-bar")[0];
49+
let main = document.getElementsByClassName("main")[0];
50+
let pageInfo = document.getElementsByClassName("page-info")[0];
5151
sideBar.style.display = "";
5252
main.style.maxWidth = "";
5353
main.style.marginLeft = "";
@@ -56,7 +56,7 @@ function setStandard() {
5656
}
5757

5858
function setViewAtStart() {
59-
var currentStatus = localStorage.getItem(nhsNotify.storageName);
59+
let currentStatus = localStorage.getItem(nhsNotify.storageName);
6060
if (currentStatus == nhsNotify.fullScreen) makeChange(currentStatus);
6161
}
6262

@@ -69,9 +69,9 @@ function makeChange(newStatus) {
6969
}
7070

7171
function afterChange(currentStatus, newStatus) {
72-
var storageName = nhsNotify.storageName;
73-
var buttonName = nhsNotify.buttonName;
74-
var buttons = document.getElementsByName(buttonName);
72+
let storageName = nhsNotify.storageName;
73+
let buttonName = nhsNotify.buttonName;
74+
let buttons = document.getElementsByName(buttonName);
7575
localStorage.setItem(storageName, newStatus);
7676

7777
buttons.forEach((item) => {
@@ -80,29 +80,24 @@ function afterChange(currentStatus, newStatus) {
8080
}
8181

8282
function fullScreenToggle() {
83-
var standard = nhsNotify.standard;
84-
var fullScreen = nhsNotify.fullScreen;
85-
var storageName = nhsNotify.storageName;
86-
var currentStatus = "";
87-
var newStatus = "";
83+
let standard = nhsNotify.standard;
84+
let fullScreen = nhsNotify.fullScreen;
85+
let storageName = nhsNotify.storageName;
86+
let currentStatus;
87+
let newStatus;
8888

8989
currentStatus = localStorage.getItem(storageName);
9090

9191
if (
9292
currentStatus == "false" ||
9393
currentStatus == "undefined" ||
94-
currentStatus == null
94+
currentStatus == null ||
95+
currentStatus == standard
9596
) {
96-
currentStatus = standard;
9797
newStatus = fullScreen;
9898
}
99-
100-
if (currentStatus == standard) {
101-
newStatus = fullScreen;
102-
currentStatus = standard;
103-
} else {
99+
else {
104100
newStatus = standard;
105-
currentStatus = fullScreen;
106101
}
107102

108103
makeChange(newStatus);

0 commit comments

Comments
 (0)