CCM-13135: sonar fixes

Author: nhsd-angel-pastor

scripts/config/sonar-scanner.properties

@@ -4,8 +4,8 @@ sonar.host.url=https://sonarcloud.io
 sonar.qualitygate.wait=true
 sonar.sourceEncoding=UTF-8
 sonar.sources=.
-sonar.tests=tests/, src/asyncapigenerator/tests, src/cloudeventjekylldocs/tests, src/eventcatalogasyncapiimporter/tests, src/cloudevents/tools/builder/__tests__, src/cloudevents/tools/cache/__tests__, src/cloudevents/tools/generator/__tests__, lambdas/mesh-poll/src/__tests__, lambdas/ttl-create-lambda/src/__tests__, lambdas/ttl-poll-lambda/src/__tests__, utils/utils/src/__tests__
-sonar.test.inclusions=tests/**, src/**/tests/**, src/**/__tests__/**, lambdas/**/src/__tests__/**, utils/utils/src/__tests__/**
+sonar.tests=tests/, src/asyncapigenerator/tests, src/cloudeventjekylldocs/tests, src/eventcatalogasyncapiimporter/tests, src/cloudevents/tools/builder/__tests__, src/cloudevents/tools/cache/__tests__, src/cloudevents/tools/generator/__tests__, lambdas/mesh-poll/src/__tests__, lambdas/ttl-create-lambda/src/__tests__, lambdas/ttl-poll-lambda/src/__tests__, utils/utils/src/__tests__, utils/client-management/src/__tests__
+sonar.test.inclusions=tests/**, src/**/tests/**, src/**/__tests__/**, lambdas/**/src/__tests__/**, utils/utils/src/__tests__/**, utils/client-management/src/__tests__/**
 sonar.terraform.provider.aws.version=5.54.1
 sonar.cpd.exclusions=**.test.*
 sonar.coverage.exclusions=tests/**, src/**/tests/**, src/**/__tests__/**, **/*.dev.*, lambdas/**/src/__tests__/**, **/jest.config.ts, **/jest.config.cjs, scripts/**/*.*, docs/**/*.*, utils/utils/src/__tests__/**, src/asyncapigenerator/example_usage.py, src/asyncapigenerator/test_generator.py, src/eventcatalogasyncapiimporter/examples.py

utils/client-management/jest.config.ts

@@ -1,21 +1,15 @@
 import { baseJestConfig } from '../../jest.config.base';
 
-const utilsJestConfig = {
-  ...baseJestConfig,
-
-  coverageThreshold: {
-    global: {
-      branches: 85,
-      functions: 85,
-      lines: 85,
-      statements: -10,
-    },
+const config = baseJestConfig;
+
+config.coveragePathIgnorePatterns = ['/__tests__/', 'cli.ts', 'index.ts'];
+config.coverageThreshold = {
+  global: {
+    branches: 85,
+    functions: 100,
+    lines: 90,
+    statements: -10,
   },
-
-  coveragePathIgnorePatterns: [
-    ...(baseJestConfig.coveragePathIgnorePatterns ?? []),
-    'index.ts',
-  ],
 };
 
-export default utilsJestConfig;
+export default config;

utils/client-management/src/__test__/container.test.ts

@@ -63,12 +63,3 @@ describe('createClientManager', () => {
     expect(result).toBe(mockApp);
   });
 });
-
-// import {createClientManager} from 'container';
-
-// jest.mock('utils', () => ({
-//   logger: {},
-//   defaultConfigReader: {
-//     getValue: jest.fn(),
-//   },
-// }));

utils/client-management/src/infra/client-repository/repository.ts

@@ -10,11 +10,11 @@ export type Dependencies = {
 };
 
 export class ClientRepository implements IClientRepository {
-  private config: Config;
+  private readonly config: Config;
 
-  private parameterStore: IParameterStore;
+  private readonly parameterStore: IParameterStore;
 
-  private logger: Logger;
+  private readonly logger: Logger;
 
   constructor({ config, logger, parameterStore }: Dependencies) {
     this.config = config;