CCM-12858: fixes for terraform

Author: nhsd-angel-pastor

infrastructure/terraform/components/dl/README.md

@@ -36,11 +36,11 @@ No requirements.
 
 | Name | Source | Version |
 |------|--------|---------|
+| <a name="module_core_notifier"></a> [core\_notifier](#module\_core\_notifier) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
 | <a name="module_kms"></a> [kms](#module\_kms) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-kms.zip | n/a |
 | <a name="module_lambda_apim_key_generation"></a> [lambda\_apim\_key\_generation](#module\_lambda\_apim\_key\_generation) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
 | <a name="module_lambda_lambda_apim_refresh_token"></a> [lambda\_lambda\_apim\_refresh\_token](#module\_lambda\_lambda\_apim\_refresh\_token) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
 | <a name="module_mesh_poll"></a> [mesh\_poll](#module\_mesh\_poll) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
-| <a name="module_pdm_uploader"></a> [pdm\_uploader](#module\_pdm\_uploader) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
 | <a name="module_s3bucket_cf_logs"></a> [s3bucket\_cf\_logs](#module\_s3bucket\_cf\_logs) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-s3bucket.zip | n/a |
 | <a name="module_s3bucket_letters"></a> [s3bucket\_letters](#module\_s3bucket\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-s3bucket.zip | n/a |
 | <a name="module_s3bucket_static_assets"></a> [s3bucket\_static\_assets](#module\_s3bucket\_static\_assets) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-s3bucket.zip | n/a |

infrastructure/terraform/components/dl/module_lambda_core_notifier.tf

@@ -1,8 +1,8 @@
-module "pdm_uploader" {
+module "core_notifier" {
   source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip"
 
   function_name = "core-notifier"
-  description   = "A function to upload documents to PDM"
+  description   = "A function to send messages to core Notify when a PDM resource is available"
 
   aws_account_id = var.aws_account_id
   component      = local.component
@@ -15,7 +15,7 @@ module "pdm_uploader" {
   kms_key_arn           = module.kms.key_arn
 
   iam_policy_document = {
-    body = data.aws_iam_policy_document.pdm_uploader_lambda.json
+    body = data.aws_iam_policy_document.core_notifier_lambda.json
   }
 
   function_s3_bucket      = local.acct.s3_buckets["lambda_function_artefacts"]["id"]
@@ -43,7 +43,7 @@ module "pdm_uploader" {
   }
 }
 
-data "aws_iam_policy_document" "pdm_uploader_lambda" {
+data "aws_iam_policy_document" "core_notifier_lambda" {
   statement {
     sid    = "AllowSSMParam"
     effect = "Allow"
@@ -59,19 +59,6 @@ data "aws_iam_policy_document" "pdm_uploader_lambda" {
     ]
   }
 
-  statement {
-    sid    = "AllowS3Get"
-    effect = "Allow"
-
-    actions = [
-      "s3:GetObject"
-    ]
-
-    resources = [
-      "${module.s3bucket_letters.arn}/*"
-    ]
-  }
-
   statement {
     sid    = "KMSPermissions"
     effect = "Allow"
@@ -87,7 +74,7 @@ data "aws_iam_policy_document" "pdm_uploader_lambda" {
   }
 
   statement {
-    sid    = "SQSPermissionsUploadToPdmQueue"
+    sid    = "SQSPermissionsUploadToCoreNotifierQueue"
     effect = "Allow"
 
     actions = [

tests/playwright/constants/backend-constants.ts

@@ -11,6 +11,7 @@ export const CSI = `nhs-${ENV}-dl`;
 export const MESH_POLL_LAMBDA_NAME = `${CSI}-mesh-poll`;
 export const TTL_CREATE_LAMBDA_NAME = `${CSI}-ttl-create`;
 export const TTL_POLL_LAMBDA_NAME = `${CSI}-ttl-poll`;
+export const CORE_NOTIFIER_LAMBDA_NAME = `${CSI}-core-notifier`;
 
 // Queue Names
 export const TTL_QUEUE_NAME = `${CSI}-ttl-queue`;