CCM-12858: lint fixes

Author: nhsd-angel-pastor

lambdas/core-notifier-lambda/src/__tests__/apis/sqs-handler.test.ts

@@ -34,23 +34,25 @@ describe('createHandler', () => {
   const mockSender: Sender = {
     senderId,
     routingConfigId,
-    displayName: 'Test Sender',
-    clientId: 'client-123',
-    campaignId: 'campaign-123',
+    senderName: 'Test Sender',
+    meshMailboxSenderId: 'meshMailBoxSender-123',
+    meshMailboxReportsId: 'meshMailBoxReports-123',
+    fallbackWaitTimeSeconds: 100,
   };
 
   const mockPdmEvent: PDMResourceAvailable = {
     id: 'event-id-123',
     source: 'urn:nhs:names:services:notify:pdm',
     specversion: '1.0',
-    type: 'uk.nhs.notify.pdm.resource.available',
+    type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
     time: '2025-12-15T10:00:00Z',
     datacontenttype: 'application/json',
     data: {
       senderId,
       messageReference,
-      resourceType: 'letter',
-      resourceLocation: 's3://bucket/key',
+      resourceId: 'ResourceId-123',
+      nhsNumber: '9991234566',
+      odsCode: 'A12345',
     },
   };
 

lambdas/core-notifier-lambda/src/__tests__/app/parse-sqs-message.test.ts

@@ -20,14 +20,15 @@ describe('parseSqsRecord', () => {
     id: 'event-id-123',
     source: 'urn:nhs:names:services:notify:pdm',
     specversion: '1.0',
-    type: 'uk.nhs.notify.pdm.resource.available',
+    type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
     time: '2025-12-15T10:00:00Z',
     datacontenttype: 'application/json',
     data: {
       senderId: 'sender-123',
       messageReference: 'ref-123',
-      resourceType: 'letter',
-      resourceLocation: 's3://bucket/key',
+      resourceId: 'ResourceId-123',
+      nhsNumber: '9991234566',
+      odsCode: 'A12345',
     },
   };
 

lambdas/core-notifier-lambda/src/__tests__/domain/mapper.test.ts

@@ -48,7 +48,7 @@ describe('mapper', () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
-    mockRandomUUID.mockReturnValue('mock-uuid-123');
+    mockRandomUUID.mockReturnValue('45e7d942-0d33-46d1-a678-ada01e5de9fe');
   });
 
   describe('mapPdmEventToSingleMessageRequest', () => {
@@ -99,7 +99,7 @@ describe('mapper', () => {
 
       expect(result).toEqual({
         ...mockPdmEvent,
-        id: 'mock-uuid-123',
+        id: '45e7d942-0d33-46d1-a678-ada01e5de9fe',
         time: '2024-01-15T12:00:00.000Z',
         recordedtime: '2024-01-15T12:00:00.000Z',
         type: 'uk.nhs.notify.digital.letters.messages.request.submitted.v1',
@@ -130,7 +130,7 @@ describe('mapper', () => {
 
       expect(result).toEqual({
         ...mockPdmEvent,
-        id: 'mock-uuid-123',
+        id: '45e7d942-0d33-46d1-a678-ada01e5de9fe',
         time: '2024-01-15T12:00:00.000Z',
         recordedtime: '2024-01-15T12:00:00.000Z',
         type: 'uk.nhs.notify.digital.letters.messages.request.skipped.v1',
@@ -218,7 +218,7 @@ describe('mapper', () => {
 
       expect(result).toEqual({
         ...mockPdmEvent,
-        id: 'mock-uuid-123',
+        id: '45e7d942-0d33-46d1-a678-ada01e5de9fe',
         time: '2024-01-15T12:00:00.000Z',
         recordedtime: '2024-01-15T12:00:00.000Z',
         type: 'uk.nhs.notify.digital.letters.messages.request.rejected.v1',

lambdas/core-notifier-lambda/src/__tests__/infra/event-publisher-facade.test.ts

@@ -39,13 +39,14 @@ describe('EventPublisherFacade', () => {
         id: 'event-id-123',
         source: 'urn:nhs:names:services:notify:core-notifier',
         specversion: '1.0',
-        type: 'uk.nhs.notify.message-request.submitted',
+        type: 'uk.nhs.notify.digital.letters.messages.request.submitted.v1',
         time: '2025-12-15T10:00:00Z',
         datacontenttype: 'application/json',
         data: {
           senderId: 'sender-123',
           messageReference: 'msg-ref-123',
-          notifyMessageId: 'notify-id-123',
+          notifyId: 'notify-id-123',
+          messageUri: 's3://dlbucket/document.pdf',
         },
       };
 
@@ -66,13 +67,14 @@ describe('EventPublisherFacade', () => {
         id: 'event-id-456',
         source: 'urn:nhs:names:services:notify:core-notifier',
         specversion: '1.0',
-        type: 'uk.nhs.notify.message-request.rejected',
+        type: 'uk.nhs.notify.digital.letters.messages.request.rejected.v1',
         time: '2025-12-15T10:00:00Z',
         datacontenttype: 'application/json',
         data: {
           senderId: 'sender-456',
           messageReference: 'msg-ref-456',
-          errorCode: 'VALIDATION_ERROR',
+          failureCode: 'VALIDATION_ERROR',
+          messageUri: 's3://dlbucket/document.pdf',
         },
       };
 
@@ -93,13 +95,12 @@ describe('EventPublisherFacade', () => {
         id: 'event-id-789',
         source: 'urn:nhs:names:services:notify:core-notifier',
         specversion: '1.0',
-        type: 'uk.nhs.notify.message-request.skipped',
+        type: 'uk.nhs.notify.digital.letters.messages.request.skipped.v1',
         time: '2025-12-15T10:00:00Z',
         datacontenttype: 'application/json',
         data: {
           senderId: 'sender-789',
           messageReference: 'msg-ref-789',
-          reason: 'No routing configuration',
         },
       };
 

lambdas/core-notifier-lambda/src/apis/sqs-handler.ts

@@ -22,7 +22,7 @@ import { RequestNotifyError } from 'domain/request-notify-error';
 export interface SqsHandlerDependencies {
   notifyMessageProcessor: NotifyMessageProcessor;
   logger: Logger;
-  senderManagement: SenderManagement;
+  senderManagement: typeof SenderManagement;
   eventPublisherFacade: EventPublisherFacade;
 }