Address code review comments

Author: tdroza-nhs

src/cloudevents/domains/digital-letters/2025-10-draft/data/digital-letters-print-letter-transitioned-data.schema.yaml

@@ -4,16 +4,19 @@ description: Base data of the PrintLetterTransitioned event
 type: object
 additionalProperties: false
 properties:
-  subject:
-    $ref: ../defs/print.schema.yaml#/properties/subject
+  senderId:
+    $ref: ../defs/requests.schema.yaml#/properties/senderId
+  messageReference:
+    $ref: ../defs/requests.schema.yaml#/properties/messageReference
   status:
     $ref: ../defs/print.schema.yaml#/properties/status
   supplierId:
     $ref: ../defs/print.schema.yaml#/properties/supplierId
   time:
-    $ref: ../defs/print.schema.yaml#/properties/time
+    $ref: ../defs/core.schema.yaml#/properties/time
 required:
-  - subject
+  - senderId
+  - messageReference
   - status
   - supplierId
   - time

src/cloudevents/domains/digital-letters/2025-10-draft/defs/core.schema.yaml

@@ -18,3 +18,12 @@ properties:
       - "CM_NOT_ALLOWED"
       - "CM_NO_SUCH_ROUTING_PLAN"
       - "CM_DUPLICATE_REQUEST"
+  time:
+    title: "Event Time"
+    description: "Timestamp when the event occurred (RFC 3339)."
+    examples: [
+      "2025-10-01T10:15:30.000Z"
+    ]
+    type: "string"
+    format: "date-time"
+    pattern: "^(?:(?:\\d\\d[2468][048]|\\d\\d[13579][26]|\\d\\d0[48]|[02468][048]00|[13579][26]00)-02-29|\\d{4}-(?:(?:0[13578]|1[02])-(?:0[1-9]|[12]\\d|3[01])|(?:0[469]|11)-(?:0[1-9]|[12]\\d|30)|(?:02)-(?:0[1-9]|1\\d|2[0-8])))T(?:(?:[01]\\d|2[0-3]):[0-5]\\d(?::[0-5]\\d(?:\\.\\d+)?)?(?:Z))$"

src/cloudevents/domains/digital-letters/2025-10-draft/defs/print.schema.yaml

@@ -3,13 +3,8 @@ title: Print data
 description: Reusable types for NHS Notify payload schemas.
 type: object
 properties:
-  subject:
-    type: string
-    description: The subject of the event which created this letter
-    examples:
-      - "client/00f3b388-bbe9-41c9-9e76-052d37ee8988/letter-request/0o5Fs0EELR0fUjHjbCnEtdUwQe4_0o5Fs0EELR0fUjHjbCnEtdUwQe5"
   status:
-    type: integer
+    type: string
     minimum: 1
     description: Number of times that PDM has been polled while waiting for document processing to complete
     enum: [
@@ -29,12 +24,3 @@ properties:
     description: Identifier of the print supplier handling the print job
     examples:
       - "supplier-12345"
-  time:
-    title: "Event Time"
-    description: "Timestamp when the event occurred (RFC 3339)."
-    examples: [
-      "2025-10-01T10:15:30.000Z"
-    ]
-    type: "string"
-    format: "date-time"
-    pattern: "^(?:(?:\\d\\d[2468][048]|\\d\\d[13579][26]|\\d\\d0[48]|[02468][048]00|[13579][26]00)-02-29|\\d{4}-(?:(?:0[13578]|1[02])-(?:0[1-9]|[12]\\d|3[01])|(?:0[469]|11)-(?:0[1-9]|[12]\\d|30)|(?:02)-(?:0[1-9]|1\\d|2[0-8])))T(?:(?:[01]\\d|2[0-3]):[0-5]\\d(?::[0-5]\\d(?:\\.\\d+)?)?(?:Z))$"

src/cloudevents/domains/digital-letters/2025-10-draft/defs/requests.schema.yaml

@@ -12,7 +12,7 @@ properties:
     type: string
     description: Identifier that the sender provided during onboarding. Provided in the body of each FHIR resource submitted by the sender.
     examples:
-      - ""
+      - "Trust-12345"
   messageUri:
     type: string
     format: uri

src/cloudevents/domains/digital-letters/2025-10-draft/events/uk.nhs.notify.digital.letters.print.letter.transitioned.v1.schema.yaml

@@ -15,9 +15,9 @@ properties:
 
   dataschema:
     type: string
-    const: ../data/digital-letters-pdm-resource-unavailable-data.schema.yaml
+    const: ../data/digital-letters-print-letter-transitioned-data.schema.yaml
     description: Canonical URI of the event's data schema.
     examples:
-      - digital-letters-pdm-resource-unavailable-data.schema.yaml
+      - digital-letters-print-letter-transitioned-data.schema.yaml
   data:
-    $ref: ../data/digital-letters-pdm-resource-unavailable-data.schema.yaml
+    $ref: ../data/digital-letters-print-letter-transitioned-data.schema.yaml

src/cloudevents/readme-index.yaml

@@ -3,7 +3,7 @@
 # To regenerate, run: make update-readme
 # To customize labels and purposes, edit: readme-metadata.yaml
 
-generated: '2025-12-15T20:32:06.778Z'
+generated: '2025-12-17T17:04:30.354Z'
 common: null
 domains:
   - name: digital-letters