Skip to content

Commit e7231db

Browse files
CCM-13342: POC removing duplicated npm ci and using setup-node
1 parent ba32328 commit e7231db

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

.github/workflows/stage-2-test.yaml

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ jobs:
5252
steps:
5353
- name: "Checkout code"
5454
uses: actions/checkout@v5
55+
- uses: actions/setup-node@v6
56+
with:
57+
node-version: 24.10.0
5558
- name: "Repo setup"
5659
run: |
5760
npm ci
@@ -66,12 +69,12 @@ jobs:
6669
steps:
6770
- name: "Checkout code"
6871
uses: actions/checkout@v5
69-
- name: "Repo setup"
70-
run: |
71-
npm ci
72-
- name: "Generate dependencies"
73-
run: |
74-
npm run generate-dependencies
72+
- uses: actions/setup-node@v6
73+
with:
74+
node-version: 24.10.0
75+
- uses: actions/setup-python@v6
76+
with:
77+
python-version: '3.14'
7578
- name: "Run unit test suite"
7679
run: |
7780
make test-unit
@@ -99,12 +102,9 @@ jobs:
99102
steps:
100103
- name: "Checkout code"
101104
uses: actions/checkout@v5
102-
- name: "Repo setup"
103-
run: |
104-
npm ci
105-
- name: "Generate dependencies"
106-
run: |
107-
npm run generate-dependencies
105+
- uses: actions/setup-node@v6
106+
with:
107+
node-version: 24.10.0
108108
- name: "Run linting"
109109
run: |
110110
make test-lint
@@ -115,12 +115,9 @@ jobs:
115115
steps:
116116
- name: "Checkout code"
117117
uses: actions/checkout@v5
118-
- name: "Repo setup"
119-
run: |
120-
npm ci
121-
- name: "Generate dependencies"
122-
run: |
123-
npm run generate-dependencies
118+
- uses: actions/setup-node@v6
119+
with:
120+
node-version: 24.10.0
124121
- name: "Run typecheck"
125122
run: |
126123
make test-typecheck

scripts/tests/lint.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ set -euo pipefail
55
cd "$(git rev-parse --show-toplevel)"
66

77
npm ci
8+
npm run generate-dependencies
89
npm run lint

scripts/tests/typecheck.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ set -euo pipefail
55
cd "$(git rev-parse --show-toplevel)"
66

77
npm ci
8+
npm run generate-dependencies
89
npm run typecheck

scripts/tests/unit.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ make -C ./src/eventcatalogasyncapiimporter coverage # Run with coverage to gene
3737
# TypeScript/JavaScript projects (npm workspace)
3838
# Note: src/cloudevents is included in workspaces, so it will be tested here
3939
npm ci
40+
npm run generate-dependencies
4041
npm run test:unit --workspaces
4142

4243
# merge coverage reports

0 commit comments

Comments
 (0)