Skip to content

Commit e91851a

Browse files
authored
CCM-13080: Add MessageRequestSkipped event and fix schema refs (#120)
* - Add MessageRequestSkipped event schema for handling bypassed message requests - Update print TTL sequence diagram to show configurable fallback wait time - Remove unused/obsolete event schemas and documentation files - Update schema_data references from generic base schema to specific schemas - Improved event descriptions with business context - Fix schema references to use correct event and data schema URLs * Change MessageRequestFailed --> MessageRequestRejected due to event naming rules
1 parent 05e5233 commit e91851a

File tree

41 files changed

+212
-350
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+212
-350
lines changed

README.md

Lines changed: 26 additions & 33 deletions
Large diffs are not rendered by default.

docs/collections/_diagrams/c4code-core-notifier.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,20 @@ architecture-beta
99
group coreNotifier(cloud)[CoreNotifier]
1010
service meshDownloaded(aws:res-amazon-eventbridge-event)[PDMResourceAvailable Event]
1111
service sqs(logos:aws-sqs)[CoreNotifier Queue] in coreNotifier
12+
service clientConfig(aws:res-aws-systems-manager-parameter-store)[Client Configuration] in coreNotifier
1213
service coreNotified(aws:res-amazon-eventbridge-event)[MessageRequestSubmitted Event]
13-
service coreFailed(aws:res-amazon-eventbridge-event)[MessageRequestFailed Event]
14+
service coreFailed(aws:res-amazon-eventbridge-event)[MessageRequestRejected Event]
15+
service coreSkipped(aws:res-amazon-eventbridge-event)[MessageRequestSkipped Event]
1416
service notifier(logos:aws-lambda)[CoreNotifier] in coreNotifier
1517
service notify(server)[NHS Notify Core]
1618
junction j1
1719
1820
meshDownloaded:R --> L:sqs
1921
sqs:R --> L:notifier
22+
clientConfig:B --> T:notifier
2023
notifier:B --> T:notify
21-
notifier:R --> L:j1
22-
j1:R -- L:coreNotified
24+
notifier:R -- L:j1
25+
j1:T --> L:coreNotified
26+
j1:R -- L:coreSkipped
2327
j1:B --> L:coreFailed
2428
```

docs/collections/_diagrams/c4code-printer-sendtoqueue.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@ description: PDM Upload
88
group createTtl(cloud)[QueueAdder]
99
1010
service db(aws:arch-amazon-dynamodb)[ItemsWithTTL] in createTtl
11+
service clientConfig(aws:res-aws-systems-manager-parameter-store)[Client Configuration] in createTtl
1112
service createLambda(logos:aws-lambda)[CreateTTL] in createTtl
1213
service queue(logos:aws-sqs)[SQS] in createTtl
1314
service storedEvent(aws:res-amazon-eventbridge-event)[MESHInboxMessageDownloaded event]
1415
service scheduledEvent(aws:res-amazon-eventbridge-event) [ItemEnqueued event]
1516
1617
storedEvent:R --> L:queue
1718
queue:R --> L:createLambda
19+
clientConfig:B --> T:createLambda
1820
createLambda:R --> L:db
19-
createLambda:T --> L:scheduledEvent
21+
createLambda:B --> L:scheduledEvent
2022
```

docs/collections/_diagrams/sequence-create-print-ttl.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,13 @@ sequenceDiagram
99
participant eb as Event Bridge
1010
participant sqs as SQS<br/>CreateTTLQueue
1111
participant createTTL as Lambda<br/>CreateTTL
12+
participant ssm as SSM<br/>Parameter Store
1213
participant dynamo as DynamoDB
1314
1415
1516
eb ->> sqs: MESHInboxMessageDownloaded event
1617
sqs ->> createTTL:
17-
createTTL ->> dynamo: Insert (24h TTL)
18+
createTTL ->> ssm: Get FallbackWaitTime
19+
ssm -->> createTTL:
20+
createTTL ->> dynamo: Insert (FallbackWaitTime TTL)
1821
```

docs/collections/_events/event-bus-timer-time-expired.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

docs/collections/_events/fhir-attachment-extracted.md

Lines changed: 0 additions & 12 deletions
This file was deleted.

docs/collections/_events/letter-available.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

docs/collections/_events/mesh-inbox-message-downloaded.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ type: uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1
44
nice_name: MESHInboxMessageDownloaded
55
service: MESH Services
66
schema_envelope: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/events/uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1.schema.json
7-
schema_data: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letter-base-data.schema.json
7+
schema_data: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-mesh-inbox-message-downloaded-data.schema.json
88
---
99

1010
This is an event.

docs/collections/_events/mesh-inbox-message-received.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ type: uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1
44
nice_name: MESHInboxMessageReceived
55
service: MESH Services
66
schema_envelope: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/events/uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1.schema.json
7-
schema_data: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letter-base-data.schema.json
7+
schema_data: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-mesh-inbox-message-received-data.schema.json
88
---
99

1010
This is an event.

docs/collections/_events/mesh-poller-timer-expired.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)