CCM-12896: Add a unit test for generate_models

Author: gareth-allan

scripts/config/sonar-scanner.properties

@@ -1,9 +1,7 @@
 # Please DO NOT set the following properties `sonar.organization` and `sonar.projectKey` in this file. They must be stored as `SONAR_ORGANISATION_KEY` and `SONAR_PROJECT_KEY` GitHub secrets.
 
 sonar.host.url=https://sonarcloud.io
-# Temporary change to allow testing of build before fixing Sonar coverage issues
-sonar.qualitygate.wait=false
-sonar.log.level=TRACE
+sonar.qualitygate.wait=true
 sonar.sourceEncoding=UTF-8
 sonar.sources=.
 sonar.tests=tests/, src/asyncapigenerator/tests, src/cloudeventjekylldocs/tests, src/eventcatalogasyncapiimporter/tests, src/python-schema-generator/tests, src/cloudevents/tools/builder/__tests__, src/cloudevents/tools/cache/__tests__, src/cloudevents/tools/generator/__tests__, lambdas/mesh-poll/src/__tests__, lambdas/ttl-create-lambda/src/__tests__, lambdas/ttl-poll-lambda/src/__tests__, utils/utils/src/__tests__, utils/sender-management/src/__tests__

src/python-schema-generator/Makefile

@@ -34,12 +34,12 @@ generate: install
 # Run tests
 test: install-dev
 	@echo "Running tests..."
-	@pytest tests/
+	@cd ../.. && PYTHONPATH=src/python-schema-generator/src:$$PYTHONPATH pytest src/python-schema-generator/tests/
 
 # Generate coverage report
 coverage: install-dev
 	@echo "Generating coverage report..."
-	@cd ../.. && pytest src/python-schema-generator/tests/ \
+	@cd ../.. && PYTHONPATH=src/python-schema-generator/src:$$PYTHONPATH pytest src/python-schema-generator/tests/ \
 		--cov=src/python-schema-generator \
 		--cov-config=src/python-schema-generator/pytest.ini \
 		--cov-report=html:src/python-schema-generator/htmlcov \

src/python-schema-generator/src/generate_models.py

@@ -46,14 +46,12 @@ def parse_args() -> argparse.Namespace:
     return parser.parse_args()
 
 
-def main() -> int:
+def main(args) -> int:
     """Main entry point for the generator.
 
     Returns:
         Exit code (0 for success, 1 for failure)
     """
-    args = parse_args()
-
     try:
         print(f"Generating models in: {args.output_dir}")
 
@@ -89,4 +87,5 @@ def main() -> int:
 
 
 if __name__ == "__main__":
-    sys.exit(main())
+    args = parse_args()
+    sys.exit(main(args))

src/python-schema-generator/tests/test_generate_models.py

@@ -0,0 +1,54 @@
+from src.generate_models import main
+from argparse import Namespace
+
+class TestGenerateModels:
+    """Tests for generate_models module."""
+
+    def test_main_returns_zero_on_success(self, tmp_path):
+        """Test that main returns 0 on successful execution."""
+        input_dir = tmp_path / "input"
+        output_dir = tmp_path / "output"
+        input_dir.mkdir()
+        output_dir.mkdir()
+
+        (input_dir / "test.flattened.schema.json").write_text(
+            '{"title": "TestSchema", "type": "object"}'
+        )
+        args = Namespace(input_dir=str(input_dir), output_dir=str(output_dir))
+
+        exit_code = main(args)
+
+        assert exit_code == 0
+
+    def test_main_returns_one_on_failure(self):
+        """Test that main returns 1 on failure."""
+        input_dir = "/nonexistent/input/dir"
+        output_dir = "/nonexistent/output/dir"
+        args = Namespace(input_dir=str(input_dir), output_dir=str(output_dir))
+
+        exit_code = main(args)
+        assert exit_code == 1
+
+    def test_main_generates_a_model_for_each_schema_and_an_init_file(self, tmp_path):
+        """Test that main generates Pydantic models from JSON schemas."""
+        input_dir = tmp_path / "input"
+        output_dir = tmp_path / "output"
+        input_dir.mkdir()
+        output_dir.mkdir()
+
+        (input_dir / "one.flattened.schema.json").write_text(
+            '{"title": "One", "type": "object"}'
+        )
+        (input_dir / "two.flattened.schema.json").write_text(
+            '{"title": "Two", "type": "object"}'
+        )
+
+        args = Namespace(input_dir=str(input_dir), output_dir=str(output_dir))
+
+        main(args)
+
+        generated_files = list(output_dir.glob("*.py"))
+        assert len(generated_files) == 3
+        assert (output_dir / "__init__.py").exists()
+        assert (output_dir / "one.py").exists()
+        assert (output_dir / "two.py").exists()