Remove supplierId from domain model (#27)

m-houston · web-flow · commit ee5760f500cf · 2025-11-26T15:51:27.000Z
* Remove supplierId from domain model

* Revert to 1.1.1
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/events/package.json b/packages/events/package.json
@@ -40,5 +40,5 @@
     "test:unit": "jest",
     "prepare": "npm run build"
   },
-  "version": "1.1.0"
+  "version": "1.1.1"
 }
diff --git a/packages/events/schemas/examples/letter-request.prepared.json b/packages/events/schemas/examples/letter-request.prepared.json
@@ -11,7 +11,6 @@
     "requestItemPlanId": "0o5Fs0EELR0fUjHjbCnEtdUwQe5",
     "sha256Hash": "3a7bd3e2360a3d29eea436fcfb7e44c735d117c8f2f1d2d1e4f6e8f7e6e8f7e6",
     "status": "PREPARED",
-    "supplierId": "supplier_123",
     "templateId": "template_123",
     "url": "https://s3.eu-west-2.amazonaws.com/notify-letters-dev/letters/f47ac10b-58cc-4372-a567-0e02b2c3d479.pdf"
   },
diff --git a/packages/events/src/domain/letter-request.ts b/packages/events/src/domain/letter-request.ts
@@ -45,12 +45,6 @@ export const $LetterRequest = DomainBase("LetterRequest")
         "Identifier for the request item plan which associated with this letter request",
       examples: ["1y3q9v1zzzz"],
     }),
-    supplierId: z.string().meta({
-      title: "Supplier ID",
-      description:
-        "Identifier for the supplier which should print and post the letter",
-      examples: ["supplier-004", "supplier-abc"],
-    }),
     templateId: z
       .string()
       .optional()
diff --git a/packages/events/src/events/__tests__/testData/letter-request-prepared-valid.json b/packages/events/src/events/__tests__/testData/letter-request-prepared-valid.json
@@ -11,7 +11,6 @@
     "requestItemPlanId": "0o5Fs0EELR0fUjHjbCnEtdUwQe5",
     "sha256Hash": "3a7bd3e2360a3d29eea436fcfb7e44c735d117c8f2f1d2d1e4f6e8f7e6e8f7e6",
     "status": "PREPARED",
-    "supplierId": "supplier_123",
     "templateId": "template_123",
     "url": "https://s3.eu-west-2.amazonaws.com/notify-letters-dev/letters/f47ac10b-58cc-4372-a567-0e02b2c3d479.pdf"
   },
diff --git a/packages/events/src/events/__tests__/testData/letter-request-prepared-with-invalid-major-version.json b/packages/events/src/events/__tests__/testData/letter-request-prepared-with-invalid-major-version.json
@@ -11,7 +11,6 @@
     "requestItemPlanId": "0o5Fs0EELR0fUjHjbCnEtdUwQe5",
     "sha256Hash": "3a7bd3e2360a3d29eea436fcfb7e44c735d117c8f2f1d2d1e4f6e8f7e6e8f7e6",
     "status": "PREPARED",
-    "supplierId": "supplier_123",
     "templateId": "template_123",
     "url": "https://s3.eu-west-2.amazonaws.com/notify-letters-dev/letters/f47ac10b-58cc-4372-a567-0e02b2c3d479.pdf"
   },
diff --git a/packages/events/src/events/__tests__/testData/letter-request-prepared-with-missing-fields.json b/packages/events/src/events/__tests__/testData/letter-request-prepared-with-missing-fields.json
@@ -10,7 +10,6 @@
     "requestItemPlanId": "0o5Fs0EELR0fUjHjbCnEtdUwQe5",
     "sha256Hash": "3a7bd3e2360a3d29eea436fcfb7e44c735d117c8f2f1d2d1e4f6e8f7e6e8f7e6",
     "status": "PREPARED",
-    "supplierId": "supplier_123",
     "templateId": "template_123",
     "url": "https://s3.eu-west-2.amazonaws.com/notify-letters-dev/letters/f47ac10b-58cc-4372-a567-0e02b2c3d479.pdf"
   },

Original file line number	Diff line number	Diff line change
`@@ -40,5 +40,5 @@`
`40`	`40`	`"test:unit": "jest",`
`41`	`41`	`"prepare": "npm run build"`
`42`	`42`	`},`
`43`		`- "version": "1.1.0"`
	`43`	`+ "version": "1.1.1"`
`44`	`44`	`}`