CCM-11938: Fix sonar issues

Author: sidnhs

.github/actions/build-proxies/action.yml

@@ -71,15 +71,17 @@ runs:
 
     - name: Build ${{ inputs.apimEnv }} oas
       working-directory: .
+      env:
+        APIM_ENV: ${{ inputs.apimEnv }}
       shell: bash
       run: |
-        if [ ${{ inputs.apimEnv }} == "internal-dev-sandbox" ] && [ ${{ inputs.buildSandbox }} == true ]
+        if [ ${{ env.APIM_ENV }} == "internal-dev-sandbox" ] && [ ${{ inputs.buildSandbox }} == true ]
         then
           echo "Building sandbox OAS spec"
           make build-json-oas-spec APIM_ENV=sandbox
         else
           echo "Building env specific OAS spec"
-          make build-json-oas-spec APIM_ENV=${{ inputs.apimEnv }}
+          make build-json-oas-spec APIM_ENV=${{ env.APIM_ENV }}
         fi
         if [[ $APIM_ENV == *-pr ]]; then
           echo "Removing pr suffix from APIM_ENV after building OAS and calling proxygen"
@@ -90,7 +92,7 @@ runs:
     - name: Upload OAS Spec
       uses: actions/upload-artifact@v4
       with:
-        name: ${{ inputs.apimEnv }}-build-output
+        name: ${{ env.APIM_ENV }}-build-output
         path: ./build
 
     - name: Trigger deploy proxy
@@ -106,7 +108,7 @@ runs:
           --targetEnvironment "${{ inputs.environment }}" \
           --runId "${{ inputs.runId }}" \
           --buildSandbox ${{ inputs.buildSandbox }} \
-          --apimEnvironment "${{ inputs.apimEnv }}" \
+          --apimEnvironment "${{ env.APIM_ENV }}" \
           --boundedContext "notify-supplier" \
           --targetDomain "$TARGET_DOMAIN" \
           --version "${{ inputs.version }}"