make supplierId required

Author: alexnuttall

internal/events/src/domain/letter.ts

@@ -108,15 +108,11 @@ The identifier will be included as the origin domain in the subject of any corre
         examples: ["Undeliverable", "Recipient moved"],
       }),
 
-    supplierId: z
-      .string()
-      .optional()
-      .meta({
-        title: "Supplier ID",
-        description:
-          "Optional identifier for the supplier handling this letter, if applicable.",
-        examples: ["supplier-12345"],
-      }),
+    supplierId: z.string().meta({
+      title: "Supplier ID",
+      description: "Identifier for the supplier handling this letter.",
+      examples: ["supplier-12345"],
+    }),
   })
   .meta({
     title: "Letter",

internal/events/src/events/__tests__/letter-status-change-events.test.ts

@@ -42,6 +42,7 @@ describe("LetterStatus event validations", () => {
             specificationId: "1y3q9v1zzzz",
             groupId: "client_template",
             status,
+            supplierId: "supplier_12345",
           }),
         }),
       );

internal/events/src/events/__tests__/testData/letter.accepted-with-invalid-major-version.json

@@ -9,7 +9,8 @@
       "subject": "client/00f3b388-bbe9-41c9-9e76-052d37ee8988/letter-request/0o5Fs0EELR0fUjHjbCnEtdUwQe4_0o5Fs0EELR0fUjHjbCnEtdUwQe5"
     },
     "specificationId": "1y3q9v1zzzz",
-    "status": "ACCEPTED"
+    "status": "ACCEPTED",
+    "supplierId": "supplier_12345"
   },
   "datacontenttype": "application/json",
   "dataschema": "https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.accepted.0.1.0.schema.json",

internal/events/src/events/__tests__/testData/letter.accepted-with-missing-fields.json

@@ -8,7 +8,8 @@
       "source": "/data-plane/letter-rendering/prod/letter-renderer"
     },
     "specificationId": "1y3q9v1zzzz",
-    "status": "ACCEPTED"
+    "status": "ACCEPTED",
+    "supplierId": "supplier_12345"
   },
   "datacontenttype": "application/json",
   "dataschema": "https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.accepted.1.0.0.schema.json",

internal/events/src/events/__tests__/testData/letter.accepted.json

@@ -9,7 +9,8 @@
       "subject": "client/00f3b388-bbe9-41c9-9e76-052d37ee8988/letter-request/0o5Fs0EELR0fUjHjbCnEtdUwQe4_0o5Fs0EELR0fUjHjbCnEtdUwQe5"
     },
     "specificationId": "1y3q9v1zzzz",
-    "status": "ACCEPTED"
+    "status": "ACCEPTED",
+    "supplierId": "supplier_12345"
   },
   "datacontenttype": "application/json",
   "dataschema": "https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.accepted.1.0.0.schema.json",

internal/events/src/events/__tests__/testData/letter.forwarded.json

@@ -11,7 +11,8 @@
     "reasonCode": "RNIB",
     "reasonText": "RNIB",
     "specificationId": "1y3q9v1zzzz",
-    "status": "FORWARDED"
+    "status": "FORWARDED",
+    "supplierId": "supplier_12345"
   },
   "datacontenttype": "application/json",
   "dataschema": "https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.forwarded.1.0.0.schema.json",

internal/events/src/events/__tests__/testData/letter.returned.json

@@ -11,7 +11,8 @@
     "reasonCode": "R07",
     "reasonText": "No such address",
     "specificationId": "1y3q9v1zzzz",
-    "status": "RETURNED"
+    "status": "RETURNED",
+    "supplierId": "supplier_12345"
   },
   "datacontenttype": "application/json",
   "dataschema": "https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.returned.1.0.0.schema.json",