own review changes

Author: nhsd-david-wass

sandbox/controllers/Controller.js

@@ -13,7 +13,6 @@ class Controller {
     */
     Object.entries(payload.headers).forEach(([name, value]) => response.setHeader(name, String(value)));
     response.status(payload.code || 200);
-
     const responsePayload = payload.payload !== undefined ? payload.payload : payload;
     if (responsePayload instanceof Object) {
       response.json(responsePayload);
@@ -107,7 +106,6 @@ class Controller {
 
   static async handleRequest(request, response, serviceOperation) {
     try {
-      const requestParams = this.collectRequestParams(request);
       const serviceResponse = await serviceOperation(requestParams);
       Controller.sendResponse(response, serviceResponse);
     } catch (error) {

sandbox/utils/ResponseProvider.js

@@ -6,20 +6,7 @@ const futil = require('fs');
 // eslint-disable-next-line import/no-extraneous-dependencies
 const lodash = require('lodash');
 
-function mapExampleResponse1(requestBody, exampleResponseMap) {
-  const match = Object.entries(exampleResponseMap).find(async ([requestBodyPath, response]) => {
-    try {
-      const requestBodyContent = await fs.readFile(requestBodyPath, 'utf8');
-      const exampleRequestBody = JSON.parse(requestBodyContent);
-      return lodash.isEqual(requestBody, exampleRequestBody);
-    } catch (err) {
-      console.error(`Failed to process ${requestBodyPath}:`, err);
-      throw err;
-    }
-  });
 
-  return match ? match[1] : null; // Return the matched response, or undefined if no match
-}
 async function mapExampleResponse(requestBody, exampleResponseMap) {
 
   const entries = Object.entries(exampleResponseMap);

specification/api/components/responses/getLetter200.yml

@@ -6,4 +6,4 @@ content:
     examples:
       get-letters:
         value:
-          $ref: ../examples/getLetter/responses/getLetter.json
+          $ref: ../examples/getLetter/responses/getLetter-24L5eYSWGzCHlGmzNxuqVusPxDg.json

specification/api/components/responses/getLetters200.yml

@@ -6,4 +6,4 @@ content:
     examples:
       get-letters:
         value:
-          $ref: ../examples/getLetters/responses/getLetters.json
+          $ref: ../examples/getLetters/responses/getLetters_pending.json

specification/api/components/responses/patchLetter200.yml

@@ -6,4 +6,4 @@ content:
     examples:
       patch_letter-response:
         value:
-          $ref: ../examples/patchLetter/responses/patchLetter.json
+          $ref: ../examples/patchLetter/responses/patchLetter_ACCEPTED.json

specification/api/components/responses/postMI201.yml

@@ -6,4 +6,4 @@ content:
     examples:
       create-mi-response:
         value:
-          $ref: "../examples/createMI/responses/createMIResponse.json"
+          $ref: "../examples/createMI/responses/createMI_SUCCESS.json"