review changes

Author: nhsd-david-wass

infrastructure/terraform/components/api/module_lambda_letter_status_update.tf

@@ -82,17 +82,4 @@ data "aws_iam_policy_document" "letter_status_update" {
       module.letter_status_updates_queue.sqs_queue_arn
     ]
   }
-
-  statement {
-    sid    = "AllowSNSPublish"
-    effect = "Allow"
-
-    actions = [
-      "sns:Publish"
-    ]
-
-    resources = [
-      module.eventsub.sns_topic.arn
-    ]
-  }
 }

infrastructure/terraform/modules/eventsub/iam_role_sns.tf

@@ -45,7 +45,7 @@ data "aws_iam_policy_document" "firehose_delivery" {
     ]
 
     resources = [
-      "${aws_kinesis_firehose_delivery_stream.eventsub[0].arn}",
+      "${aws_kinesis_firehose_delivery_stream.main[0].arn}",
     ]
   }
 }

infrastructure/terraform/modules/eventsub/kinesis_firehose_delivery_stream.tf

@@ -1,4 +1,4 @@
-resource "aws_kinesis_firehose_delivery_stream" "eventsub" {
+resource "aws_kinesis_firehose_delivery_stream" "main" {
   count = var.enable_event_cache ? 1 : 0
 
   name        = local.csi

infrastructure/terraform/modules/eventsub/sns_topic_subscription_firehose.tf

@@ -4,6 +4,6 @@ resource "aws_sns_topic_subscription" "firehose" {
   topic_arn             = aws_sns_topic.main.arn
   protocol              = "firehose"
   subscription_role_arn = aws_iam_role.sns_role.arn
-  endpoint              = aws_kinesis_firehose_delivery_stream.eventsub[0].arn
+  endpoint              = aws_kinesis_firehose_delivery_stream.main
   raw_message_delivery  = var.enable_firehose_raw_message_delivery
 }