Skip to content

Commit 29b9b48

Browse files
committed
chore: Update SSL certificate paths in Dockerfile and post-create script to use combined global + custom certs
1 parent da8fc38 commit 29b9b48

File tree

2 files changed

+15
-18
lines changed

2 files changed

+15
-18
lines changed

scripts/devcontainer/Dockerfile

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,17 @@ RUN apt-get update && apt-get install -y ca-certificates
66
COPY custom-ca-certs/. /usr/local/share/ca-certificates/
77
RUN update-ca-certificates
88

9-
# Concatenate all certs for use in EnvVars
10-
RUN find /usr/local/share/ca-certificates -type f \( -name '*.pem' -o -name '*.crt' \) -exec cat {} + > "/usr/local/share/ca-certificates/combined-cacerts.pem"
11-
12-
# Set environment variables at the Docker image level so they're available during feature installation
13-
ENV NODE_EXTRA_CA_CERTS="/usr/local/share/ca-certificates/combined-cacerts.pem"
14-
ENV SSL_CERT_FILE="/usr/local/share/ca-certificates/combined-cacerts.pem"
15-
ENV REQUESTS_CA_BUNDLE="/usr/local/share/ca-certificates/combined-cacerts.pem"
16-
ENV CURL_CA_BUNDLE="/usr/local/share/ca-certificates/combined-cacerts.pem"
17-
ENV GIT_SSL_CAINFO="/usr/local/share/ca-certificates/combined-cacerts.pem"
9+
# Use the updated system CA bundle which now includes both system and custom CAs
10+
ENV NODE_EXTRA_CA_CERTS="/etc/ssl/certs/ca-certificates.crt"
11+
ENV SSL_CERT_FILE="/etc/ssl/certs/ca-certificates.crt"
12+
ENV REQUESTS_CA_BUNDLE="/etc/ssl/certs/ca-certificates.crt"
13+
ENV CURL_CA_BUNDLE="/etc/ssl/certs/ca-certificates.crt"
14+
ENV GIT_SSL_CAINFO="/etc/ssl/certs/ca-certificates.crt"
1815

1916
# Ensure CA Certs is available for all shells, Node, Python & Ruby
2017
USER vscode
21-
RUN echo 'NODE_EXTRA_CA_CERTS="/usr/local/share/ca-certificates/combined-cacerts.pem"' >> ~/.zshrc
22-
RUN echo 'SSL_CERT_FILE="/usr/local/share/ca-certificates/combined-cacerts.pem"' >> ~/.zshrc
23-
RUN echo 'REQUESTS_CA_BUNDLE="/usr/local/share/ca-certificates/combined-cacerts.pem"' >> ~/.zshrc
24-
RUN echo 'CURL_CA_BUNDLE="/usr/local/share/ca-certificates/combined-cacerts.pem"' >> ~/.zshrc
25-
RUN echo 'GIT_SSL_CAINFO="/usr/local/share/ca-certificates/combined-cacerts.pem"' >> ~/.zshrc
18+
RUN echo 'NODE_EXTRA_CA_CERTS="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc
19+
RUN echo 'SSL_CERT_FILE="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc
20+
RUN echo 'REQUESTS_CA_BUNDLE="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc
21+
RUN echo 'CURL_CA_BUNDLE="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc
22+
RUN echo 'GIT_SSL_CAINFO="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc

scripts/devcontainer/postcreatecommand.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ echo 'export GPG_TTY=$TTY' | cat - ~/.zshrc > temp && mv temp ~/.zshrc
55
echo 'export PATH="$HOME/go/bin:/usr/local/go/bin:$PATH"' >> ~/.zshrc
66
echo 'export PATH="$HOME/.asdf/shims:$PATH"' >> ~/.zshrc
77
echo 'eval "$(asdf completion zsh)"' >> ~/.zshrc
8+
echo 'export SSL_CERT_FILE="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc
9+
echo 'export REQUESTS_CA_BUNDLE="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc
10+
echo 'export CURL_CA_BUNDLE="/etc/ssl/certs/ca-certificates.crt"' >> ~/.zshrc
811
source ~/.zshrc
912

1013
# Create pip config for SSL certificates before make config runs
1114
mkdir -p ~/.config/pip
1215
cat > ~/.config/pip/pip.conf << EOF
1316
[global]
14-
cert = /usr/local/share/ca-certificates/combined-cacerts.pem
15-
trusted-host = pypi.org
16-
files.pythonhosted.org
17-
pypi.python.org
17+
cert = /etc/ssl/certs/ca-certificates.crt
1818
EOF
1919

2020
make config

0 commit comments

Comments
 (0)