Add timestamp value to supplierStatusSk

Author: francisco-videira-nhs

infrastructure/terraform/components/api/README.md

@@ -31,8 +31,6 @@ No requirements.
 |------|--------|---------|
 | <a name="module_authorizer_lambda"></a> [authorizer\_lambda](#module\_authorizer\_lambda) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.20/terraform-lambda.zip | n/a |
 | <a name="module_domain_truststore"></a> [domain\_truststore](#module\_domain\_truststore) | git::https://github.com/NHSDigital/nhs-notify-shared-modules.git//infrastructure/modules/s3bucket | v2.0.17 |
-| <a name="module_get_letters"></a> [get\_letters](#module\_get\_letters) | git::https://github.com/NHSDigital/nhs-notify-shared-modules.git//infrastructure/modules/lambda | v2.0.10 |
-| <a name="module_kms"></a> [kms](#module\_kms) | git::https://github.com/NHSDigital/nhs-notify-shared-modules.git//infrastructure/modules/kms | v2.0.10 |
 | <a name="module_get_letters"></a> [get\_letters](#module\_get\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.20/terraform-lambda.zip | n/a |
 | <a name="module_kms"></a> [kms](#module\_kms) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.20/terraform-kms.zip | n/a |
 | <a name="module_logging_bucket"></a> [logging\_bucket](#module\_logging\_bucket) | git::https://github.com/NHSDigital/nhs-notify-shared-modules.git//infrastructure/modules/s3bucket | v2.0.17 |

internal/datastore/src/__test__/letter-repository.test.ts

@@ -205,7 +205,7 @@ describe('LetterRepository', () => {
         url: 's3://bucket/invalid-letter.pdf',
         status: 'PENDING',
         supplierStatus: 'supplier1#PENDING',
-        supplierStatusSk: 'supplier1',
+        supplierStatusSk: Date.now().toString(),
         createdAt: new Date().toISOString(),
         updatedAt: new Date().toISOString()
       }
@@ -219,7 +219,7 @@ describe('LetterRepository', () => {
     expect(logStream.logs).toContainEqual(expect.stringMatching(/.*specificationId.*Invalid input: expected string.*/));
   });
 
-  test("should return all letters for a supplier a status", async () => {
+  test("should return all letters for a supplier status", async () => {
     await letterRepository.putLetter(createLetter("supplier1", "letter1"));
     await letterRepository.putLetter(createLetter("supplier1", "letter2"));
     await letterRepository.putLetter(createLetter("supplier1", "letter3"));

internal/datastore/src/letter-repository.ts

@@ -34,7 +34,7 @@ export class LetterRepository {
     const letterDb: Letter = {
       ...letter,
       supplierStatus: `${letter.supplierId}#${letter.status}`,
-      supplierStatusSk: letter.id,
+      supplierStatusSk: Date.now().toString(),
       ttl: Math.floor(Date.now() / 1000 + 60 * 60 * this.config.ttlHours)
     };
     try {

lambdas/api-handler/src/mappers/__tests__/letter-mapper.test.ts

@@ -14,7 +14,7 @@ describe('toApiLetter', () => {
       createdAt: new Date().toISOString(),
       updatedAt: new Date().toISOString(),
       supplierStatus: 'supplier1#PENDING',
-      supplierStatusSk: 'supplier1',
+      supplierStatusSk: Date.now().toString(),
       ttl: 123
     };
 

lambdas/api-handler/src/services/__tests__/letter-operations.test.ts

@@ -26,7 +26,7 @@ function makeLetter(id: string, status: Letter['status']) : Letter {
       createdAt: new Date().toISOString(),
       updatedAt: new Date().toISOString(),
       supplierStatus: `supplier1#${status}`,
-      supplierStatusSk: 'supplier1',
+      supplierStatusSk: Date.now().toString(),
       ttl: 123
   };
 }