Addressed TF review comments

Author: stevebux

infrastructure/terraform/components/api/iam_role_api_gateway_execution_role.tf

@@ -50,9 +50,9 @@ data "aws_iam_policy_document" "api_gateway_execution_policy" {
     resources = [
       module.authorizer_lambda.function_arn,
       module.get_letter.function_arn,
+      module.get_letter_data.function_arn,
       module.get_letters.function_arn,
       module.patch_letter.function_arn,
-      module.get_letter_data.function_arn,
       module.post_mi.function_arn
     ]
   }

infrastructure/terraform/components/api/locals.tf

@@ -5,25 +5,25 @@ locals {
   root_domain_nameservers       = local.acct.route53_zone_nameservers["supplier-api"]
 
   openapi_spec = templatefile("${path.module}/resources/spec.tmpl.json", {
-    APIG_EXECUTION_ROLE_ARN  = aws_iam_role.api_gateway_execution_role.arn
-    AWS_REGION               = var.region
-    AUTHORIZER_LAMBDA_ARN    = module.authorizer_lambda.function_arn
-    GET_LETTER_LAMBDA_ARN  = module.get_letter.function_arn
-    GET_LETTERS_LAMBDA_ARN  = module.get_letters.function_arn
+    APIG_EXECUTION_ROLE_ARN     = aws_iam_role.api_gateway_execution_role.arn
+    AWS_REGION                  = var.region
+    AUTHORIZER_LAMBDA_ARN       = module.authorizer_lambda.function_arn
+    GET_LETTER_LAMBDA_ARN       = module.get_letter.function_arn
+    GET_LETTERS_LAMBDA_ARN      = module.get_letters.function_arn
     GET_LETTER_DATA_LAMBDA_ARN  = module.get_letter_data.function_arn
-    PATCH_LETTER_LAMBDA_ARN  = module.patch_letter.function_arn
-    POST_MI_LAMBDA_ARN       = module.post_mi.function_arn
+    PATCH_LETTER_LAMBDA_ARN     = module.patch_letter.function_arn
+    POST_MI_LAMBDA_ARN          = module.post_mi.function_arn
   })
 
   destination_arn = "arn:aws:logs:${var.region}:${var.shared_infra_account_id}:destination:nhs-main-obs-firehose-logs"
 
   common_lambda_env_vars = {
-    LETTERS_TABLE_NAME = aws_dynamodb_table.letters.name,
-    MI_TABLE_NAME = aws_dynamodb_table.mi.name,
-    LETTER_TTL_HOURS = 12960, # 18 months * 30 days * 24 hours
-    MI_TTL_HOURS = 2160 # 90 days * 24 hours
-    SUPPLIER_ID_HEADER = "nhsd-supplier-id",
-    APIM_CORRELATION_HEADER = "nhsd-correlation-id",
+    LETTERS_TABLE_NAME       = aws_dynamodb_table.letters.name,
+    MI_TABLE_NAME            = aws_dynamodb_table.mi.name,
+    LETTER_TTL_HOURS         = 12960, # 18 months * 30 days * 24 hours
+    MI_TTL_HOURS             = 2160 # 90 days * 24 hours
+    SUPPLIER_ID_HEADER       = "nhsd-supplier-id",
+    APIM_CORRELATION_HEADER  = "nhsd-correlation-id",
     DOWNLOAD_URL_TTL_SECONDS = 60
   }
 }