remove test archive

Author: Namitha-Prabhu

.github/actions/acceptance-tests/action.yaml

@@ -37,10 +37,3 @@ runs:
       shell: bash
       run: |
         make test-${{ inputs.testType }}
-
-    - name: Archive test results
-      uses: actions/upload-artifact@v4
-      if: always()
-      with:
-        name: ${{ inputs.testType }} - test report
-        path: "tests/acceptance-test-report"

tests/helpers/common-types.ts

@@ -1,4 +1,3 @@
-import { SUPPLIERID } from "../constants/api-constants";
 
 export type ErrorLink = {
   about: string;

tests/helpers/generate-fetch-test-data.ts

@@ -9,7 +9,7 @@ import {
   SUPPLIERID,
   envName,
 } from "../constants/api-constants";
-import { runCreateLetter } from "./pnpmHelpers";
+import { runCreateLetter } from "./pnpm-helpers";
 
 const ddb = new DynamoDBClient({});
 const docClient = DynamoDBDocumentClient.from(ddb);

tests/helpers/pnpm-helpers.ts

@@ -60,7 +60,8 @@ export default async function runCreateLetter(options: {
     String(count),
   ];
 
-await new Promise<void>((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
+    let output = "";
     const child = spawn(cmd, args, {
       stdio: "inherit",
       cwd: root,

tests/sandbox/get-list-of-letters.spec.ts

@@ -1,27 +1,35 @@
-import { test, expect, request } from '@playwright/test';
-import {  SUPPLIER_API_URL_SANDBOX, SUPPLIER_LETTERS} from '../constants/api-constants';
-import { apiSandboxGetLettersRequestTestData } from './testCases/get-list-of-letters-test-cases';
+import { expect, test } from "@playwright/test";
+import {
+  SUPPLIER_API_URL_SANDBOX,
+  SUPPLIER_LETTERS,
+} from "../constants/api-constants";
+import { apiSandboxGetLettersRequestTestData } from "./testCases/get-list-of-letters-test-cases";
 
-
-test.describe('Sandbox Tests To Get List Of Pending Letters ', () =>
-{
-  apiSandboxGetLettersRequestTestData.forEach(({ testCase, header, limit, expectedStatus, expectedResponse }) => {
+test.describe("Sandbox Tests To Get List Of Pending Letters ", () => {
+  for (const {
+    expectedResponse,
+    expectedStatus,
+    header,
+    limit,
+    testCase,
+  } of apiSandboxGetLettersRequestTestData) {
     test(`Get /Letters endpoint returns ${testCase}`, async ({ request }) => {
-
-    const response = await request.get(`${SUPPLIER_API_URL_SANDBOX}/${SUPPLIER_LETTERS}` ,{
-            headers: header,
-            params:{
-              limit: limit
-            },
+      const response = await request.get(
+        `${SUPPLIER_API_URL_SANDBOX}/${SUPPLIER_LETTERS}`,
+        {
+          headers: header,
+          params: {
+            limit,
           },
-        );
+        },
+      );
 
       const res = await response.json();
       await expect(response.status()).toBe(expectedStatus);
       expect(res).toEqual(expectedResponse);
-      if (response.status() === 200){
+      if (response.status() === 200) {
         expect(res.data.length.toString()).toEqual(limit);
       }
     });
-  });
+  }
 });

tests/sandbox/update-letter-status.spec.ts

@@ -3,7 +3,7 @@ import {
   SUPPLIER_API_URL_SANDBOX,
   SUPPLIER_LETTERS,
 } from "../constants/api-constants";
-import { apiSandboxUpdateLetterStatusTestData } from "./testCases/updateLetterStatus_testCases";
+import { apiSandboxUpdateLetterStatusTestData } from "./testCases/update-letter-status-test-cases";
 
 test.describe("Sandbox Tests To Update Letter Status", () => {
   for (const {

tests/sandbox/update-multiple-letter-status.spec.ts

@@ -1,18 +1,26 @@
-import { test, expect, request } from '@playwright/test';
-import {  SUPPLIER_API_URL_SANDBOX, SUPPLIER_LETTERS} from '../constants/api-constants';
-import { apiSandboxMultipleLetterStatusTestData } from './testCases/updateMultipleStatus_testCases';
+import { expect, test } from "@playwright/test";
+import {
+  SUPPLIER_API_URL_SANDBOX,
+  SUPPLIER_LETTERS,
+} from "../constants/api-constants";
+import { apiSandboxMultipleLetterStatusTestData } from "./testCases/update-multiple-status-test-cases";
 
-
-test.describe('Sandbox Tests To Update Multiple Letter Status', () =>
-{
-  apiSandboxMultipleLetterStatusTestData.forEach(({ testCase, header, body, expectedStatus }) => {
+test.describe("Sandbox Tests To Update Multiple Letter Status", () => {
+  for (const {
+    body,
+    expectedStatus,
+    header,
+    testCase,
+  } of apiSandboxMultipleLetterStatusTestData) {
     test(`Patch /Letters endpoint returns ${testCase}`, async ({ request }) => {
-
-        const response = await request.post(`${SUPPLIER_API_URL_SANDBOX}/${SUPPLIER_LETTERS}` ,{
-                headers: header,
-                data: body
-          });
-          expect(response.status()).toBe(expectedStatus);
+      const response = await request.post(
+        `${SUPPLIER_API_URL_SANDBOX}/${SUPPLIER_LETTERS}`,
+        {
+          headers: header,
+          data: body,
+        },
+      );
+      expect(response.status()).toBe(expectedStatus);
     });
-  });
+  }
 });