Logging fixes

Author: stevebux

infrastructure/terraform/modules/eventsub/cloudwatch_log_group_sns_delivery_logging_failure.tf

@@ -13,7 +13,7 @@ resource "aws_cloudwatch_log_group" "amendments_sns_delivery_logging_failure" {
 
   # SNS doesn't allow specifying a log group and is derived as: sns/${region}/${account_id}/${name_of_sns_topic}/Failure
   # (for failure logs)
-  name              = "sns/${var.region}/${var.aws_account_id}/${local.csi}_amendments/Failure"
+  name              = "sns/${var.region}/${var.aws_account_id}/${local.csi}-amendments/Failure"
   kms_key_id        = var.kms_key_arn
   retention_in_days = var.log_retention_in_days
 }

infrastructure/terraform/modules/eventsub/cloudwatch_log_group_sns_delivery_logging_success.tf

@@ -13,7 +13,7 @@ resource "aws_cloudwatch_log_group" "amendments_sns_delivery_logging_success" {
 
   # SNS doesn't allow specifying a log group and is derived as: sns/${region}/${account_id}/${name_of_sns_topic}
   # (for success logs)
-  name              = "sns/${var.region}/${var.aws_account_id}/${local.csi}_amendments"
+  name              = "sns/${var.region}/${var.aws_account_id}/${local.csi}-amendments"
   kms_key_id        = var.kms_key_arn
   retention_in_days = var.log_retention_in_days
 }

infrastructure/terraform/modules/eventsub/iam_policy_sns_delivery_logging_cloudwatch.tf

@@ -40,9 +40,9 @@ data "aws_iam_policy_document" "sns_delivery_logging_cloudwatch" {
       aws_cloudwatch_log_group.sns_delivery_logging_failure[0].arn,
       "${aws_cloudwatch_log_group.sns_delivery_logging_failure[0].arn}:log-stream:*",
       aws_cloudwatch_log_group.amendments_sns_delivery_logging_success[0].arn,
-      "${aws_cloudwatch_log_group.sns_delivery_logging_success[0].arn}:log-stream:*",
+      "${aws_cloudwatch_log_group.amendments_sns_delivery_logging_success[0].arn}:log-stream:*",
       aws_cloudwatch_log_group.amendments_sns_delivery_logging_failure[0].arn,
-      "${aws_cloudwatch_log_group.sns_delivery_logging_failure[0].arn}:log-stream:*",
+      "${aws_cloudwatch_log_group.amendments_sns_delivery_logging_failure[0].arn}:log-stream:*",
     ]
   }
 }