supplier data auto fixes

Author: nhsd-david-wass

scripts/utilities/supplier-data/jest.config.ts

@@ -1,7 +1,7 @@
-import type { Config } from 'jest';
+import type { Config } from "jest";
 
 export const baseJestConfig: Config = {
-  preset: 'ts-jest',
+  preset: "ts-jest",
 
   // Automatically clear mock calls, instances, contexts and results before every test
   clearMocks: true,
@@ -10,10 +10,10 @@ export const baseJestConfig: Config = {
   collectCoverage: true,
 
   // The directory where Jest should output its coverage files
-  coverageDirectory: './.reports/unit/coverage',
+  coverageDirectory: "./.reports/unit/coverage",
 
   // Indicates which provider should be used to instrument code for coverage
-  coverageProvider: 'babel',
+  coverageProvider: "babel",
 
   coverageThreshold: {
     global: {
@@ -24,37 +24,37 @@ export const baseJestConfig: Config = {
     },
   },
 
-  coveragePathIgnorePatterns: ['/__tests__/'],
-  transform: { '^.+\\.ts$': 'ts-jest' },
-  testPathIgnorePatterns: ['.build'],
-  testMatch: ['**/?(*.)+(spec|test).[jt]s?(x)'],
+  coveragePathIgnorePatterns: ["/__tests__/"],
+  transform: { "^.+\\.ts$": "ts-jest" },
+  testPathIgnorePatterns: [".build"],
+  testMatch: ["**/?(*.)+(spec|test).[jt]s?(x)"],
 
   // Use this configuration option to add custom reporters to Jest
   reporters: [
-    'default',
+    "default",
     [
-      'jest-html-reporter',
+      "jest-html-reporter",
       {
-        pageTitle: 'Test Report',
-        outputPath: './.reports/unit/test-report.html',
+        pageTitle: "Test Report",
+        outputPath: "./.reports/unit/test-report.html",
         includeFailureMsg: true,
       },
     ],
   ],
 
   // The test environment that will be used for testing
-  testEnvironment: 'jsdom',
+  testEnvironment: "jsdom",
 };
 
 const utilsJestConfig = {
   ...baseJestConfig,
 
-  testEnvironment: 'node',
+  testEnvironment: "node",
 
   coveragePathIgnorePatterns: [
     ...(baseJestConfig.coveragePathIgnorePatterns ?? []),
-    'cli/index.ts',
-    'suppliers-repo-factory.ts',
+    "cli/index.ts",
+    "suppliers-repo-factory.ts",
   ],
 };
 

scripts/utilities/supplier-data/src/cli/index.ts

@@ -1,11 +1,9 @@
 import { hideBin } from "yargs/helpers";
-import yargs from 'yargs';
+import yargs from "yargs";
 import { LetterStatusType } from "@internal/datastore/src/types";
-import { randomUUID } from "crypto";
+import { randomUUID } from "node:crypto";
 import { createSupplierRepository } from "../infrastructure/suppliers-repo-factory";
 
-
-
 async function main() {
   await yargs(hideBin(process.argv))
     .command(
@@ -16,35 +14,32 @@ async function main() {
           type: "string",
           demandOption: true,
         },
-        "id": {
+        id: {
           type: "string",
           demandOption: true,
         },
-        "name": {
+        name: {
           type: "string",
           demandOption: true,
         },
-        "apimId": {
+        apimId: {
           type: "string",
           demandOption: true,
         },
         status: {
           type: "string",
           demandOption: true,
-          choices: [
-            "ENABLED",
-            "DISABLED"
-          ],
+          choices: ["ENABLED", "DISABLED"],
         },
       },
       async (argv) => {
         // parse args
-        const id = argv.id;
-        const name = argv.name;
-        const apimId = argv.apimId;
+        const { id } = argv;
+        const { name } = argv;
+        const { apimId } = argv;
         const status = argv.status as "ENABLED" | "DISABLED";
 
-        const environment = argv.environment;
+        const { environment } = argv;
 
         const supplierRepository = createSupplierRepository(environment);
 
@@ -56,13 +51,13 @@ async function main() {
         });
 
         console.log(`PUT successful ${JSON.stringify(putResult)}`);
-      }
+      },
     )
     .command(
       "get-supplier-by-id",
       "Get a supplier by their Supplier ID",
       {
-        "id": {
+        id: {
           type: "string",
           demandOption: true,
         },
@@ -72,9 +67,8 @@ async function main() {
         },
       },
       async (argv) => {
-
-        const id = argv.id;
-        const environment = argv.environment;
+        const { id } = argv;
+        const { environment } = argv;
 
         const supplierRepository = createSupplierRepository(environment);
 
@@ -87,7 +81,7 @@ async function main() {
       "get-supplier-by-apim-id",
       "Get a supplier by their APIM ID",
       {
-        "apimId": {
+        apimId: {
           type: "string",
           demandOption: true,
         },
@@ -97,9 +91,8 @@ async function main() {
         },
       },
       async (argv) => {
-
-        const apimId = argv.apimId;
-        const environment = argv.environment;
+        const { apimId } = argv;
+        const { environment } = argv;
 
         const supplierRepository = createSupplierRepository(environment);
 
@@ -113,8 +106,8 @@ async function main() {
 }
 
 if (require.main === module) {
-  main().catch((err) => {
-    console.error(err);
+  main().catch((error) => {
+    console.error(error);
     process.exitCode = 1;
   });
 }

scripts/utilities/supplier-data/src/infrastructure/suppliers-repo-factory.ts

@@ -1,9 +1,11 @@
-import { DynamoDBClient } from '@aws-sdk/client-dynamodb';
-import { DynamoDBDocumentClient } from '@aws-sdk/lib-dynamodb';
-import { pino } from 'pino';
-import { SupplierRepository } from '@internal/datastore';
+import { DynamoDBClient } from "@aws-sdk/client-dynamodb";
+import { DynamoDBDocumentClient } from "@aws-sdk/lib-dynamodb";
+import { pino } from "pino";
+import { SupplierRepository } from "@internal/datastore";
 
-export function createSupplierRepository(environment: string): SupplierRepository {
+export function createSupplierRepository(
+  environment: string,
+): SupplierRepository {
   const ddbClient = new DynamoDBClient({});
   const docClient = DynamoDBDocumentClient.from(ddbClient);
   const log = pino();