Skip to content

Commit 5d99b0b

Browse files
committed
Remove generated files and check for up-to-date generation
1 parent 61f8d3a commit 5d99b0b

19 files changed

+35
-4559
lines changed

.github/workflows/pr_closed.yaml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,10 @@ jobs:
7777
- name: Checkout code
7878
uses: actions/[email protected]
7979

80-
- name: Use Node.js 20
80+
- name: Setup NodeJS
8181
uses: actions/setup-node@v4
8282
with:
83-
node-version: '20.18.2'
84-
registry-url: 'https://npm.pkg.github.com'
83+
node-version: ${{ inputs.nodejs_version }}
8584

8685
- name: check if local version differs from latest published version
8786
id: check-version
@@ -111,6 +110,10 @@ jobs:
111110
steps:
112111
- name: "Checkout code"
113112
uses: actions/[email protected]
113+
- name: Setup NodeJS
114+
uses: actions/setup-node@v4
115+
with:
116+
node-version: ${{ inputs.nodejs_version }}
114117
- name: "Install dependencies"
115118
run: npm ci
116119
- name: "Run provider contract tests"
@@ -133,10 +136,10 @@ jobs:
133136
- name: Checkout code
134137
uses: actions/[email protected]
135138

136-
- name: Use Node.js 20
139+
- name: Setup NodeJS
137140
uses: actions/setup-node@v4
138141
with:
139-
node-version: '20.18.2'
142+
node-version: ${{ inputs.nodejs_version }}
140143
registry-url: 'https://npm.pkg.github.com'
141144

142145
- name: Install dependencies

.github/workflows/stage-1-commit.yaml

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -237,33 +237,33 @@ jobs:
237237
echo "Detected package version $version in main branch"
238238
echo "main_version=$version" >> $GITHUB_OUTPUT
239239
240-
check-schemas-generated:
241-
name: Check event schemas have been regenerated
242-
needs: detect-event-schema-package-changes
243-
if: needs.detect-event-schema-package-changes.outputs.changed == 'true'
244-
runs-on: ubuntu-latest
245-
permissions:
246-
contents: read
247-
steps:
248-
- name: "Checkout code"
249-
uses: actions/checkout@v4
250-
251-
- name: "Cache node_modules"
252-
uses: actions/cache@v4
253-
with:
254-
path: |
255-
**/node_modules
256-
key: ${{ runner.os }}-node-${{ inputs.nodejs_version }}-${{ hashFiles('**/package-lock.json') }}
257-
restore-keys: |
258-
${{ runner.os }}-node-${{ inputs.nodejs_version }}-
259-
260-
- name: "Re-generate schemas"
261-
run: |
262-
npm ci
263-
npm --workspace internal/events run gen:jsonschema
264-
265-
- name: Check for schema changes
266-
run: git diff --quiet internal/events/schemas
240+
# check-schemas-generated:
241+
# name: Check event schemas have been regenerated
242+
# needs: detect-event-schema-package-changes
243+
# if: needs.detect-event-schema-package-changes.outputs.changed == 'true'
244+
# runs-on: ubuntu-latest
245+
# permissions:
246+
# contents: read
247+
# steps:
248+
# - name: "Checkout code"
249+
# uses: actions/checkout@v4
250+
#
251+
# - name: "Cache node_modules"
252+
# uses: actions/cache@v4
253+
# with:
254+
# path: |
255+
# **/node_modules
256+
# key: ${{ runner.os }}-node-${{ inputs.nodejs_version }}-${{ hashFiles('**/package-lock.json') }}
257+
# restore-keys: |
258+
# ${{ runner.os }}-node-${{ inputs.nodejs_version }}-
259+
#
260+
# - name: "Re-generate schemas"
261+
# run: |
262+
# npm ci
263+
# npm --workspace internal/events run gen:jsonschema
264+
#
265+
# - name: Check for schema changes
266+
# run: git diff --quiet internal/events/schemas
267267

268268
check-schema-version-change:
269269
name: Check event schema version has been updated

internal/events/schemas/domain/.gitkeep

Whitespace-only changes.

internal/events/schemas/domain/letter.schema.json

Lines changed: 0 additions & 113 deletions
This file was deleted.

internal/events/schemas/domain/mi.schema.json

Lines changed: 0 additions & 45 deletions
This file was deleted.

internal/events/schemas/events/.gitkeep

Whitespace-only changes.

0 commit comments

Comments
 (0)