logging for investigation

Author: nhsd-david-wass

lambdas/mi-updates-transformer/src/__tests__/mi-updates-transformer.test.ts

@@ -70,7 +70,7 @@ describe("mi-updates-transformer Lambda", () => {
     const miEvents = generateMIEvents(1);
     const expectedEntries = [
       expect.objectContaining({
-        Message: JSON.stringify(mapMIToCloudEvent(miEvents[0])),
+        Message: JSON.stringify(mapMIToCloudEvent(miEvents[0], mockedDeps)),
       }),
     ];
 
@@ -95,7 +95,7 @@ describe("mi-updates-transformer Lambda", () => {
     const miEvents = generateMIEvents(10);
     const expectedEntries = miEvents.map((miEvent) =>
       expect.objectContaining({
-        Message: JSON.stringify(mapMIToCloudEvent(miEvent)),
+        Message: JSON.stringify(mapMIToCloudEvent(miEvent, mockedDeps)),
       }),
     );
 
@@ -121,17 +121,17 @@ describe("mi-updates-transformer Lambda", () => {
     const expectedEntries = [
       miEvents.slice(0, 10).map((miEvent) =>
         expect.objectContaining({
-          Message: JSON.stringify(mapMIToCloudEvent(miEvent)),
+          Message: JSON.stringify(mapMIToCloudEvent(miEvent, mockedDeps)),
         }),
       ),
       miEvents.slice(10, 20).map((miEvent) =>
         expect.objectContaining({
-          Message: JSON.stringify(mapMIToCloudEvent(miEvent)),
+          Message: JSON.stringify(mapMIToCloudEvent(miEvent, mockedDeps)),
         }),
       ),
       miEvents.slice(20).map((miEvent) =>
         expect.objectContaining({
-          Message: JSON.stringify(mapMIToCloudEvent(miEvent)),
+          Message: JSON.stringify(mapMIToCloudEvent(miEvent, mockedDeps)),
         }),
       ),
     ];

lambdas/mi-updates-transformer/src/mappers/__tests__/mi-mapper.test.ts

@@ -1,8 +1,20 @@
+import { SNSClient } from "@aws-sdk/client-sns";
+import * as pino from "pino";
 import { $MISubmittedEvent } from "@nhsdigital/nhs-notify-event-schemas-supplier-api/src";
 import { MI } from "@internal/datastore";
 import { mapMIToCloudEvent } from "../mi-mapper";
+import { EnvVars } from "../../env";
+import { Deps } from "../../deps";
 
 describe("mi-mapper", () => {
+  const mockedDeps: jest.Mocked<Deps> = {
+    snsClient: { send: jest.fn() } as unknown as SNSClient,
+    logger: { info: jest.fn(), error: jest.fn() } as unknown as pino.Logger,
+    env: {
+      EVENTPUB_SNS_TOPIC_ARN: "arn:aws:sns:region:account:topic",
+    } as unknown as EnvVars,
+  } as Deps;
+
   it("maps an MI to an MI event", async () => {
     const mi: MI = {
       id: "id1",
@@ -18,7 +30,7 @@ describe("mi-mapper", () => {
       stockRemaining: 500,
     };
     jest.useFakeTimers().setSystemTime(new Date("2025-11-24T15:55:18Z"));
-    const event = mapMIToCloudEvent(mi);
+    const event = mapMIToCloudEvent(mi, mockedDeps);
 
     // Check it conforms to the MI event schema - parse will throw an error if not
     $MISubmittedEvent.parse(event);

lambdas/mi-updates-transformer/src/mappers/mi-mapper.ts

@@ -1,12 +1,15 @@
 import { MI } from "@internal/datastore";
 import { MISubmittedEvent } from "@nhsdigital/nhs-notify-event-schemas-supplier-api/src";
 import { randomBytes, randomUUID } from "node:crypto";
+import { Deps } from "../deps";
 
-export function mapMIToCloudEvent(mi: MI): MISubmittedEvent {
+export function mapMIToCloudEvent(mi: MI, deps: Deps): MISubmittedEvent {
   const now = new Date().toISOString();
   const eventId = randomUUID();
   const dataschemaversion = "1.1.5";
 
+  deps.logger.info({ description: "Mapping MI to CloudEvent", mi, eventId });
+
   return {
     specversion: "1.0",
     id: eventId,

lambdas/mi-updates-transformer/src/mi-updates-transformer.ts

@@ -38,9 +38,9 @@ export function createHandler(deps: Deps): Handler<KinesisStreamEvent> {
   return async (streamEvent: KinesisStreamEvent) => {
     deps.logger.info({ description: "Received event", streamEvent });
 
-    const cloudEvents: MISubmittedEvent[] = streamEvent.Records.map((record) =>
-      extractPayload(record, deps),
-    ).map((element) => mapMIToCloudEvent(element));
+    const cloudEvents: MISubmittedEvent[] = streamEvent.Records
+      .map((record) => extractPayload(record, deps))
+      .map((payload) => mapMIToCloudEvent(payload, deps));
 
     for (const batch of generateBatches(cloudEvents)) {
       await deps.snsClient.send(