Skip to content

Commit 5e7d00c

Browse files
committed
Revert premature change to use lower case
1 parent e033810 commit 5e7d00c

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

internal/events/src/events/letter-events.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const $LetterEvent = EventEnvelope(
1313
"letter",
1414
"letter",
1515
$Letter,
16-
$LetterStatus.options.map((status) => status.toLowerCase()),
16+
$LetterStatus.options,
1717
"letter-origin",
1818
).meta({
1919
title: `letter.* Event`,
@@ -27,13 +27,13 @@ export type LetterEvent = z.infer<typeof $LetterEvent>;
2727
*/
2828
const eventSchema = (status: LetterStatus) =>
2929
EventEnvelope(
30-
`letter.${status.toLowerCase()}`,
30+
`letter.${status}`,
3131
"letter",
3232
$Letter,
3333
[status],
3434
"letter-origin",
3535
).meta({
36-
title: `letter.${status.toLowerCase()} Event`,
36+
title: `letter.${status} Event`,
3737
description: `Event schema for letter status change to ${status}`,
3838
});
3939

lambdas/letter-updates-transformer/src/mappers/__tests__/letter-mapper.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ describe("letter-mapper", () => {
1919

2020
// Check it conforms to the letter event schema - parse will throw an error if not
2121
$LetterEvent.parse(event);
22-
expect(event.type).toBe("uk.nhs.notify.supplier-api.letter.printed.v1");
22+
expect(event.type).toBe("uk.nhs.notify.supplier-api.letter.PRINTED.v1");
2323
expect(event.dataschema).toBe(
24-
`https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.printed.${event.dataschemaversion}.schema.json`,
24+
`https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.PRINTED.${event.dataschemaversion}.schema.json`,
2525
);
2626
expect(event.dataschemaversion).toBe("1.0.4");
2727
expect(event.subject).toBe("letter-origin/supplier-api/letter/id1");

lambdas/letter-updates-transformer/src/mappers/letter-mapper.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ export default function mapLetterToCloudEvent(
1212
return {
1313
specversion: "1.0",
1414
id: eventId,
15-
type: `uk.nhs.notify.supplier-api.letter.${letter.status.toLowerCase()}.v1`,
15+
type: `uk.nhs.notify.supplier-api.letter.${letter.status}.v1`,
1616
plane: "data",
17-
dataschema: `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.${letter.status.toLowerCase()}.${dataschemaversion}.schema.json`,
17+
dataschema: `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.${letter.status}.${dataschemaversion}.schema.json`,
1818
dataschemaversion,
1919
source: "/data-plane/supplier-api/letters",
2020
subject: `letter-origin/supplier-api/letter/${letter.id}`,

0 commit comments

Comments
 (0)