Address review comments

Author: stevebux

infrastructure/terraform/components/api/README.md

@@ -45,7 +45,6 @@ No requirements.
 | <a name="module_kms"></a> [kms](#module\_kms) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-kms.zip | n/a |
 | <a name="module_letter_status_update"></a> [letter\_status\_update](#module\_letter\_status\_update) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
 | <a name="module_letter_status_updates_queue"></a> [letter\_status\_updates\_queue](#module\_letter\_status\_updates\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-sqs.zip | n/a |
-| <a name="module_letter_stream_forwarder"></a> [letter\_stream\_forwarder](#module\_letter\_stream\_forwarder) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_letter_updates_transformer"></a> [letter\_updates\_transformer](#module\_letter\_updates\_transformer) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_logging_bucket"></a> [logging\_bucket](#module\_logging\_bucket) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
 | <a name="module_patch_letter"></a> [patch\_letter](#module\_patch\_letter) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |

infrastructure/terraform/components/api/module_lambda_letter_stream_forwarder.tf

@@ -26,7 +26,6 @@ describe("MI event validations", () => {
         datacontenttype: "application/json",
         dataschema:
           "https://notify.nhs.uk/cloudevents/schemas/supplier-api/mi.SUBMITTED.1.0.0.schema.json",
-        dataschemaversion: "1.0.0",
         subject: "mi/mi-test-001",
         data: expect.objectContaining({
           id: "mi-test-001",

internal/events/src/events/__tests__/mi-events.test.ts

@@ -13,7 +13,7 @@ export const $LetterEvent = EventEnvelope(
   "letter",
   "letter",
   $Letter,
-  $LetterStatus.options,
+  $LetterStatus.options.map((status) => status.toLowerCase()),
   "letter-origin",
 ).meta({
   title: `letter.* Event`,
@@ -27,13 +27,13 @@ export type LetterEvent = z.infer<typeof $LetterEvent>;
  */
 const eventSchema = (status: LetterStatus) =>
   EventEnvelope(
-    `letter.${status}`,
+    `letter.${status.toLowerCase()}`,
     "letter",
     $Letter,
     [status],
     "letter-origin",
   ).meta({
-    title: `letter.${status} Event`,
+    title: `letter.${status.toLowerCase()} Event`,
     description: `Event schema for letter status change to ${status}`,
   });