CCM-13611: Allow access to Core PDF pipeline bucket for getletterdata lambda

Author: sidnhs

infrastructure/terraform/components/api/event_source_mapping_letter_updates.tf

@@ -1,11 +1,11 @@
 resource "aws_lambda_event_source_mapping" "letter_updates_transformer_kinesis" {
-  event_source_arn                     = aws_kinesis_stream.letter_change_stream.arn
-  function_name                        = module.letter_updates_transformer.function_arn
-  starting_position                    = "LATEST"
-  batch_size                           = 10
-  maximum_batching_window_in_seconds   = 1
+  event_source_arn                   = aws_kinesis_stream.letter_change_stream.arn
+  function_name                      = module.letter_updates_transformer.function_arn
+  starting_position                  = "LATEST"
+  batch_size                         = 10
+  maximum_batching_window_in_seconds = 1
 
   depends_on = [
-    module.letter_updates_transformer    # ensures updates transformer exists
+    module.letter_updates_transformer # ensures updates transformer exists
   ]
 }

infrastructure/terraform/components/api/locals.tf

@@ -29,6 +29,6 @@ locals {
     DOWNLOAD_URL_TTL_SECONDS = 60
   }
 
-core_pdf_bucket_arn = "arn:aws:s3:::comms-${var.core_account_id}-eu-west-2-${var.core_environment}-api-stg-pdf-pipeline"
-core_s3_kms_key_alias_name = "alias/comms-${var.core_environment}-api-s3"
+  core_pdf_bucket_arn        = "arn:aws:s3:::comms-${var.core_account_id}-eu-west-2-${var.core_environment}-api-stg-pdf-pipeline"
+  core_s3_kms_key_alias_name = "alias/comms-${var.core_environment}-api-s3"
 }

infrastructure/terraform/components/api/module_lambda_get_letter_data.tf

@@ -71,12 +71,12 @@ data "aws_iam_policy_document" "get_letter_data_lambda" {
   statement {
     sid = "S3ListBucketForPresign"
     actions = [
-    "s3:ListBucket"
+      "s3:ListBucket"
     ]
     resources = [
       module.s3bucket_test_letters.arn,
       local.core_pdf_bucket_arn
-      ]
+    ]
   }
 
   statement {
@@ -88,7 +88,7 @@ data "aws_iam_policy_document" "get_letter_data_lambda" {
     resources = [
       "${module.s3bucket_test_letters.arn}/*",
       "${local.core_pdf_bucket_arn}/*",
-      ]
+    ]
   }
 
   statement {
@@ -102,9 +102,9 @@ data "aws_iam_policy_document" "get_letter_data_lambda" {
       "arn:aws:kms:${var.region}:${var.core_account_id}:key/*"
     ]
     condition {
-      test = "ForAnyValue:StringEquals"
+      test     = "ForAnyValue:StringEquals"
       variable = "kms:ResourceAliases"
-      values = [local.core_s3_kms_key_alias_name]
+      values   = [local.core_s3_kms_key_alias_name]
     }
   }
 }

infrastructure/terraform/components/api/variables.tf

@@ -142,7 +142,7 @@ variable "core_account_id" {
 }
 
 variable "core_environment" {
-  type       = string
+  type        = string
   description = "Environment of Core"
   default     = "prod"
 }