Revert "Merge remote-tracking branch 'origin/main' into feature/CCM-13009_correct-doc-links"

This reverts commit 000a490, reversing
changes made to 2362ef7.

Author: masl2

.github/actions/acceptance-tests/action.yaml

@@ -35,10 +35,6 @@ on:
         required: true
         type: string
 
-permissions:
-  id-token: write
-  contents: read
-
 jobs:
 #  environment-set-up:
 #    name: "Environment set up"

.github/actions/test-types.json

@@ -11,7 +11,6 @@ No requirements.
 |------|-------------|------|---------|:--------:|
 | <a name="input_aws_account_id"></a> [aws\_account\_id](#input\_aws\_account\_id) | The AWS Account ID (numeric) | `string` | n/a | yes |
 | <a name="input_ca_pem_filename"></a> [ca\_pem\_filename](#input\_ca\_pem\_filename) | Filename for the CA truststore file within the s3 bucket | `string` | `null` | no |
-| <a name="input_commit_id"></a> [commit\_id](#input\_commit\_id) | The commit to deploy. Must be in the tree for branch\_name | `string` | `"HEAD"` | no |
 | <a name="input_component"></a> [component](#input\_component) | The variable encapsulating the name of this component | `string` | `"supapi"` | no |
 | <a name="input_default_tags"></a> [default\_tags](#input\_default\_tags) | A map of default tags to apply to all taggable resources within the component | `map(string)` | `{}` | no |
 | <a name="input_enable_backups"></a> [enable\_backups](#input\_enable\_backups) | Enable backups | `bool` | `false` | no |
@@ -60,7 +59,6 @@ No requirements.
 | Name | Description |
 |------|-------------|
 | <a name="output_api_urll"></a> [api\_urll](#output\_api\_urll) | n/a |
-| <a name="output_deployment"></a> [deployment](#output\_deployment) | Deployment details used for post-deployment scripts |
 <!-- vale on -->
 <!-- markdownlint-enable -->
 <!-- END_TF_DOCS -->

.github/workflows/stage-4-acceptance.yaml

@@ -1,16 +1,3 @@
 output "api_urll" {
   value = aws_api_gateway_stage.main.invoke_url
 }
-
-output "deployment" {
-  description = "Deployment details used for post-deployment scripts"
-  value = {
-    aws_region     = var.region
-    aws_account_id = var.aws_account_id
-    project        = var.project
-    environment    = var.environment
-    group          = var.group
-    component      = var.component
-    commit_id      = var.commit_id
-  }
-}

infrastructure/terraform/components/api/README.md

@@ -51,46 +51,16 @@ variable "default_tags" {
 # Variables specific to the component
 ##
 
-variable "ca_pem_filename" {
-  type        = string
-  description = "Filename for the CA truststore file within the s3 bucket"
-  default     = null
-}
-
-variable "commit_id" {
-  type        = string
-  description = "The commit to deploy. Must be in the tree for branch_name"
-  default     = "HEAD"
-}
-
-variable "enable_backups" {
-  type        = bool
-  description = "Enable backups"
-  default     = false
-}
-
-variable "force_destroy" {
-  type        = bool
-  description = "Flag to force deletion of S3 buckets"
-  default     = false
-}
-
-variable "force_lambda_code_deploy" {
-  type        = bool
-  description = "If the lambda package in s3 has the same commit id tag as the terraform build branch, the lambda will not update automatically. Set to True if making changes to Lambda code from on the same commit for example during development"
-  default     = false
-}
-
 variable "kms_deletion_window" {
   type        = string
   description = "When a kms key is deleted, how long should it wait in the pending deletion state?"
   default     = "30"
 }
 
-variable "letter_table_ttl_hours" {
+variable "log_retention_in_days" {
   type        = number
-  description = "Number of hours to set as TTL on letters table"
-  default     = 24
+  description = "The retention period in days for the Cloudwatch Logs events to be retained, default of 0 is indefinite"
+  default     = 0
 }
 
 variable "log_level" {
@@ -99,24 +69,12 @@ variable "log_level" {
   default     = "INFO"
 }
 
-variable "log_retention_in_days" {
-  type        = number
-  description = "The retention period in days for the Cloudwatch Logs events to be retained, default of 0 is indefinite"
-  default     = 0
-}
-
-variable "manually_configure_mtls_truststore" {
+variable "force_lambda_code_deploy" {
   type        = bool
-  description = "Manually manage the truststore used for API Gateway mTLS (e.g. for prod environment)"
+  description = "If the lambda package in s3 has the same commit id tag as the terraform build branch, the lambda will not update automatically. Set to True if making changes to Lambda code from on the same commit for example during development"
   default     = false
 }
 
-variable "max_get_limit" {
-  type        = number
-  description = "Default limit to apply to GET requests that support pagination"
-  default     = 2500
-}
-
 variable "parent_acct_environment" {
   type        = string
   description = "Name of the environment responsible for the acct resources used, affects things like DNS zone. Useful for named dev environments"