Move where logging takes place

Author: stevebux

lambdas/api-handler/src/handlers/patch-letter.ts

@@ -73,12 +73,6 @@ export default function createPatchLetterHandler(
         commonIds.value.correlationId,
         deps,
       );
-      deps.logger.info({
-        description: "Enqueued letter update requests",
-        supplierId: commonIds.value.supplierId,
-        letterId,
-        correlationId: commonIds.value.correlationId,
-      });
 
       return {
         statusCode: 202,

lambdas/api-handler/src/handlers/post-letters.ts

@@ -77,13 +77,6 @@ export default function createPostLettersHandler(
         deps,
       );
 
-      deps.logger.info({
-        description: "Enqueued letter update requests",
-        supplierId: commonIds.value.supplierId,
-        letterIds: postLettersRequest.data.map((letter) => letter.id),
-        correlationId: commonIds.value.correlationId,
-      });
-
       return {
         statusCode: 202,
         body: "",

lambdas/api-handler/src/services/letter-operations.ts

@@ -123,6 +123,13 @@ export async function enqueueLetterUpdateRequests(
 
         try {
           const result = await deps.sqsClient.send(cmd);
+          if (result.Successful && result.Successful.length > 0) {
+            deps.logger.info({
+              description: "Enqueued letter updates",
+              correlationId,
+              messageIds: result.Successful.map((entry) => entry.Id),
+            });
+          }
           if (result.Failed && result.Failed.length > 0) {
             deps.logger.error({
               failed: result.Failed,