lambda changes

Author: stevebux

lambdas/letter-stream-forwarder/src/__tests__/letter-stream-forwarder.test.ts

@@ -26,7 +26,7 @@ describe('letter-stream-forwarder Lambda', () => {
           eventName: 'MODIFY',
           dynamodb: {
             Keys: { id: { S: '123' } },
-            OldImage: { status: { S: 'PENDING' } },
+            OldImage: { status: { S: 'PENDING' }, id: { S: '123' } },
             NewImage: { status: { S: 'ACCEPTED' }, id: { S: '123' } },
           },
         },
@@ -46,14 +46,70 @@ describe('letter-stream-forwarder Lambda', () => {
     );
   });
 
-  it('does not forward if status did not change', async () => {
+
+  it('forwards to Kinesis if a reason code is added', async () => {
+    const event: DynamoDBStreamEvent = {
+      Records: [
+        {
+          eventName: 'MODIFY',
+          dynamodb: {
+            Keys: { id: { S: '123' } },
+            OldImage: { status: { S: 'PENDING' }, id: { S: '123' } },
+            NewImage: { status: { S: 'PENDING' }, id: { S: '123' }, reasonCode: {S: 'r1'} },
+          },
+        },
+      ],
+    };
+
+    const handler = createHandler(mockedDeps);
+    await handler(event, mockDeep<Context>(), jest.fn());
+
+    expect(mockedDeps.kinesisClient.send).toHaveBeenCalledWith(
+      expect.objectContaining({
+        input: expect.objectContaining({
+          StreamName: 'test-stream',
+          PartitionKey: '123',
+        }),
+      })
+    );
+  });
+
+
+  it('forwards to Kinesis if a reason code is changed', async () => {
+    const event: DynamoDBStreamEvent = {
+      Records: [
+        {
+          eventName: 'MODIFY',
+          dynamodb: {
+            Keys: { id: { S: '123' } },
+            OldImage: { status: { S: 'PENDING' }, id: { S: '123' }, reasonCode: {S: 'r1'} },
+            NewImage: { status: { S: 'PENDING' }, id: { S: '123' }, reasonCode: {S: 'r2'} },
+          },
+        },
+      ],
+    };
+
+    const handler = createHandler(mockedDeps);
+    await handler(event, mockDeep<Context>(), jest.fn());
+
+    expect(mockedDeps.kinesisClient.send).toHaveBeenCalledWith(
+      expect.objectContaining({
+        input: expect.objectContaining({
+          StreamName: 'test-stream',
+          PartitionKey: '123',
+        }),
+      })
+    );
+  });
+
+  it('does not forward if neither status nor reason code changed', async () => {
     const event: DynamoDBStreamEvent = {
       Records: [
         {
           eventName: 'MODIFY',
           dynamodb: {
             Keys: { id: { S: '123' } },
-            OldImage: { status: { S: 'PENDING' } },
+            OldImage: { status: { S: 'PENDING' }, id: { S: '123' } },
             NewImage: { status: { S: 'PENDING' }, id: { S: '123' } },
           },
         },

lambdas/letter-stream-forwarder/src/letter-stream-forwarder.ts

@@ -1,5 +1,5 @@
 import { LetterBase } from "@internal/datastore";
-import { DynamoDBStreamEvent, Handler } from "aws-lambda";
+import { DynamoDBStreamEvent, Handler, DynamoDBRecord, AttributeValue } from "aws-lambda";
 import { PutRecordCommand } from "@aws-sdk/client-kinesis";
 import { Deps } from "./deps";
 import { unmarshall } from "@aws-sdk/util-dynamodb";
@@ -8,11 +8,7 @@ export function createHandler(deps: Deps): Handler<DynamoDBStreamEvent> {
   return async (event: DynamoDBStreamEvent): Promise<void> => {
     const statusChanges = event.Records
       .filter(record => record.eventName === "MODIFY")
-      .filter(record => {
-        const oldStatus = record.dynamodb?.OldImage?.status?.S;
-        const newStatus = record.dynamodb?.NewImage?.status?.S;
-        return oldStatus !== newStatus;
-      });
+      .filter(record => isChanged(record, 'status') || isChanged(record, 'reasonCode'));
 
     for (const record of statusChanges) {
       const newImage = record.dynamodb?.NewImage!;
@@ -24,4 +20,10 @@ export function createHandler(deps: Deps): Handler<DynamoDBStreamEvent> {
       }));
     }
   };
+
+  function isChanged(record: DynamoDBRecord, property: string): boolean {
+    const oldValue = record.dynamodb?.OldImage![property];
+    const newValue = record.dynamodb?.NewImage![property];
+      return oldValue?.S !== newValue?.S;
+  }
 }