copy fixes from base commit

Author: nhsd-david-wass

infrastructure/terraform/components/api/module_lambda_mi_stream_forwarder.tf

@@ -36,7 +36,7 @@ module "mi_stream_forwarder" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = merge(local.common_lambda_env_vars, {
-    MI_CHANGE_STREAM_NAME = "mi_change_stream"
+    MI_CHANGE_STREAM_ARN = "${aws_kinesis_stream.mi_change_stream.arn}"
   })
 }
 
@@ -63,7 +63,8 @@ data "aws_iam_policy_document" "mi_stream_forwarder_lambda" {
     effect = "Allow"
 
     actions = [
-      "kinesis:*"
+      "kinesis:DescribeStream",
+      "kinesis:PutRecord",
     ]
 
     resources = [

infrastructure/terraform/components/api/module_lambda_mi_updates_transformer.tf

@@ -36,7 +36,7 @@ module "mi_updates_transformer" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = merge(local.common_lambda_env_vars, {
-    EVENTPUB_SNS_TOPIC_ARN = module.eventpub.sns_topic.arn
+    EVENTPUB_SNS_TOPIC_ARN = "${module.eventpub.sns_topic.arn}"
   })
 }
 

lambdas/mi-stream-forwarder/src/__tests__/mi-stream-forwarder.test.ts

@@ -11,7 +11,7 @@ describe('mi-stream-forwarder Lambda', () => {
   const mockedDeps: jest.Mocked<Deps> = {
     kinesisClient: { send: jest.fn()} as unknown as KinesisClient,
     env: {
-      MI_CHANGE_STREAM_NAME: "test-stream",
+      MI_CHANGE_STREAM_ARN: "test-stream",
     } as unknown as EnvVars
   } as Deps;
 
@@ -36,7 +36,7 @@ describe('mi-stream-forwarder Lambda', () => {
     expect(mockedDeps.kinesisClient.send).toHaveBeenCalledWith(
       expect.objectContaining({
         input: expect.objectContaining({
-          StreamName: 'test-stream',
+          StreamARN: 'test-stream',
           PartitionKey: 'mi-123',
         }),
       })

lambdas/mi-stream-forwarder/src/env.ts

@@ -1,7 +1,7 @@
 import { z } from 'zod';
 
 const EnvVarsSchema = z.object({
-  MI_CHANGE_STREAM_NAME: z.string(),
+  MI_CHANGE_STREAM_ARN: z.string(),
 });
 
 export type EnvVars = z.infer<typeof EnvVarsSchema>;

lambdas/mi-stream-forwarder/src/mi-stream-forwarder.ts

@@ -13,7 +13,7 @@ export function createHandler(deps: Deps): Handler<DynamoDBStreamEvent> {
       const newImage = record.dynamodb?.NewImage!;
       const miRecord = unmarshall(newImage as any) as MI;
       await deps.kinesisClient.send(new PutRecordCommand({
-        StreamName: deps.env.MI_CHANGE_STREAM_NAME,
+        StreamARN: deps.env.MI_CHANGE_STREAM_ARN,
         PartitionKey: miRecord.id,
         Data: Buffer.from(JSON.stringify(miRecord)),
       }));

lambdas/mi-updates-transformer/src/__tests__/mi-updates-transformer.test.ts

@@ -22,7 +22,7 @@ describe('mi-updates-transformer Lambda', () => {
   snsClient: { send: jest.fn()} as unknown as SNSClient,
   logger: { info: jest.fn(), error: jest.fn() } as unknown as pino.Logger,
     env: {
-      EVENT_PUB_SNS_TOPIC_ARN: 'arn:aws:sns:region:account:topic',
+      EVENTPUB_SNS_TOPIC_ARN: 'arn:aws:sns:region:account:topic',
     } as unknown as EnvVars
   } as Deps;
 

lambdas/mi-updates-transformer/src/env.ts

@@ -1,7 +1,7 @@
 import {z} from 'zod';
 
 const EnvVarsSchema = z.object({
-  EVENT_PUB_SNS_TOPIC_ARN: z.string(),
+  EVENTPUB_SNS_TOPIC_ARN: z.string(),
 });
 
 export type EnvVars = z.infer<typeof EnvVarsSchema>;

lambdas/mi-updates-transformer/src/mi-updates-transformer.ts

@@ -22,7 +22,7 @@ export function createHandler(deps: Deps): Handler<KinesisStreamEvent> {
 
     for (let batch of generateBatches(cloudEvents)) {
       await deps.snsClient.send(new PublishBatchCommand({
-        TopicArn: deps.env.EVENT_PUB_SNS_TOPIC_ARN,
+        TopicArn: deps.env.EVENTPUB_SNS_TOPIC_ARN,
         PublishBatchRequestEntries: batch.map(buildMessage),
       }));
     }