Fix sonar attempt

Author: francisco-videira-nhs

lambdas/api-handler/src/config/deps.ts

@@ -21,7 +21,7 @@ function createLetterRepository(log: pino.Logger, lambdaEnv: LambdaEnv): LetterR
   const docClient = DynamoDBDocumentClient.from(ddbClient);
   const config = {
     lettersTableName: lambdaEnv.LETTERS_TABLE_NAME,
-    ttlHours: parseInt(lambdaEnv.LETTER_TTL_HOURS, BASE_TEN),
+    ttlHours: Number.parseInt(lambdaEnv.LETTER_TTL_HOURS, BASE_TEN),
   };
 
   return new LetterRepository(docClient, log, config);

lambdas/api-handler/src/handlers/get-letter-data.ts

@@ -10,7 +10,7 @@ const deps: Deps = getDeps();
 
 export const getLetterData: APIGatewayProxyHandler = async (event) => {
 
-  let correlationId;
+  let correlationId: string | undefined;
 
   try {
     assertNotEmpty(event.headers, new Error("The request headers are empty"));

lambdas/api-handler/src/handlers/get-letters.ts

@@ -19,7 +19,8 @@ const status = "PENDING";
 export const getLetters: APIGatewayProxyHandler = async (event) => {
 
   const { maxLimit } = getMaxLimit();
-  let correlationId;
+
+  let correlationId: string | undefined;
 
   try {
     assertNotEmpty(event.headers, new Error("The request headers are empty"));

lambdas/api-handler/src/handlers/patch-letter.ts

@@ -12,7 +12,7 @@ const deps: Deps = getDeps();
 
 export const patchLetter: APIGatewayProxyHandler = async (event) => {
 
-  let correlationId;
+  let correlationId: string | undefined;
 
   try {
     assertNotEmpty(event.headers, new Error('The request headers are empty'));