swap partition and sort for letters

Author: masl2

infrastructure/terraform/components/api/ddb_table_letters.tf

@@ -2,8 +2,8 @@ resource "aws_dynamodb_table" "letters" {
   name         = "${local.csi}-letters"
   billing_mode = "PAY_PER_REQUEST"
 
-  hash_key  = "supplierId"
-  range_key = "id"
+  hash_key  = "id"
+  range_key = "supplierId"
 
   ttl {
     attribute_name = "ttl"

internal/datastore/src/__test__/db.ts

@@ -51,8 +51,8 @@ const createLetterTableCommand = new CreateTableCommand({
   TableName: "letters",
   BillingMode: "PAY_PER_REQUEST",
   KeySchema: [
-    { AttributeName: "supplierId", KeyType: "HASH" }, // Partition key
-    { AttributeName: "id", KeyType: "RANGE" }, // Sort key
+    { AttributeName: "id", KeyType: "HASH" }, // Partition key (letter ID)
+    { AttributeName: "supplierId", KeyType: "RANGE" }, // Sort key
   ],
   GlobalSecondaryIndexes: [
     {

internal/datastore/src/__test__/heathcheck.test.ts

@@ -24,6 +24,10 @@ describe("DBHealthcheck", () => {
     await deleteTables(db);
   });
 
+  afterAll(async () => {
+    await db.container.stop();
+  });
+
   it("passes when the database is available", async () => {
     const dbHealthCheck = new DBHealthcheck(db.docClient, db.config);
     await expect(dbHealthCheck.check()).resolves.not.toThrow();

internal/datastore/src/letter-repository.ts

@@ -109,8 +109,8 @@ export class LetterRepository {
       new GetCommand({
         TableName: this.config.lettersTableName,
         Key: {
-          supplierId,
           id: letterId,
+          supplierId,
         },
       }),
     );
@@ -194,8 +194,8 @@ export class LetterRepository {
         new UpdateCommand({
           TableName: this.config.lettersTableName,
           Key: {
-            supplierId: letterToUpdate.supplierId,
             id: letterToUpdate.id,
+            supplierId: letterToUpdate.supplierId,
           },
           UpdateExpression: updateExpression,
           ConditionExpression: "attribute_exists(id)", // Ensure letter exists