allocate lambda

Author: nhsd-david-wass

infrastructure/terraform/components/api/lambda_event_source_mapping_allocate_letters.tf

@@ -0,0 +1,9 @@
+resource "aws_lambda_event_source_mapping" "allocate_letter" {
+  event_source_arn                   = module.sqs_letter_updates.sqs_queue_arn
+  function_name                      = module.allocate_letter.function_name
+  batch_size                         = 10
+  maximum_batching_window_in_seconds = 5
+  function_response_types = [
+    "ReportBatchItemFailures"
+  ]
+}

infrastructure/terraform/components/api/lambda_event_source_mapping_upsert_letter.tf

@@ -1,5 +1,5 @@
 resource "aws_lambda_event_source_mapping" "upsert_letter" {
-  event_source_arn                   = module.sqs_letter_updates.sqs_queue_arn
+  event_source_arn                   = module.sqs_allocated_letters.sqs_queue_arn
   function_name                      = module.upsert_letter.function_name
   batch_size                         = 10
   maximum_batching_window_in_seconds = 5

infrastructure/terraform/components/api/module_lambda_upsert_letter.tf

@@ -82,7 +82,7 @@ data "aws_iam_policy_document" "upsert_letter_lambda" {
     ]
 
     resources = [
-      module.sqs_letter_updates.sqs_queue_arn
+      module.sqs_allocated_letters.sqs_queue_arn
     ]
   }
 }

lambdas/allocate-letter/package.json

@@ -1,6 +1,7 @@
 {
   "dependencies": {
     "@aws-sdk/client-dynamodb": "^3.858.0",
+    "@aws-sdk/client-sqs": "^3.984.0",
     "@aws-sdk/lib-dynamodb": "^3.858.0",
     "@internal/datastore": "*",
     "@nhsdigital/nhs-notify-event-schemas-letter-rendering": "^2.0.1",

lambdas/allocate-letter/src/config/__tests__/deps.test.ts

@@ -33,21 +33,12 @@ describe("createDependenciesContainer", () => {
   test("constructs deps and wires repository config correctly", async () => {
     // get current mock instances
     const pinoMock = jest.requireMock("pino");
-    const { LetterRepository } = jest.requireMock("@internal/datastore");
 
     // eslint-disable-next-line @typescript-eslint/no-require-imports
     const { createDependenciesContainer } = require("../deps");
     const deps: Deps = createDependenciesContainer();
 
     expect(pinoMock.default).toHaveBeenCalledTimes(1);
-
-    expect(LetterRepository).toHaveBeenCalledTimes(1);
-    const letterRepoCtorArgs = LetterRepository.mock.calls[0];
-    expect(letterRepoCtorArgs[2]).toEqual({
-      lettersTableName: "LettersTable",
-      lettersTtlHours: 12_960,
-    });
-
     expect(deps.env).toEqual(env);
   });
 });

lambdas/allocate-letter/src/config/deps.ts

@@ -1,40 +1,17 @@
-import { DynamoDBClient } from "@aws-sdk/client-dynamodb";
-import { DynamoDBDocumentClient } from "@aws-sdk/lib-dynamodb";
 import { SQSClient } from "@aws-sdk/client-sqs";
 import pino from "pino";
-import { LetterRepository } from "@internal/datastore";
 import { EnvVars, envVars } from "./env";
 
 export type Deps = {
-  letterRepo: LetterRepository;
   logger: pino.Logger;
   env: EnvVars;
   sqsClient: SQSClient;
 };
 
-function createDocumentClient(): DynamoDBDocumentClient {
-  const ddbClient = new DynamoDBClient({});
-  return DynamoDBDocumentClient.from(ddbClient);
-}
-
-function createLetterRepository(
-  log: pino.Logger,
-  // eslint-disable-next-line @typescript-eslint/no-shadow
-  envVars: EnvVars,
-): LetterRepository {
-  const config = {
-    lettersTableName: envVars.LETTERS_TABLE_NAME,
-    lettersTtlHours: envVars.LETTER_TTL_HOURS,
-  };
-
-  return new LetterRepository(createDocumentClient(), log, config);
-}
-
 export function createDependenciesContainer(): Deps {
   const log = pino();
 
   return {
-    letterRepo: createLetterRepository(log, envVars),
     logger: log,
     env: envVars,
     sqsClient: new SQSClient({}),