Terraform fixes

Author: stevebux

infrastructure/terraform/components/api/module_lambda_letter_stream_forwarder.tf

@@ -60,9 +60,13 @@ data "aws_iam_policy_document" "letter_stream_forwarder_lambda" {
 
 resource "aws_lambda_event_source_mapping" "letter-stream-forwarder_dynamodb" {
   event_source_arn                     = aws_dynamodb_table.letters.stream_arn
-  function_name                        = aws_lambda_function.letter-stream-forwarder.arn
+  function_name                        = module.letter-stream-forwarder.function_arn
   starting_position                    = "LATEST"
   batch_size                           = 10
   maximum_batching_window_in_seconds   = 1
   scaling_config { maximum_concurrency = 10 }
+
+  depends_on = [
+    module.letter-stream-forwarder       # ensures stream forwarder exists
+  ]
 }

infrastructure/terraform/components/api/module_lambda_letter_updates_transformer.tf

@@ -57,9 +57,14 @@ data "aws_iam_policy_document" "letter_updates_transformer_lambda" {
 
 resource "aws_lambda_event_source_mapping" "letter_updates_transformer_kinesis" {
   event_source_arn                     = aws_kinesis_stream.letter_change_stream.arn
-  function_name                        = aws_lambda_function.letter_updates_transformer.arn
+  function_name                        = module.v.function_arn
   starting_position                    = "LATEST"
   batch_size                           = 10
   maximum_batching_window_in_seconds   = 1
   scaling_config { maximum_concurrency = 10 }
+
+
+  depends_on = [
+    module.letter_updates_transformer       # ensures stream forwarder exists
+  ]
 }