Terraform fixes

Author: stevebux

infrastructure/terraform/components/api/module_lambda_letter_stream_handler.tf

@@ -2,7 +2,7 @@ module "letter_updates_transformer" {
   source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip"
 
   function_name = "letter-stream-handler"
-  description   = "Letter Update Filter/Producer"
+  description   = "Kinesis stream handler for DDB letter status updates"
 
   aws_account_id = var.aws_account_id
   component      = var.component
@@ -15,7 +15,7 @@ module "letter_updates_transformer" {
   kms_key_arn           = module.kms.key_arn
 
   iam_policy_document = {
-    body = data.aws_iam_policy_document.letter_updates_transformer_lambda.json
+    body = data.aws_iam_policy_document.letter_stream_handler_lambda.json
   }
 
   function_s3_bucket      = local.acct.s3_buckets["lambda_function_artefacts"]["id"]
@@ -40,19 +40,7 @@ module "letter_updates_transformer" {
   })
 }
 
-data "aws_iam_policy_document" "letter_updates_transformer_lambda" {
-  statement {
-    sid    = "Kinesis permissions"
-    effect = "Allow"
-
-    actions = [
-      "kinesis:GetRecords",
-    ]
-
-    resources = [
-      aws_kinesis_stream.letter_change_stream.arn
-    ]
-  }
+data "aws_iam_policy_document" "letter_stream_handler_lambda" {
 
   statement {
     sid    = "Kinesis permissions"
@@ -67,12 +55,3 @@ data "aws_iam_policy_document" "letter_updates_transformer_lambda" {
     ]
   }
 }
-
-resource "aws_lambda_event_source_mapping" "letter_updates_transformer_kinesis" {
-  event_source_arn                     = aws_kinesis_stream.letter_change_stream.arn
-  function_name                        = module.letter_updates_transformer.lambda_function_name
-  starting_position                    = "LATEST"
-  batch_size                           = 10
-  maximum_batching_window_in_seconds   = 1
-  scaling_config { maximum_concurrency = 10 }
-}

infrastructure/terraform/components/api/module_lambda_letter_updates_transformer.tf

@@ -54,3 +54,12 @@ data "aws_iam_policy_document" "letter_updates_transformer_lambda" {
     ]
   }
 }
+
+resource "aws_lambda_event_source_mapping" "letter_updates_transformer_kinesis" {
+  event_source_arn                     = aws_kinesis_stream.letter_change_stream.arn
+  function_name                        = module.letter_stream_handler_lambda.lambda_function_name
+  starting_position                    = "LATEST"
+  batch_size                           = 10
+  maximum_batching_window_in_seconds   = 1
+  scaling_config { maximum_concurrency = 10 }
+}

infrastructure/terraform/modules/eventpub/README.md

@@ -0,0 +1,19 @@
+<!-- BEGIN_TF_DOCS -->
+<!-- markdownlint-disable -->
+<!-- vale off -->
+
+## Requirements
+
+No requirements.
+## Inputs
+
+No inputs.
+## Modules
+
+No modules.
+## Outputs
+
+No outputs.
+<!-- vale on -->
+<!-- markdownlint-enable -->
+<!-- END_TF_DOCS -->